Help with pic 12f629

[mackrackit]

DEFINE OSC 4
   @ __config _INTRC_OSC_NOCLKOUT & _WDT_ON & _MCLRE_OFF & _CP_OFF
    CMCON=7 
    
    cnt VAR BYTE
    boton VAR GPIO.2
    mosfet VAR GPIO.1

    cnt = 0
   
    CHECK:
    IF boton = 0 THEN TEST
    LOW mosfet
    GOTO CHECK   
    
    TEST:
    IF cnt < 3 THEN OFF_MOSFET
    IF cnt => 3 THEN ON_MOSFET
    GOTO CHECK
    
    OFF_MOSFET:
    PAUSE 100
    IF boton = 0 THEN
    low mosfet
    cnt = cnt + 1
    ENDIF
    GOTO CHECK
    
    On_MOSFET:
    HIGH mosfet
    pause 1000
    low mosfet
    cnt = 0
    GOTO CHECK
    end

[gutisie]

DEFINE OSC 4
   @ __config _INTRC_OSC_NOCLKOUT & _WDT_ON & _MCLRE_OFF & _CP_OFF
    CMCON=7 
    
    cnt VAR BYTE
    boton VAR GPIO.2
    mosfet VAR GPIO.1

    cnt = 0
   
    CHECK:
    IF boton = 0 THEN TEST
    LOW mosfet
    GOTO CHECK   
    
    TEST:
    IF cnt < 3 THEN OFF_MOSFET
    IF cnt => 3 THEN ON_MOSFET
    GOTO CHECK
    
    OFF_MOSFET:
    PAUSE 100
    IF boton = 0 THEN
    low mosfet
    cnt = cnt + 1
    ENDIF
    GOTO CHECK
    
    On_MOSFET:
    HIGH mosfet
    pause 1000
    low mosfet
    cnt = 0
    GOTO CHECK
    end

Hi guys, thanks again, your are wonderfull!!.

Unfortunately, this code gives me error 118.

Thanks.
Best regards.

[mackrackit]

If you are setting the configs in code space comment that line out.

[gutisie]

Hi Dave, yes thats it.

When I delete the first 2 lines "define ocs" and "@...", both codes compile ok.

Unfortunately, the behaviour is basicaly the same....they start with led off, and it should be on, more over, the counting is not regular, it depends in the speed of the click.
Some times, it goes off at 3, others at 5...etc....

I dont know....it is very over me.
I have tried to cut here and there taking ideas from both codes, but it does not work either.

I have to mention, that the clicks will be very fast, we could have posibly.......20 clicks per second, but we need to stop the mosfet after counting 3 clicks, hence the pause for 1 second.

I am sorry, my spanish brain is too tyre and can not speak properly.

Thanks for helping me guys.
Much appreciated.

Best regards.

[mackrackit]

You might not need the
DEFINE OSC 4
but it is a good idea to put it in. That is the line that tell PBP how fast the chip is running. I assume you are using the 4MHz internal.

The state of the mosfet/led depends on how you have the hardware setup. Just change the LOW/HIGH around to do what you want.

Like I said before. This will need a good denouncing routine to work correctly. Now that you say the button could be pressed at 20HZ even more so. What is going to press a button that fast?

Here are a couple of threads that might help you.
http://www.picbasic.co.uk/forum/showthread.php?t=13516
http://www.picbasic.co.uk/forum/showthread.php?t=2180

Read them all the way through.

[gutisie]

Hi dave,

Thanks for your help, I will have a look at the links later.

Yes you are right, I am using the internal oscillator at 4 mhz.

The botton is pressed by a piston.
So I need to stop the piston after 3 pulses.

Thanks.

[mackrackit]

Is it really a button type switch or some other kind of sensor?

I ask because a mechanical switch may not be the best at high speeds.

And the way you have the code implies the button is pulled high and at button press goes to zero volts. This can cause arcing as the contacts open giving the chance of several "make/breaks" on each press.

If the switch were wired pulled low and pressing it brought it high then the arcing is almost not a problem.

Just thoughts....

[Acetronics2]

The botton is pressed by a piston.
So I need to stop the piston after 3 pulses.

Thanks.

Some Hall effect sensor would be to consider, instead ...

just me ...

Alain