Serin serout problem

[lerameur]

By the way , the LCD is there basically to tell me what is goign on .
anyway , here is the complete program :
sending:

' Picbasic Pro program to read DS1820 1-wire temperature sensor
' and display temperature on LCD
' FOR SENDING SERIAL
INCLUDE "modedefs.bas"
DEFINE OSC 20 'use external 20mhz crystal

CMCON = 7 : ANSEL = 0 : ADCON1 = 7
' Define LCD pins
DEFINE LCD_DREG PORTA ' Set LCD Data port
DEFINE LCD_DBIT 0 ' Set starting Data bit (0 or 4) if 4-bit bus

DEFINE LCD_RSREG PORTB ' Set LCD Register Select port
DEFINE LCD_RSBIT 1 ' Set LCD Register Select bit

DEFINE LCD_EREG PORTB ' Set LCD Enable port
DEFINE LCD_EBIT 0 ' Set LCD Enable bit

DEFINE LCD_BITS 4 ' Set LCD bus size (4 or 8 bits)
DEFINE LCD_LINES 2 ' Set number of lines on LCD

TRISB.2 =0
TRISB.3 =1
DQ var PortB.4
temp var word
'27
temperature var word
count_remain var byte
count_per_c var byte
counter var byte
tempc var word
dataout var word
dataout2 var word
datain var word
array var word
encoded1 var word
encoded2 var word
encoded22 var word
encoded11 var word


loop:
owout DQ,1,[$cc]
owout DQ,0,[$44]
Pause 500
owout DQ,1,[$cc]
owout DQ,0,[$be]
owin DQ, 0, [temperature.LOwBYTE, temperature.Highbyte, Skip 4, count_remain, count_per_c]
'50
temperature = ((( temperature >> 1) *100)- 25) + (((count_per_c - count_remain) * 100) / count_per_c)
tempc = (((temperature *9) / 5)+3200)
dataout = temperature / 100
dataout2 = temperature

encoded1 =temperature.LowBYTE
encoded2 =temperature.HighBYTE

For counter=0 TO 7
IF encoded1.0[counter]=0 Then
encoded11.0[counter*2]=0
encoded11.0[counter*2+1]=1
Else
encoded11.0[counter*2]=1
encoded11.0[counter*2+1]=0
EndIF
Next counter

For counter=0 TO 7
IF encoded2.0[counter]=0 Then
encoded22.0[counter*2]=0
encoded22.0[counter*2+1]=1
Else
encoded22.0[counter*2]=1
encoded22.0[counter*2+1]=0
EndIF
Next counter
lcdout $FE,1
LCDOUT BIN temperature , ".", dec (temperature / 10)," ",$DF,"C"
lcdout $FE,$C0, bin encoded22.HighBYTE , ".", bin encoded2," ",$DF,"F"
serout portb.2, n2400, [encoded22.HighBYTE, encoded22.LowBYTE, encoded11.HighBYTE, encoded11.LowBYTE ]
goto loop

End


AND RECEIVING:
' Picbasic Pro program to read DS1820 1-wire temperature sensor
' and display temperature on LCD
' FOR Receiving SERIAL
INCLUDE "modedefs.bas"
DEFINE OSC 20 'use external 20mhz crystal

CMCON = 7 : ANSEL = 0 : ADCON1 = 7
' Define LCD pins
DEFINE LCD_DREG PORTA ' Set LCD Data port
DEFINE LCD_DBIT 0 ' Set starting Data bit (0 or 4) if 4-bit bus

DEFINE LCD_RSREG PORTB ' Set LCD Register Select port
DEFINE LCD_RSBIT 1 ' Set LCD Register Select bit

DEFINE LCD_EREG PORTB ' Set LCD Enable port
DEFINE LCD_EBIT 0 ' Set LCD Enable bit

DEFINE LCD_BITS 4 ' Set LCD bus size (4 or 8 bits)
DEFINE LCD_LINES 2 ' Set number of lines on LCD
'22
datain2 var word
datain var word
dataout var word
counter var byte
temperature var word
encoded1 var word
encoded2 var word
encoded11 var word
encoded22 var word

pause 500

loop:
'36
serin portB.3, n2400,[ encoded22.HighBYTE, encoded22.LowBYTE, encoded11.HighBYTE, encoded11.LowBYTE]

lcdout $FE,1
LCDOUT "datain: ", BIN 5
lcdout $FE,$C0, "datain2: ", bin encoded22.HighBYTE , ".", dec datain2," ",$DF,"C"
Pause 500

For counter=0 TO 7 'decoding
encoded1.0[counter]=encoded11.0[counter*2]
encoded2.0[counter]=encoded22.0[counter*2]
Next counter

temperature= encoded1 ' putting back together as the original temperature
For counter=0 TO 7
temperature.0[counter+8]=encoded2.0[counter+8]
Next counter

goto loop

End

[rhino]

If you're not using a Qualifier, I think you need to use Serin2. Maybe you can use it without the qualifier... I don't know.

SERIN Pin,Mode,{Timeout,Label,}{[Qual...],}{Item...}
‘ Wait until the character
serially on Pin1 and put
SERIN 1,N2400,[“A”],B0

....The list of data items to be received may be preceded by one or more
qualifiers enclosed within brackets. SERIN must receive these bytes in
exact order before receiving the data items.

SERIN2 DataPin{\FlowPin},Mode,{ParityLabel,}{Timeout,Labe l,}[Item...]
‘ Wait until the character “A” is received
serially on Pin1 and put next character into B0
SERIN2 1,16780,[WAIT(“A”),B0]

Either way, I'd try to send a qualifier down. Either the Serin format or as noted in the manual with Serin2.

[skimask]

AND RECEIVING:
.......................................
pause 500

lcdout $FE,1 - put this above your main loop, you don't need to 'home' the LCD, you already do that with $FE,$C0.

loop:
'36
serin portB.3, n2400,[ encoded22.HighBYTE, encoded22.LowBYTE, encoded11.HighBYTE, encoded11.LowBYTE]

LCDOUT "datain: ", BIN 5 ------------- ???? what's this for?

lcdout $FE,$C0, "datain2: ", bin encoded22.HighBYTE , ".", dec datain2," ",$DF,"C" ---------- where is datain2 getting set at?

Pause 500

For counter=0 TO 7 'decoding
encoded1.0[counter]=encoded11.0[counter*2]
encoded2.0[counter]=encoded22.0[counter*2]
Next counter

temperature= encoded1 ' putting back together as the original temperature
For counter=0 TO 7
temperature.0[counter+8]=encoded2.0[counter+8]
Next counter

goto loop

End

No LCD_RWREG or LCD_RWBIT defines in either transmit or receive sections.

Add:
DEFINE LCD_COMMANDUS 2500
DEFINE LCD_DATAUS 250
to both sections.

Increase initial pause to 1000 or higher as needed.

Where is datain2 getting it's value from?

You don't do your decoding/etc until after you've displayed it. Change that around.

Check the listing above for other notes.

[lerameur]

LCDOUT "datain: ", BIN 5 ------------- ???? what's this for?
I was just testing my LCDout

lcdout $FE,$C0, "datain2: ", bin encoded22.HighBYTE , ".", dec datain2," ",$DF,"C" ---------- where is datain2 getting set at?
Past program , forgot to remove it, was just using the first line for LCDout


In the receiving chip, nothing is happening, its going in but not recognizing it.
This is the code I have, nothing is going to the lcd screen. If I remove the SERIN line, then the LCDOUT work, but gives me all 1. (thats normal its not seeing anything)
How do i output this on the lcd ?
It seems that i cannot use the command SERIN and LCDOUT in the same program...


serin portB.2, n2400,[ encoded22.HighBYTE, encoded22.LowBYTE, encoded11.HighBYTE, encoded11.LowBYTE]

LCDOUT "d: ", BIN encoded22.HighBYTE ,".",bin encoded22.LowBYTE ---------------------not outputting what i want
lcdout $FE,$C0, "datain2: ", bin encoded22.HighBYTE , ".", bin encoded22.HighBYTE," ",$DF,"C"
Pause 500

[skimask]

'TRANSMIT
INCLUDE "modedefs.bas"
DEFINE OSC 20 'use external 20mhz crystal
CMCON = 7 : ANSEL = 0 : ADCON1 = 7
DEFINE LCD_DREG PORTA ' Set LCD Data port
DEFINE LCD_DBIT 0 ' Set starting Data bit (0 or 4) if 4-bit bus
DEFINE LCD_RSREG PORTB ' Set LCD Register Select port
DEFINE LCD_RSBIT 1 ' Set LCD Register Select bit
DEFINE LCD_EREG PORTB ' Set LCD Enable port
DEFINE LCD_EBIT 0 ' Set LCD Enable bit
DEFINE LCD_BITS 4 ' Set LCD bus size (4 or 8 bits)
DEFINE LCD_LINES 2 ' Set number of lines on LCD

DEFINE LCD_RWREG ----------------DEFINE YOUR RW REGISTER
DEFINE LCD_RWBIT ----------------DEFINE YOUR RW REGISTER

trisb.2 = 0 : trisb.3 = 1 : dq var portb.4 : temp var word : tempf var word
pause 2500

loop:
lcdout $fe , $c0 , "Getting..."
owout DQ , 1 , [ $cc ] : owout DQ , 0 , [ $44 ] : Pause 500
owout DQ , 1 , [ $cc ] : owout DQ , 0 , [ $be ]
owin DQ , 0 , [ temp.LOWBYTE , temp.HIGHBYTE , skip 6 ]
tempf = temp * 9 : tempf = tempf / 5 : tempf = tempf + 32
lcdout $fe , $c0 , "Displaying"
lcdout $fe , $80 , "Tc=" , DEC temp , "C,Tf=" , DEC tempf , "F.."
lcdout $fe , $c0 , "Sending..." : serout portb.2 , n2400 , [ temp, tempf ]
lcdout $fe , $c0 , "Data Sent."
goto loop
End


'RECEIVE
INCLUDE "modedefs.bas"
DEFINE OSC 20 'use external 20mhz crystal
CMCON = 7 : ANSEL = 0 : ADCON1 = 7
DEFINE LCD_DREG PORTA ' Set LCD Data port
DEFINE LCD_DBIT 0 ' Set starting Data bit (0 or 4) if 4-bit bus
DEFINE LCD_RSREG PORTB ' Set LCD Register Select port
DEFINE LCD_RSBIT 1 ' Set LCD Register Select bit
DEFINE LCD_EREG PORTB ' Set LCD Enable port
DEFINE LCD_EBIT 0 ' Set LCD Enable bit
DEFINE LCD_BITS 4 ' Set LCD bus size (4 or 8 bits)
DEFINE LCD_LINES 2 ' Set number of lines on LCD

DEFINE LCD_RWREG ----------------DEFINE YOUR RW REGISTER
DEFINE LCD_RWBIT ----------------DEFINE YOUR RW REGISTER

temp var word : tempf var word : pause 2500
loop:
lcdout $fe , $c0 , "Waiting..."
serin portB.3 , n2400 , 1000 , loop , [ temp , tempf ]
lcdout $fe , $c0 , "Received.." : lcdout $fe , $c0 , "Displaying"
lcdout $fe , $80 , "Tc=" , DEC temp , "C,Tf=" , DEC tempf , ".."
lcdout $fe , $c0 , "Displayed."
goto loop
End



Little steps like I told you before...
Get the basics working. Add in the temperature correction code after you get the basic temperature displayed. Blow on the element, make it change, get it 'in the ballpark'. Forget about the encoding/decoding. If you can't get temp to be displayed as it is without the wireless, how are you going to get it to work with the wireless? Magic? Me thinks not...
Make your LCD work for you. Notice I added a bunch of lines telling me what the PIC is doing. Use them often!
And you had your C to F conversion backwards, and there was no way your original program was going to work. You had your decoding happening after you displayed the results. If you're going to send the whole code, send the whole code.
Post back when this works. If it doesn't work, you've got other problems, hardware.

[lerameur]

about the LCD_RWREG, I stuck my lcd pin to ground, so it should always be write function.

I still get the same problem , The lcdout do not display the inpuT from serin. tHE LCD shows on the second line : 'Waiting...'
It seems to me that the as soon as it sees the serin command it skips all the lcdout afterward, and loops again.

[skimask]

about the LCD_RWREG, I stuck my lcd pin to ground, so it should always be write function.

I still get the same problem , The lcdout do not display the inpuT from serin. tHE LCD shows on the second line : 'Waiting...'
It seems to me that the as soon as it sees the serin command it skips all the lcdout afterward, and loops again.

LCD_RWBIT....ok, understood. I'd define it anyways to an unused pin just to keep PBP from thinking otherwise.

Screwed up a bit overall. You can't send words thru a bytewide serial port!

Try this instead:


'TRANSMIT
INCLUDE "modedefs.bas"
DEFINE OSC 20 'use external 20mhz crystal
CMCON = 7 : ANSEL = 0 : ADCON1 = 7
DEFINE LCD_DREG PORTA ' Set LCD Data port
DEFINE LCD_DBIT 0 ' Set starting Data bit (0 or 4) if 4-bit bus
DEFINE LCD_RSREG PORTB ' Set LCD Register Select port
DEFINE LCD_RSBIT 1 ' Set LCD Register Select bit
DEFINE LCD_EREG PORTB ' Set LCD Enable port
DEFINE LCD_EBIT 0 ' Set LCD Enable bit
DEFINE LCD_BITS 4 ' Set LCD bus size (4 or 8 bits)
DEFINE LCD_LINES 2 ' Set number of lines on LCD

trisb.2 = 0 : trisb.3 = 1 : dq var portb.4 : temp var word : tempf var word
pause 2500

loop:
lcdout $fe , $c0 , "Getting..."
owout DQ , 1 , [ $cc ] : owout DQ , 0 , [ $44 ] : Pause 500
owout DQ , 1 , [ $cc ] : owout DQ , 0 , [ $be ]
owin DQ , 0 , [ temp.LOWBYTE , temp.HIGHBYTE , skip 6 ]
tempf = temp * 9 : tempf = tempf / 5 : tempf = tempf + 32
lcdout $fe , $c0 , "Displaying"
lcdout $fe , $80 , "Tc=" , DEC temp , "C,Tf=" , DEC tempf , "F.."
lcdout $fe , $c0 , "Sending..."
serout portb.2 , n2400 , [ temp.highbyte , temp.lowbyte ]
serout portb.2 , n2400 , [ tempf.highbyte , tempf.lowbyte ]
lcdout $fe , $c0 , "Data Sent."
goto loop
End


'RECEIVE
INCLUDE "modedefs.bas"
DEFINE OSC 20 'use external 20mhz crystal
CMCON = 7 : ANSEL = 0 : ADCON1 = 7
DEFINE LCD_DREG PORTA ' Set LCD Data port
DEFINE LCD_DBIT 0 ' Set starting Data bit (0 or 4) if 4-bit bus
DEFINE LCD_RSREG PORTB ' Set LCD Register Select port
DEFINE LCD_RSBIT 1 ' Set LCD Register Select bit
DEFINE LCD_EREG PORTB ' Set LCD Enable port
DEFINE LCD_EBIT 0 ' Set LCD Enable bit
DEFINE LCD_BITS 4 ' Set LCD bus size (4 or 8 bits)
DEFINE LCD_LINES 2 ' Set number of lines on LCD

temp var word : tempf var word : pause 2500
loop:
lcdout $fe , $c0 , "Waiting..."
serin portB.3 , n2400 , 1000 , loop , [ temp.highbyte , temp.lowbyte , tempf.highbyte , tempf.lowbyte ]
lcdout $fe , $c0 , "Received.." : lcdout $fe , $c0 , "Displaying"
lcdout $fe , $80 , "Tc=" , DEC temp , "C,Tf=" , DEC tempf , ".."
lcdout $fe , $c0 , "Displayed."
goto loop
End

[lerameur]

The same thing is happeneing as before,
the LCD is just showing 'Waiting ... ' on the receiving unit
And I can see on the scope a signal coming in on portB3

ken