1 Continuous MCPWM at a time

[barneyfrance]

Thanks it is working now, I made a huge mistake that I am so ashamed to make you waste your time with me. I am testing everything on a breadboard and my potentiometer was still connected to a resistance somewhere... I feel silly. Well at least it is working.

I am grateful for your time and your patience.

I am now getting started with my commutation sequence. Thank you again !
Even if this pic is complicated, I'm starting to see how powerful it is.

[Bruce]

I made a huge mistake

Been there - done that - just spank yourself, take notes & move on...

[barneyfrance]

Been there - done that - just spank yourself, take notes & move on...

I did

Hi again !

I would like your opinions guys in terms of "state of the art" way to write a picbasic pro program
I am getting inputs from an encoder, I have 12 positions possible, therefore 12 values. here is an example of my code for 2 values. I was wondering if the use of "Case" would be a better idea, that way if I decide to turn off my "switch" my program stops immediatly and is not finishing its loop before seeing that the switch's value changed.

encoderstate1 var Byte 
duty var Word

Main:
encoderstate1 = PORTA
If switch = 1 Then
 

        If encoderstate = 0 Then
            GoSub GetADC
            GoSub SetPWM           
            OVDCOND = %00100010 'Q4 (PWM5) and Q10 (PWM1)
            PORTC = %00000011   'Q1 and Q7 ON
        EndIf        
        If encoderstate1 = 1 Then
            GoSub GetADC
            GoSub SetPWM
            OVDCOND = %00000110
            PORTC = %00001100
            
        EndIf

GoTo Main

Getadc is my subroutine for my pot and pwm to adjust the duty cycle regarding the value of the pot.

Suggestions ?

[HenrikOlsson]

Hi,
Sure, Select-Case is an option. It's "cleaner" but does result in slightly larger code than multiple IF-THEN statements. But if you're not short on space go ahead.

Another option might be to use BRANCH.

Also, perhaps you can move the GOSUB GetADC and GOSUB SetPWM to right after the If Switch=1 Then statement? That will save you a couple of bytes of program space and since, if I'm not mistaken, all twelve different encoder states calls both those routines you might as well do before evaluting the encoder value.

/Henrik.

[barneyfrance]

Hello Henrik,

I tried the code below with case and it does not work

encoderstate1 var Byte 
duty var Word

Main:
encoderstate1 = PORTA


If switch = 1 Then
 
        Select case encoderstate1

        Case 0
            GoSub GetADC
            GoSub SetPWM           
            OVDCOND = %00100010 'Q4 (PWM5) and Q10 (PWM1)
            PORTC = %00000011   'Q1 and Q7 ON

        Case 1
            GoSub GetADC
            GoSub SetPWM
            OVDCOND = %00000110
            PORTC = %00001100
            End Select
            
EndIf

GoTo Main

What am I doing wrong here ???? in my 2 cases, portA = 0 and portA = 1 in the other one (PORTA.0=1). The first code given with IF... THEN works but not this one ?


PS : I'll try tomorrow morning (don't have access to my pic right now) to put the subroutines just once as well as that "Branch"

[HenrikOlsson]

Hello,
I can't really see any problem with it.... What does doesn't work mean in this case, what does it do?

The only think I can think of is if you have anything else connected to PortA so that the actual value assigned to EncoderState1 isn't 0 even when the encoder is in the zero-position. But since it works with the IF-THEN version it can't be that (?).

Do you have a serial connection setup? If so you can HSEROUT some debug information which will make it easier to figure out what's going on. If not perhaps you could blink a LED the same number of times as the value that gets assigned to EncoderState1, just to see what's going on.

/Henrik.

[barneyfrance]

Hello,

Thank you for your reply,
The IF...THEN code still works (thanks for the tip putting just the subroutines at the top of main).

Do you have a serial connection setup? If so you can HSEROUT some debug information which will make it easier to figure out what's going on.

I am only using a PICkit 2 programmer. ?!

If not perhaps you could blink a LED the same number of times as the value that gets assigned to EncoderState1, just to see what's going on.

What do you mean ??


This morning I've tried a different code :

 
Main:
encoderstate1 = PORTA

        Select encoderstate1
        Case %000000
            GoSub GetADC
            GoSub SetPWM           
            OVDCOND = %00100010 'Q4 (PWM5) and Q10 (PWM1)
            PORTC = %00000011   'Q1 and Q7 ON   
        Case %000001
            GoSub GetADC
            GoSub SetPWM           
            OVDCOND = %00100010 'Q4 (PWM5) and Q10 (PWM1)
            PORTC = %00000011   'Q1 and Q7 ON
        Case Else 
            PORTC = 0
            OVDCOND = 0
        EndSelect

In case 0, it is doing what it should do, now if I'm trying to give the value of 1 (I have a switch on portA.0, that is all !!) it jumps to case else, it means that it does not see the value 1 ??? Why not ? it is working with IF... THEN...
Moreover, after switching my switch and giving the value 1 to portA.0, 4seconds after, it acts like if the value on portA.0 was 0... ???

AHHH sometimes those pics know how to make you crazy, doesn't they ?
Thanks for the help. Very much appreciated