Wow....first I've seen of it here...unlike those other 6 threads...Originally Posted by Kalind
|
Wow....first I've seen of it here...unlike those other 6 threads...
|
well, this is what i managed to do. i hooked it up to my circuit but the program isnt doing what i wanted it to do. Skimask?
/code
Define LCD_DREG PORTB
Define LCD_DBIT 0
Define LCD_RSREG PORTB
Define LCD_RSBIT 5
Define LCD_EREG PORTB
Define LCD_EBIT 4
DEFINE LCD_BITS 4
DEFINE LCD_LINES 2
mode var byte
keyin var byte
adval var word
tempc var word
highpt var byte
lowpt var byte
up var portc.0
down var portc.1
sethighp var portc.2
setlowp var portc.3
maindisp var portc.4
trisc=$ff
trisa=$ff
adcon1=$82
adcon0=$c1
pause 100
mode = 1
lcdout $fe , 1
goto main
getkey:
pause 50
keyin = portc
return
gettemp:
adcon0.2=1
pause 1
checkdone:
if adcon0.2=1 then checkdone
adval.highbyte=adresh
adval.lowbyte=adresl
tempc=(50*adval)/100
return
main:
gosub gettemp
gosub getkey
'saving part
if maindisp = 1 then
write 0 , sethighp
pause 10
write 1 , sethighp
mode = 1
endif
if sethighp = 1 then mode = 2
if setlowp = 1 then mode = 3
select case mode
case 1
lcdout $fe , $80 , "Temp = ", DEC3 tempc , $DF , "C"
case 2
lcdout $fe , $80 , "High Sp=" , $fe , $c0 , highpt
if up = 1 then highpt = highpt + 1
if down = 1 then highpt = highpt - 1
case 3
lcdout $fe , $80 , "Low Pt=" , $fe , $c0 , lowpt
if up = 1 then lowpt = lowpt + 1
if down = 1 then lowpt = lowpt - 1
end select
goto main
Last edited by Kalind; - 20th October 2008 at 13:02.
|
Looks like it's pretty much what I managed to do...
It might help for you to tell us exactly what it IS or isn't doing...i hooked it up to my circuit but the program isnt doing what i wanted it to do.
|
taking your advice with the program, i hooked it up and on the lcd it prompts the user to enter a LOW SP. upon the use of the increment decrement buttons, on the second line of the lcd are characters which are being displayed. when the 'main' button is pressed, it does not go to the main display and also when the HighSp button is pressed, it does not go to that screen. im so lost with this whole thing
|
Put yours subrouteenes at the end of your code, never at the beginning!
Modify your If then in the following manner:
if maindisp = 1 then
write 0 , sethighp
pause 10
write 1 , sethighp
mode = 1
maindisp = 0 ' reset flag
endif
Otherwise it will write at every cycle and in this case you do not need the " IF Then " statement. Set your flag to 1 when writing is needed
Yours code for reading key:
getkey:
pause 50
keyin = portc
return
You read the status of the all 8 inputs, than you need to decode to find which key has been pressed.
More:
Are you pulling up your inputs using normally closed switches? otherwise with this code you have to pull down your inputs.
Al.
Last edited by aratti; - 20th October 2008 at 14:23.
|
Disagree 100%, ok maybe 99%
If using a PIC16 (or 12,or 10) series PIC, if you are able to keep the 'subroutines' in the first bank of code space, you'll save code space due to the fact that the BANK Select registers don't need to be changed, and at the same time save instruction cycles. And if your subroutines are at the beginning, they're the first thing to get seen while skimming thru the code, makes them harder to forget them (I guess more of a brain thing there).
At any rate, there's one more small bug in your If/Then correction above (post #13)...a small one...actually two small bugs...one matters, the other doesn't really matter...
|
Ok, are you sure all of your buttons are working properly?
|
yup. They connected from +5v to ground using a 10K
|
No, what I mean is, how do you know the PIC and/or your code is actually recognizing the buttons as pressed or not-pressed.
Again, just 'cause you want it doesn't mean it...
And what do you mean from +5v to ground using 10K? Leaves a bit to the imagination...
|
Humour me for a bit...
Push the buttons, what happens?Code:Define LCD_DREG PORTB Define LCD_DBIT 0 Define LCD_RSREG PORTB Define LCD_RSBIT 5 Define LCD_EREG PORTB Define LCD_EBIT 4 DEFINE LCD_BITS 4 DEFINE LCD_LINES 2 keyin var byte : trisc=$ff : pause 1000 : lcdout $fe,1 main: keyin = portc : lcdout $fe, $80, BIN8 keyin : goto main end
|
should display binary number
|
And does it?
|
i dont know..this isnt the main concern...lets get back to reality
|
I tried...I give up...
Not the main concern? Where are you at? Happy-ville where everything works the 1st time according your wishes?
That little 'display a binary number' program would verify that all of your buttons actually work and change states. If your buttons don't work in the first place, which you're not 100% sure they do, you just say they do because they're connected, how do you expect the rest of the program to follow suit?
Get back to reality? Here's a bit of reality for you... I was all set to lead you from one place to the next to the end, with a ready-made program, and figured you might learn a little bit of something along the way.
Here's the reality part...How about you finish this project on your own? Then let us know how that goes for you?
Maybe somebody else with a bigger heart will come along, write the code to exactly watch your specifications and your hardware, debug it, test it under all known conditions, then drop by your house some weekend, with a finished PCB, a CD with all of the code on it, fully commented and explained in a long long video, and might even bring a 6-pack of your favorite beverage, and a large pizza from the local vendor.
As Dennis Miller used to say on Saturday Night Live back in the day "That's the news, and I am outta here!!!"
Members who have read this thread : 0You do not have permission to view the list of names.
Posting Permissions
Bookmarks