Problem using Else

[skimask]

Anyhow, it works, tx side seems to be fine, my big problem is on the rx side each output that is a if/then statement will come on but when I release the button it stays on. The only way to make it turn off is to press another momentary button. The toggle function works fine, although if I hold onto the button to long it will toggle on/off. if/then example I have tried after Skimask post:

Debouncing isn't going to work very well without a 'switch' to actually debounce. If you're trying to debounce a received signal, I don't think that it's the right way to go about it.
This shouldn't be all that hard...but if you continue having problems, you might want to thinking about sending MAKE and BREAK codes with the TX similar to a PC keyboard.
I.E. code1 = button 1 pressed
code2 = button 1 released
code3 = button 2 pressed....
and so on and so on...

[Archangel]

is the space in the word "address" a cut paste error or a typo in the transmit code?

transmit:

serout serpin,N9600[$55,$55,$55,$55,$55,$AA,$AA,$AA,$AA,$AA,synch,<font color=red>addr ess</font color>,address,keydata,keydata,chk_sum]
if keyin = nokey then x2
goto findkey

x2:
high dgood
keydata = %00000000
serout serpin,N9600,[$55,$55,$55,$55,$55,$AA,$AA,$AA,$AA,$AA,synch,<font color=red>addr ess</font color>,address,keydata,keydata,chk_sum]
goto findkey
end

[Archangel]

I can turn on any of the ports using realterm and a max232 using the code below.

     INCLUDE "MODEDEFS.BAS"
;@ DEVICE PIC16F628a,XT_OSC
;@ DEVICE pic16F628a, WDT_OFF
;@ DEVICE pic16F628a, PWRT_ON
;@ DEVICE pic16F628a, MCLR_ON
;@ DEVICE pic16F628a, BOD_ON
;@ DEVICE pic16F628a, LVP_OFF
;@ DEVICE pic16F628a, CPD_OFF
;@ DEVICE pic16F628a, PROTECT_OFF
@MyConfig = _HS_OSC & _WDT_OFF & _PWRTE_ON & _LVP_OFF 
@MyConfig = MyConfig & _BODEN_OFF 
@ __config  MyConfig
DEFINE OSC 20
CMCON = 7

trisa = %00000010
trisb = %00000000

PORTA = 0
PORTB = 0

MYDATA1  VAR byte
MYDATA2  var byte
address1 var byte
address2 var byte
checksum var byte
chk_sum  var byte
;serpin   VAR PortA.1
PAUSE 50

loop:
high portA.2
pause 500
low portA.2
gosub loop1
serout portA.0,T9600,[254,2,mydata1," ",mydata2,"          "]
serout portA.0,T9600,[$FE,$C0,address1," ",address2,"          " ]
'CheckSum = (address1 + address2)
'CheckSum = CheckSum + (mydata1 + mydata2)
'IF checksum   != chk_sum THEN loop
'IF (mydata1)  != (mydata2) THEN loop
'IF (address1) != (address2) THEN loop

if mydata1= 86 then toggle portB.0


if mydata1= 89 then
'while mydata1 = 89 ' trying this example for debounce
'pause 50
'wend
high PortB.1

else
low PortB.1
endif

if mydata1 = 90 then
'while mydata1 = 90
'pause 50
'wend
high PortB.2

else
low PortB.2
endif

if mydata1= 101 then
'while mydata1 = 101
'pause 50
'wend
high PortB.3

else
low PortB.3
endif

if mydata1 = 102 then
'while mydata1 = 102
'pause 50
'wend
high PortB.4

else
low PortB.4
endif

if mydata1=105 then toggle PortB.5
if mydata1=106 then toggle PortB.6

goto loop

loop1:
SERIN2 PortA.1,84,[DEC address1,DEC ADDRESS2,DEC MYDATA1,DEC MYDATA2]
Return
end

Much stuff just commented out, serouts added so as to see variable contents, a blinky added for life signs, easy to undo. Thanks for sharing your problem, I got to learn too.

[sayzer]

Tazntex,

You are forgetting something I think.


When you press a button, your IF statement works only WHILE you are pressing the button.

When you do NOT press a button, your ELSE statement works continuously.

This is why "you think" that you see no change; because it happens so fast when you hit the button down and release it.

I think you should set an IF statement with the first button press, and keep it that way until you press it second time. Like a flip flop.

[tazntex]

Yes Joe that is a typo in the copy and paste. When I read all the replies with example code how are ya'll inserting the code block whereas I am just copying and pasting my code to this reply. I am assuming, which I don't like to do, that under additional options I could attach my questionable code.
What does the DEC mean and do? In the manual I understand it to be Decimal as in MYDATA would be recieved as a decimal. After reading many post on Manchester, I would think I would only be using Binary, but it would seem in the end Binary, Decimal and Hex would all be the same.

loop1:
SERIN2 PortA.1,84,[DEC address1,DEC ADDRESS2,DEC MYDATA1,DEC MYDATA2]
Return
end

Sayzer, in the flip/flop method you are speaking of, I can see how to turn an output on/off with the toggle command, but I do not understand how I could press the button on the tx and the output would come on the receiver but would have to release the button and press again to make it go off. As I have it using the toggle command as long as I am pressing the button on the tx the rx output just cycles on and off. Well I will keep reading the PBP manual maybe thats in there and I have missed it. By the way I am using the PBP v2.50 with the update installed.

Many, many thanks to all for your help and patience.

[skimask]

Yes Joe that is a typo in the copy and paste. When I read all the replies with example code how are ya'll inserting the code block whereas I am just copying and pasting my code to this reply. I am assuming, which I don't like to do, that under additional options I could attach my questionable code.

Check out this page for all the neat stuff here on the forums:
http://www.picbasic.co.uk/forum/misc...bbcode#imgcode

(take out the extra spaces here)

[ code ]This will go in a code block[ / code ]

This will go in a code block

And there's a bunch more formatting type stuff listed on that page linked above.

What does the DEC mean and do? In the manual I understand it to be Decimal as in MYDATA would be recieved as a decimal.

It actually means that SERIN (or whatever) will wait until it receives x characters to be interpreted as a decimal.
For instance:
SERIN xxx,xxx,xxx, [ DEC1 x ]
Waits for a single character between "0" and "9", preceeded by a character that's not between "0" and "9" and followed by another character that's not between "0" and "9".
Another for instance:
SERIN xxx,xxx,xxx, [ DEC5 x ]
Waits for 5 consecutive characters that are each between "0" and "9", preceeded by any character that's not between "0" and "9" and followed by another character that's not between "0" and "9".
So, the DEC (or HEX or BIN) modifier actually does 'parsing' of an input stream for you.
HEX would wait for ASCII characters between "0" and "9" in addition to "a" (or "A") through "f" (or "F").
BIN would only wait for "0" and "1".
For reference..."0" = ASCII code 48 ($30), "9" = ASCII code 57 ($39), and so on. Just so we're on the same page here.

[Archangel]

Mostly it means I have an easier time dealing with decimal numbers, than binary, as Jeremy pointed out you can use hex, binary, or decimal, it's all good.

As I have it using the toggle command as long as I am pressing the button on the tx the rx output just cycles on and off.

Your receiver doesn't just stop because you are still holding the button, and besides your transmitter is sending a signal, not some d/c value, additionally when you go the R/F route, this is where switch debouncing comes in and should be on the transmitter I think. I think the transmitter program should send a packet of data, size determined by you, for each valid button press and not just keep sending continuously, otherwise scratchy switches will corrupt your data.