A little code review by the Group

[manwolf]

If you open the file and look in the comments and OPEN your eyes you will see I did credit those I borrowed code from for the program. I did give back, I posted my code back to the forum for all to see and use.

As far as my limited memory can recall I don't remember any of the names Darrel mentioned.

' PROGRAM: Multi_Temp_Sensor.pbp
'
' WRITTEN BY Ted "manwolf" Crafton 2008
' WRITTEN FOR PIC16F877A-I/L MICROPROCESSOR
'   and LAB-X1 with multiple DS18S20s on breadboard
'   or wired remote.
'
' To DO soon:
'	Learn how to break the 64 bit rom into bytes
'	Learn how to read and write the address to EEPROM
'	Update the Temperature conversion to handle neg as well as Pos
'	temps and get it a little more accurate.
'
'* Notes : 
'* :  part of the main search program is copied from a thread by Jimbab, 
' http://www.picbasic.co.uk/forum/showthread.php?t=3671
'
'* :  Part of this code from MeLabs example
'
'* :  Part of this code required brain cells

I dug around and found the code I used for the Search and it turns out I credited the wrong person.

 PROGRAM: 1_WIRE_SEARCH.bas
'
' WRITTEN BY DAVID PUROLA 9/18/2003
' WRITTEN FOR PIC18F452-I/L MICROPROCESSOR
'

Sorry Mr. Purola, I have corrected the oversight.

I should mention Bruce Rynolds, didn't use any code but did read it to learn how to do what I wanted.
http://www.rentron.com/PicBasic/one-wire2.htm

And last but not least my wife for not pulling the plug. Only comment from her was "Oh, you doing that again?"

I have been writting code for 20 years and have very thick skin and some say a head as hard as rock. The wife insists on the last point.

Thanks for posting I really did want to hear your comments, needed to learn the lay of land.

Guess I will need to keep a list of everything I read in the future so no one gets left out.

So did anyone look at the code itself and have any comments?

I don't know how to update a file already uploaded. So here is the updated one.

I always look forward to reviews from fellow coders, kind of like having a root canal without the novicane.

[mackrackit]

I looked at the code. I did not makes any comments as I am not up on one wire stuff.

You have been coding for some years. Then you know that if it works then it is OK. I did not notice any thing that is borderline on working.

I may start using one wire. If I do I may use some of your code.

[manwolf]

I may start using one wire. If I do I may use some of your code.

Please feel free, Dave.

And after all those years I have found that if I spend more time with it I can make it better.

I have completed most of the examples provided with both my development boards and felt it was time to go after something that might be useful and more challanging.

Got a little ahead of myself with the one wire and ended up having to use someone elses code. But it turned into a great learning exercise, I have alot better idea of how one wire works and know I have a lot more learning to go.

Going from just about unlimited memory to a PIC is a real eye opener!