Thanks for the reply but the problem is that the program is now (after fixing port a) locking up as soon as I connect the rx pin on the 232 adapter, the serial cable is not even connected and it locks up.
if i comment out the serin code with the 232 connected it works (without serin)
I think the serin command is locking up the program but I don't know why.
The voltage is always 5 volts untill a code comes threw would a constant 5 volts mess up the serin pin? this is a falling trigger do i need to tell the pic what type to look for?
t2400 ? n2400?
I hope I have given enough information, I have been.
what would cause the program to lock up as soon as i connect the serin pin?

thanks again