Need help in code

[camolas]

Hi,

Thanks for the starting hellp

PicbasicPro 2.50





My code

@ DEVICE pic16F877A, WDT_ON ' Watchdog Timer
@ DEVICE pic16F877A, PWRT_ON ' Power-On Timer
@ DEVICE pic16F877A, BOD_ON ' Brown-Out Detect
@ DEVICE pic16F877A, LVP_OFF ' Low-Voltage Programming
@ DEVICE pic16F877A, CPD_OFF ' Data Memory Code Protect
@ DEVICE pic16F877A, PROTECT_OFF ' Program Code Protection
@ DEVICE pic16F877A, WRT_OFF ' Flash Memory Word Enable

TRISB.0=1
TRISB.1=1
TRISC.7=0
LED var PORTC.7

inicio:

if PORTB.0 = 0 then
GOSUB liga
else
low LED
endif
goto inicio

liga:
if PORTB.1=1 then
high LED
PAUSE 200
low LED
else
low LED
endif
goto inicio


end

[JD123]

At first glance, replace the "goto inicio" at the end of the program with "return" (it was called under a "gosub").

[camolas]

I got 2 problems 1 de led dont turn of afther the periode and 2 i need the code to do like a cicle and stops when led off and only start again when "switch" 1 is on again.

[skimask]

I got 2 problems 1 de led dont turn of afther the periode

Fixed by post above?

and 2 i need the code to do like a cicle and stops when led off and only start again when "switch" 1 is on again.

Ok, so how do you determine if the LED is off?
How do you determine if 'switch 1' is on again?
If you can answer those 2 questions, then you should be able to write your code.

[camolas]

Fixed by post above?


Ok, so how do you determine if the LED is off?
How do you determine if 'switch 1' is on again?
If you can answer those 2 questions, then you should be able to write your code.

Fixed by post above?


Ok, so how do you determine if the LED is off?
How do you determine if 'switch 1' is on again?
If you can answer those 2 questions, then you should be able to write your code.

Hi, not fixed.


determine LED - i do not now if i anderstand you well (bad Inglish mine) but by having switch2 pressed led if off. (or if switch1 pressed is off to)

'switch 1' - I only put this switch to try to stop the code there from looping and looping because i only want that led is high 1 time at the time (just when switch1 be pressesd again), then wait for switch2 to be not pressed.

Thanks

[JD123]

One more thing...

Turn the WDT OFF since your not clearing it.

Ex:@ DEVICE pic16F877A, WDT_OFF ' Watchdog Timer off

[mister_e]

The compiler handle it for you

[skimask]

Turn the WDT OFF since your not clearing it.

PBP inserts WDT clearing instructions for you......unless you:
DEFINE NO_CLRWDT 1
in which case, it doesn't. And if you're not using the WDT and if you have it turned off, this can also save a LOAD of code space.

[Acetronics2]

Hi, Camolas

1) some contradiction ...

" text " tells :

if input1 = 1 THEN


WAIT for INPUT2 = 0 == WHILE INPUT2 = 1 : WEND ( loop if INPUT2 = 1 )

WAIT 40s == PAUSE 40000 ... not 200 !
LED ON for 3 s
LED Off
LOOP


the program shows input levels inverted ... ( may be active low pushbuttons ??? did you think to the pullup ? )

I think the first thing for you is to look at the different states ... and write succession of operations in order, more than write lines and try to make them work together.
That's called an ORGANIGRAM ... ( joined an example )

Now, I've almost written your program ... just translate it into PbP commands ( I gave you the "difficult part" command ... )

Alain

[camolas]

Thas i need to put WDT OFF or not?

Yes im going to use low pullup pushbuttons rhas i have to do one more line code for it?

Im very confuse