Help with LCD commands with button I/P

[Archangel]

Hi g7jiq,
looks simple enough, without my trying your code. You want Disp1, disp2, to run only when sent there,
your code

Disp1
lcdout "Standby"
Disp2
lcdout "Main"
Disp3
lcdout $FE,$C0,"Local off " 'display on line 2
lcdout $FE,1
Disp4
LCDOUT $FE,$C0,"local on"
lcdout $FE,1

try:

Disp1:
lcdout "Standby"
return

Disp2:
lcdout "Main"
return

Disp3:
lcdout $FE,$C0,"Local off " 'display on line 2
lcdout $FE,1
return

Disp4:
LCDOUT $FE,$C0,"local on"
lcdout $FE,1
return

end

without the colons the program sees your subdirectories as just the next line of code, the returns send it back to the line after the one which calls it.
JS

[CocaColaKid]

I may be wrong but would you not require a gosub in order to use a return? I believe a simple goto would me more appropriate in this case.

[mister_e]

and there's another danger... DISP3, DISP4,, the second LCD will clear the whole LCd display.

[CocaColaKid]

Oops, your right Steve, I never even noticed that, lol.

[g7jiq]

Hi again

I have had a play with the code, and have placed the colons in as stated,
I still get no display,

One thing I did find is if I place the Disp1: to Disp4: section into the main loop I get a very
fast flashing faint display,
It does change tho when the i/p pin is toggled.

So I may be getting a little closer.

Any ideas.....?

[mister_e]

add a PAUSE 100-250 before you Goto Loop

[Archangel]

Hi again

I have had a play with the code, and have placed the colons in as stated,
I still get no display,

One thing I did find is if I place the Disp1: to Disp4: section into the main loop I get a very
fast flashing faint display,
It does change tho when the i/p pin is toggled.

So I may be getting a little closer.

Any ideas.....?

I will attempt to redeem myself, again without actually wiring up a pic to default LCD settings,

TRISA=%00000000 'Set port A as output
TRISB=%01110111 'Set port B as input except B7 for backlight and B3 for lcd



SW1 VAR PORTB.0
SW2 VAR PORTB.1
SW3 VAR PORTB.2

SW4 VAR PORTB.4
SW5 VAR PORTB.5
SW6 VAR PORTB.6
Backlight VAR PortB.7 'Set var as port B7



low Backlight         'light up lcd backlight

Pause 1000            'stand by for lcd



setup:

LCDOUT $FE,1,   " G7JIQ Micro"   'clear lcd & Display on line 1
lcdout $FE, $C0," Link Repeater" 'Display on line 2
pause 2000
LCDOUT $FE, $0C 'turn off cursor
lcdout $FE,1    'clear display
lcdout $FE,2    'Return Home


loop:

if SW1 = 0 then Disp1  ' if true, disp1
if SW1 = 1 then Disp2  ' if true, disp2
IF SW4 = 0 THEN Disp3  ' if true, disp3
if SW4 = 1 THEN Disp4  ' if true, disp4

goto loop


Disp1:
lcdout "Standby"
pause 1000     ' gives time to see display

goto loop      ' prevents you from having to use gosubs in the loop
               ' however it returns to the beginning of the loop
               ' whereas a gosub would go to the next line in the loop

Disp2:
lcdout "Main"
pause 1000     ' gives time to see display

goto loop      ' prevents you from having to use gosubs in the loop
               ' however it returns to the beginning of the loop
               ' whereas a gosub would go to the next line in the loop

Disp3:
lcdout $FE,$C0,"Local off " 'display on line 2
pause 1000     ' gives time to see display
lcdout $FE,1   ' Erases display

goto loop      ' prevents you from having to use gosubs in the loop
               ' however it returns to the beginning of the loop
               ' whereas a gosub would go to the next line in the loop
Disp4:
LCDOUT $FE,$C0,"local on"
pause 1000     ' gives time to see display
lcdout $FE,1   ' clears display

goto loop      ' prevents you from having to use gosubs in the loop
               ' however it returns to the beginning of the loop
               ' whereas a gosub would go to the next line in the loop


end

There are no config fuses set here as I do not know which compiler you are using of which PIC, so you must add them or manually set the config fuses in your programmer. If you supply the information and also the Oscillator speed and if you are using xtal, resonator or internal oscillator, everyone is sure to help.

[g7jiq]

Hi,

Sorry should have given the hardware spec first,
The pic is a 16F627, the clock crystal is 4mhz and I am using Microcode picbasic pro built in compiler.

I have tried your updated code (many thanks) and at last I get somthing on the display,
But its displays "Standby"Standby"Standby"Standby" etc.. across the display incrementing each word once a second, across the topline and then the bottom line intil its full.

If I toggle the sw1 i/p It changes to "Main"Main"Main" etc.. across both lines of the display until full.

SW4 does nothing .

Whats going wrong....

I didn't think it would be so hard to do, I can do it with LED's but an LCD has me beat.
(but i am one not to be beaten)

Any suggestions......

[Archangel]

I may be wrong but would you not require a gosub in order to use a return? I believe a simple goto would me more appropriate in this case.

YEP!
Shows how close I looked at the code after seeing what I did see! Must have gotten excited.