Need help for PIC16C745

[paul borgmeier]

You did not answer

Did the LED light up in your blink test?

Is your 745 windowed or are you burning new PICs each time?

On the diode, which end (anode or cathode) is connect to 5V?

Do you have an Oscilloscope? [EDIT] I have never used a four pin Xtal so I cannot comment on its correctness. If you have a scope, it would be easy to find out.[/EDIT]

you say "btfsc PORTB,2 ; Has key been press? (Normally high, goes low when pressed.)"
but you described the opposite - normally low and high when pressed. If it truly is opposite your program flies past this routine and then off into the ether. You would never see the light blink at 24MHz clock speed. You need to have a way to either send the program back to top (e.g., goto START) or a way to stop the controller from running away (e.g., goto $)

I beg you to make your LED blink first ... the rest is trivial after that.

[BobK]

Hello,

I too am not an assembly language user but shouldn't there be some sort of delay (250ms at least)after the LED is turned on and another delay (250ms) after it is turned off so you can actually see the LED changing states?

BobK

[paul borgmeier]

Hello,

I too am not an assembly language user but shouldn't there be some sort of delay (250ms at least)after the LED is turned on and another delay (250ms) after it is turned off so you can actually see the LED changing states?

BobK

Yes - that is why I asked

Did the LED not light or did it stay on?

without the delays, if the OP's code was working the LED would appear to the eye as stuck on

I have asked twice.