if-then statements

[sinoteq]

Look at what you have written and you will see why it does not work. Here is a short hint.

MAIN:
lcdout $fe, $80+0, "PUMP off GAS off"
lcdout $fe, $c0+8, "WATER"
if PORTA.2 = 1 then GOTO waterok
if PORTA.2 = 0 then GOTO waterbad
if PORTA.6 = 1 then GOTO tempdown
if PORTA.7 = 1 then GOTO tempup
PAUSE 500
GOTO MAIN

waterok:
lcdout $fe, $c0+13, " OK"
goto main

The problem is that you jump back to main all the time so in this case you will not do the other IF statements. This is why we have GOSUB in PBP, it jumps to a SUB and when you use RETURN you will jump back to the line after..... More or less in any case.

SO

MAIN:
lcdout $fe, $80+0, "PUMP off GAS off"
lcdout $fe, $c0+8, "WATER"
if PORTA.2 = 1 then GOSUB waterok '<------------------- JUMP if true
if PORTA.2 = 0 then GOSUB waterbad
if PORTA.6 = 1 then GOSUB tempdown
if PORTA.7 = 1 then GOSUB tempup
PAUSE 500
GOTO MAIN

waterok:
lcdout $fe, $c0+13, " OK"
RETURN '<------ to exit the SUB and return to MAIN



Get the idea??

M

[Archangel]

Hi C.C.,
this might be an opportunity to use select case.

I noticed you are using IF THEN to direct functions for each state or your PortA.2 inputs, why not use ELSE ?

main:
If PortA.2 = 0 then
gosub waterok
ELSE
Gosub Waterbad
if PORTA.6 = 1 then ' assumes you have pulldown resistor
GOSUB tempdown
if PORTA.7 = 1 then 'assumes you have pulldown resistor
GOSUB tempup 
ENDIF
endif
endif
goto main
waterok:
lcdout $fe, $c0+13, " OK"
return

waterbad:
lcdout $FE,$c0+13, " NASTY"
return

tempdown:

lcdout $fe, $80+0, "TEMP DOWN "
RETURN

tempup:

lcdout $fe, $80+0, "TEMP UP "
RETURN
END

HTH
JS

[Bruce]

How about;

MAIN:
    lcdout $fe, $80, "PUMP off GAS off"
    lcdout $fe, $c0+8, "WATER"

    if PORTA.2 = 1 then
       lcdout $fe, $c0+13, " OK "
    else
       lcdout $fe, $c0+13, " BAD"
    endif
    
    if PORTA.6 = 1 then lcdout $fe, $80, "TEMP DOWN       "
    if PORTA.7 = 1 then lcdout $fe, $80, "TEMP UP         "
    PAUSE 500
    GOTO MAIN
    END

And maybe: if (PORTA.6=1) AND (PORTA.7=1) then lcdout $fe,$80," FAT FINGERS "..;o}