Problem with led

[savnik]

I have conect two leds to porta.2 and porta.3.
My problem is when i press 1 or 2 keys on keyboard (PC) the led isn't turn on
My pic is 16f88

    old var byte
    new var byte

    
main:
    serout porta.0, T9600, ["Enter which LED to light (0-1): ", 10, 13]
    serin porta.1, T9600, #new
    serout porta.0, T9600, ["LED Chosen: ", #new, 10, 13]
    Pause 100
    low old
    high new
    old = new
goto main

[Acetronics2]

Hi, Savnik

LOW and HIGH commands can't be applied to variables ... but Ports or aliases.

Alain

[savnik]

I have conect two leds to porta.2 and porta.3.
My problem is when i press 1 or 2 keys on keyboard (PC) the led isn't turn on
My pic is 16f88

    new var byte
    led   var PORTA.2
    led1  var PORTA.3
    
main:
    serout porta.0, T9600, ["Enter which LED to light (0-1): ", 10, 13]
    serin porta.1, T9600, #new
    serout porta.0, T9600, ["LED Chosen: ", #new, 10, 13]
    Pause 100
    if new = 1 then high led
    if new = 2 then high led1
goto main

I change the code and now works , but idon't like this.

[skimask]

I change the code and now works , but idon't like this.

What's wrong with it? Short, simple, functional...

[sayzer]

I see an analog port issue going around.

It happens to all of us, or does it?


Also, where do you turn OFF the LEDs?

Once you set them HIGH, when will they get set LOW?


------------------------------

[skimask]

I see an analog port issue going around.

It happens to all of us, or does it?


Also, where do you turn OFF the LEDs?

Once you set them HIGH, when will they get set LOW?


------------------------------

new var byte
led1 var PORTA.2
led2 var PORTA.3

adcon.1 = 7

main:
new = 0
serout porta.0, T9600, ["Enter which LED to light (1-2,0=Off): ", 10, 13]
serin porta.1, T9600, new
serout porta.0, T9600, ["LED Chosen: ", new, 10, 13]
if new = "1" then
high led1 : low led2
enfif
if new = "2" then
high led2 : low led1
endif
if new = "0" then
low led1 : low led2
endif

goto main

[savnik]

I see an analog port issue going around.

It happens to all of us, or does it?
------------------------------

I have at the top of code:

CMCON = 7
ANSEL = 0

Also, where do you turn OFF the LEDs?

Once you set them HIGH, when will they get set LOW?


------------------------------

This is my problem

[sayzer]

Savnik,

Take a look at the post before yours.

skimask has it for you.


------------------------