DCD command - need some advice

[mister_e]

how about this one?

;************* set up pattern data **********
    
Patt1 DATA 16,1,2,4,8,16,32,64,128,128,64,32,16,8,4,2,1 
Patt2 DATA 8,129,66,36,24,24,36,66,129 
Patt3 DATA 16,1,3,2,6,4,12,8,24,16,48,32,96,64,192,128,0 
Patt4 DATA 16,1,128,2,64,4,32,8,16,8,32,4,64,2,128,1,0 
Patt5 DATA 12,24,60,126,255,231,195,129,0,129,195,231,255 
Patt6 DATA 13,1,2,4,8,17,34,68,136,16,32,64,128,0 
Patt7 DATA 8,128,64,32,16,8,4,2,1

;************* set up PIC ********************

ADCON1=$0F
CMCON = 7                        ' Digital inputs
CCP1CON = 0                      ' PWM off
TRISA=%11100111                  'set PORTA as all input apart from A3 & A4
TRISB=%00000000                  'set PORTB as all output
PORTB=0

;************* set up variables ***************

Patt    var byte [8]
asm
    MOVE?CB _Patt1,_Patt+1 ; Patt[1]
    MOVE?CB _Patt2,_Patt+2 ; Patt[2]
    MOVE?CB _Patt3,_Patt+3 ; Patt[3]
    MOVE?CB _Patt4,_Patt+4 ; Patt[4]
    MOVE?CB _Patt5,_Patt+5 ; Patt[5]
    MOVE?CB _Patt6,_Patt+6 ; Patt[6]
    MOVE?CB _Patt7,_Patt+7 ; Patt[7]
endasm

ByteA   var byte
D var byte
scale var byte                      ;used in the POT command
Scale = 254  
steps var byte
swcount var byte
swcount=7                           ; set to 3 for testing only
D=250
;**************** main program ********************
main:
    for swcount=1 to 7
        read patt[swcount],steps
        for bytea=1 to steps
           READ PATT[SWCOUNT]+BYTEA,PORTB
           PAUSE D
           NEXT
        next
    GOTO MAIN

noticed that i skiped the POT command but use a fixed 250mSec delay. It's working here. if you want to use DCD, you'll need to modify the DATA lines and use bit# instead of Decimal value. No big deal

It shouldn't be different from one to another. DATA remain DATA. PORTB remain PORTB. Well i can't explain why if it doesn't create the expected results with the above suggestion

Too bad, MPASM text substitution doesn't seems to work with Bytes variable in the #V(Variable) area.. it would be too convenient...

EDIT: Note that MOVE?CB _Patt1,_Patt+1 can be replace by Patt[1]=Patt1 etc...

The whole MOVE?CB block (or Patt[x]=Pattx) could also be replace using MPASM text substitution like this

asm
    local a=1
    while a<7
        MOVE?CB _Patt#v(a),_Patt+a
a+=1
        endw
endasm

[malc-c]

how about this one?

Yup - works a treat here too... the LEDs are cycling through all the pattern sequences quite nicely

Now sorry to be a pain in the a$$, but you lost me right at the point you went asm
MOVE?CB _Patt1,_Patt+1 ; Patt[1]


I assume that this could be done in PBP without dropping out to assembly code, hence the Note that MOVE?CB _Patt1,_Patt+1 can be replace by Patt[1]=Patt1 etc... statement ????

Sorry if this seems dumb questions, but now that 'm moving away from the simple basic commands and the fact I was (and still am) a bit rusty with my coding, all help to expand the learning curve with PBP is greatly apreciated

[mister_e]

So, i think i lost you pretty much more with the second asm code using the text substitution?

Sorry sometimes i'm getting sick with those MOVE?CB, PAUSE?C, macro and whatever else... It's the Darrel's fault!

Yup indeed the whole MOVE?CB ... block could be replace by using...

Patt[1]=Patt1
Patt[2]=Patt2
Patt[3]=Patt3
Patt[4]=Patt4
Patt[5]=Patt5
Patt[6]=Patt6
Patt[7]=Patt7

Now compile those line and open the .asm file... you'll discover somewhere those lines...

; C:\PBP_PROG\A.BAS        	00040	Patt[1]=Patt1
	MOVE?CB	_Patt1, _Patt + 00001h

; C:\PBP_PROG\A.BAS        	00041	Patt[2]=Patt2
	MOVE?CB	_Patt2, _Patt + 00002h

; C:\PBP_PROG\A.BAS        	00042	Patt[3]=Patt3
	MOVE?CB	_Patt3, _Patt + 00003h

; C:\PBP_PROG\A.BAS        	00043	Patt[4]=Patt4
	MOVE?CB	_Patt4, _Patt + 00004h

; C:\PBP_PROG\A.BAS        	00044	Patt[5]=Patt5
	MOVE?CB	_Patt5, _Patt + 00005h

; C:\PBP_PROG\A.BAS        	00045	Patt[6]=Patt6
	MOVE?CB	_Patt6, _Patt + 00006h

; C:\PBP_PROG\A.BAS        	00046	Patt[7]=Patt7
	MOVE?CB	_Patt7, _Patt + 00007h

Interesting eh?

NOW, why i use the MOVE?CB first? Well didn't thought Patt[1]=Patt1 would worked... later i decide to try and... Woohhooo

So this is why i edited my previous post. I'm still learning as well. I guess we never stop anyways!

MOVE?CB: Is a PBP macro wich copy a Constant value to a Byte variable. Not much.

Glad to hear it's working as expected
Have fun!

[malc-c]

Thanks for the explanation...

[SteveB]

<img src="http://www.picbasic.co.uk/forum/attachment.php?attachmentid=1273&stc=1&d=116630151 9">
Bravo Steve!

Nice explaination.


SteveB

[mister_e]

Gracias, Merci, thank you,falemnderit, σασ ευχαριστώ, danke, grazie, ขอบคุณ, teşekkür ederim ,...,..

[malc-c]

You guys crack me up !

Ok' I'm working my way through this version using the 16F873A, but I've hit a small issue which is so basic I can't see why it responds the way it does (it worked with the 16F628a).

I have set port A to all inputs and added

SW1 var PORTA.2                         ;pattern selection switch

I have a 10k pull up resistor between pin 4 (RA2) and +5v with a tactile switch between pin 4 and GND.

I've added the code

if SW1=0 then swcount=swcount+1         ;check to see if up button pressed, if so add 1 to swcount
pause 60                                ;debounce delay
If swcount>7 then swcount=1             ;error trap for exceeding max patterns

So in therory if the switch (sw1) is low then swcount is increased by 1, until it is > than 7 and if so then its swcount is reset to 1. This way the pattern is selected by pressing the switch.

However in practice, the PIC simply ignores any input on RA2, but more confusingly, it runs each pattern once in sequence, ie it cycles through the patterns as if the button is being pressed, so swcount must in some way be changing as the remainder of the code works if the above lines are remed out and swcount is manual set to 1, 2, 3 etc, which results in just the selected pattern running.

Pot PORTA.1,scale,D                     ;used to read value from 10k pot and set the speed
read patt[swcount],steps                ;read the first value of the selected patter and place it in the variable steps
        for C = 1 to steps              ;for / next loop
           READ PATT[SWCOUNT]+ C,PORTB  ;reads the step value for selected pattern and send it to PORTB 
           PAUSE D                      ;delay for speed
        NEXT
GOTO MAIN

Its probably me having a blonde moment (no offence to any fair haired madiens out there ) - but can anyone shed some light why this isn't working.