Problems with mpasm

[b1arrk5]

I'll take a guess, how old is your version of MPASM? I think the new one is 5.14. As Steve mentioned, it's easier to get help if you post the code, and version numbers, as chips, programs, etc. change pretty often, and they update the include files, etc. fairly often.
HTH,

Jerry

[iw2fvo]

Hi,
first of all i have to apologize in advance because of my English ( I am Italian ) and because i am very new to this forum and to PIC world.

I wrote a basic program for the 877 target pic and I found stange behaviors of the system.
The source is written using microcode studio.
The program uses a FP routins called DDS in the source file. If the DDS routine is included in a subroutine then i do not have any compiling error BUT the pic does not work at all.
If I call out the routine every time it is needed then the system works . If the routine is called out more than three times then no error during compiling is observed BUT the Pic does not work.
I did several tentative using the MPASM and using the MPLAB : the error lists are attached .
I did rem_out the first two lines of the program using Mpasm. Using Mpasm I did rem_out "c" and "z" register bit declaration to avoid additional errors !
I am not really sure if the use of FP routines have some limitation...
Thanks a lot for any direction on the matter.
Ambrogio
IW2FVO

I'll take a guess, how old is your version of MPASM? I think the new one is 5.14. As Steve mentioned, it's easier to get help if you post the code, and version numbers, as chips, programs, etc. change pretty often, and they update the include files, etc. fairly often.
HTH,

Jerry

[skimask]

How much programming of PICs have you done in your new world?
Have you made a blinky LED yet or anything of the sort? If not, I'd highly suggest building a few simpler 'things' and build up.
The WARNINGs are just that, warnings, and not errors, and generally don't matter much, in this case, they don't mean much.
The last line in the 2nd file...BUILD SUCCEEDED...that's what matters.

[iw2fvo]

the Mpasm is the one included in the MPLAB 8.10
Tnks
Ambrogio
IW2FVO

I'll take a guess, how old is your version of MPASM? I think the new one is 5.14. As Steve mentioned, it's easier to get help if you post the code, and version numbers, as chips, programs, etc. change pretty often, and they update the include files, etc. fairly often.
HTH,

Jerry

[Bruce]

Have you disabled case sensitivity in MPASM? This can cause a lot of odd problems.

[iw2fvo]

hi Bruce,
Yes, I disabled the case sensitive, ( no tick ).
Thanks
ambrogio iw2fvo

Have you disabled case sensitivity in MPASM? This can cause a lot of odd problems.

[iw2fvo]

I still have a problem compiling with MPASM a picbasic program that includes Melabs floating point.
The program is attached to the message.
The error list that appears to me using Mpasm and the pic18f452 is here:

Executing: "c:\pbp_250\PBPW.EXE" -ampasmwin -oq -z -p18F452 "452_9912_3.pbp"
PICBASIC PRO(TM) Compiler 2.50, (c) 1998, 2007 microEngineering Labs, Inc.
All Rights Reserved.
Error[113] D:\PRJ_ACTIVE\452_9912_3.ASM 805 : Symbol not previously defined (flo3232)
Error[113] D:\PRJ_ACTIVE\452_9912_3.ASM 1222 : Symbol not previously defined (flo3232)
Error[113] D:\PRJ_ACTIVE\452_9912_3.ASM 1411 : Symbol not previously defined (flo3232)
Error[113] D:\PRJ_ACTIVE\452_9912_3.ASM 1895 : Symbol not previously defined (flo3232)
Error[113] D:\PRJ_ACTIVE\452_9912_3.ASM 2369 : Symbol not previously defined (fsr)
Error[113] D:\PRJ_ACTIVE\452_9912_3.ASM 2376 : Symbol not previously defined (indf)
Error[113] D:\PRJ_ACTIVE\452_9912_3.ASM 2377 : Symbol not previously defined (indf)
Error[113] D:\PRJ_ACTIVE\452_9912_3.ASM 2379 : Symbol not previously defined (indf)
Error[113] D:\PRJ_ACTIVE\452_9912_3.ASM 2381 : Symbol not previously defined (indf)
Error[113] D:\PRJ_ACTIVE\452_9912_3.ASM 2382 : Symbol not previously defined (fsr)
Warning[207] D:\PRJ_ACTIVE\452_9912_3.ASM 2386 : Found label after column 1. (rlf)
Error[122] D:\PRJ_ACTIVE\452_9912_3.ASM 2386 : Illegal opcode (_binary)
Warning[207] D:\PRJ_ACTIVE\452_9912_3.ASM 2387 : Found label after column 1. (rlf)
Error[122] D:\PRJ_ACTIVE\452_9912_3.ASM 2387 : Illegal opcode (_binary)
Warning[207] D:\PRJ_ACTIVE\452_9912_3.ASM 2388 : Found label after column 1. (rlf)
Error[122] D:\PRJ_ACTIVE\452_9912_3.ASM 2388 : Illegal opcode (_binary)
Warning[207] D:\PRJ_ACTIVE\452_9912_3.ASM 2389 : Found label after column 1. (rlf)
Error[122] D:\PRJ_ACTIVE\452_9912_3.ASM 2389 : Illegal opcode (_binary)
Warning[207] D:\PRJ_ACTIVE\452_9912_3.ASM 2390 : Found label after column 1. (rlf)
Error[122] D:\PRJ_ACTIVE\452_9912_3.ASM 2390 : Illegal opcode (_bcd)
Warning[207] D:\PRJ_ACTIVE\452_9912_3.ASM 2391 : Found label after column 1. (rlf)
Error[122] D:\PRJ_ACTIVE\452_9912_3.ASM 2391 : Illegal opcode (_bcd)
Warning[207] D:\PRJ_ACTIVE\452_9912_3.ASM 2392 : Found label after column 1. (rlf)
Error[122] D:\PRJ_ACTIVE\452_9912_3.ASM 2392 : Illegal opcode (_bcd)
Warning[207] D:\PRJ_ACTIVE\452_9912_3.ASM 2393 : Found label after column 1. (rlf)
Error[122] D:\PRJ_ACTIVE\452_9912_3.ASM 2393 : Illegal opcode (_bcd)
Warning[207] D:\PRJ_ACTIVE\452_9912_3.ASM 2394 : Found label after column 1. (rlf)
Error[122] D:\PRJ_ACTIVE\452_9912_3.ASM 2394 : Illegal opcode (_bcd)
Loaded D:\prj_active\452_9912_3.COD.
BUILD SUCCEEDED: Wed Jul 02 18:07:22 2008

Any suggestion ?
Thank you
regards,
Ambrogio
IW2FVO

Have you disabled case sensitivity in MPASM? This can cause a lot of odd problems.

[skimask]

I still have a problem compiling with MPASM a picbasic program that includes Melabs floating point.
The program is attached to the message.
The error list that appears to me using Mpasm and the pic18f452 is here:

Why do you need to use the floating point routines in the first place?
I don't really see a need for them in that code...

[Bruce]

It looks like your bin_bcd routine was writen for a 16F part. RLF is not an 18F instruction.

The 18F equivalent would be RLCF.

Also FSR and INDF are different on the 18F parts. You have FSR0, FSR1, FSR2, and INDF0,
INDF1, INDF2. See the 18F data sheet for details. You'll need to make a few changes to
compile this for an 18F.

Your example compiles fine with these changes to bin_bcd;

bin_bcd:        
asm             
 ;******************************************************************
; Convert 32-bit binary number at <bin> into a bcd number
; at <bcd>. Uses Mike Keitz's procedure for handling bcd 
; adjust; Modified Microchip AN526 for 32-bits.

b2bcd	movlw	32		; 32-bits
	movwf	_ii		; make cycle counter
	clrf	_bcd		; clear result area
	clrf	_bcd+1
	clrf	_bcd+2
	clrf	_bcd+3
	clrf	_bcd+4
	
b2bcd2	movlw	_bcd		; make pointer
	movwf	fsr0
	movlw	5
	movwf	_cnt

; Mike's routine:

b2bcd3	movlw	0x33		
	addwf	indf0,f		; add to both nybbles
	btfsc	indf0,3		; test if low result > 7
	andlw	0xf0		; low result >7 so take the 3 out
	btfsc	indf0,7		; test if high result > 7
	andlw	0x0f		; high result > 7 so ok
	subwf	indf0,f		; any results <= 7, subtract back
	incf	fsr0,f		; point to next
	decfsz	_cnt
	goto	b2bcd3
	
	rlcf	_binary+3,f		; get another bit
	rlcf	_binary+2,f
	rlcf	_binary+1,f
	rlcf	_binary+0,f
	rlcf	_bcd+4,f		; put it into bcd
	rlcf	_bcd+3,f
	rlcf	_bcd+2,f
	rlcf	_bcd+1,f
	rlcf	_bcd+0,f
	decfsz	_ii,f		; all done?
	goto	b2bcd2		; no, loop
		; yes	
endasm
return

I can't say if it works or not, but it does compile without a single error.

[iw2fvo]

Bruce,
your reply is a very good solution for the compiling errors.
As you point out the program compiles with NO errors.
That is great ! Thanks a lot for the help.

I will run the program on the 542 to see if it will work.
Bye
Ambrogio
IW2FVO
North Italy

It looks like your bin_bcd routine was writen for a 16F part. RLF is not an 18F instruction.

The 18F equivalent would be RLCF.

Also FSR and INDF are different on the 18F parts. You have FSR0, FSR1, FSR2, and INDF0,
INDF1, INDF2. See the 18F data sheet for details. You'll need to make a few changes to
compile this for an 18F.

Your example compiles fine with these changes to bin_bcd;

bin_bcd:        
asm             
 ;******************************************************************
; Convert 32-bit binary number at <bin> into a bcd number
; at <bcd>. Uses Mike Keitz's procedure for handling bcd 
; adjust; Modified Microchip AN526 for 32-bits.

b2bcd	movlw	32		; 32-bits
	movwf	_ii		; make cycle counter
	clrf	_bcd		; clear result area
	clrf	_bcd+1
	clrf	_bcd+2
	clrf	_bcd+3
	clrf	_bcd+4
	
b2bcd2	movlw	_bcd		; make pointer
	movwf	fsr0
	movlw	5
	movwf	_cnt

; Mike's routine:

b2bcd3	movlw	0x33		
	addwf	indf0,f		; add to both nybbles
	btfsc	indf0,3		; test if low result > 7
	andlw	0xf0		; low result >7 so take the 3 out
	btfsc	indf0,7		; test if high result > 7
	andlw	0x0f		; high result > 7 so ok
	subwf	indf0,f		; any results <= 7, subtract back
	incf	fsr0,f		; point to next
	decfsz	_cnt
	goto	b2bcd3
	
	rlcf	_binary+3,f		; get another bit
	rlcf	_binary+2,f
	rlcf	_binary+1,f
	rlcf	_binary+0,f
	rlcf	_bcd+4,f		; put it into bcd
	rlcf	_bcd+3,f
	rlcf	_bcd+2,f
	rlcf	_bcd+1,f
	rlcf	_bcd+0,f
	decfsz	_ii,f		; all done?
	goto	b2bcd2		; no, loop
		; yes	
endasm
return

I can't say if it works or not, but it does compile without a single error.

[iw2fvo]

Hi,
I am happy because I understand that you have read the basic program but I am really interested in knowing how can my program be wtitten without using the F P.
Could you please inform how it can be done ? It will be a very interesting solution.
Thanks for the help
regards,
Ambrogio
iw2fvo
Italy

Why do you need to use the floating point routines in the first place?
I don't really see a need for them in that code...

[skimask]

Hi,
I am happy because I understand that you have read the basic program but I am really interested in knowing how can my program be wtitten without using the F P.
Could you please inform how it can be done ? It will be a very interesting solution.

Nothing interesting about it.
Where is the program using numbers between 0 and 1? Or fractions for that matter?
All I see is numbers that go above 16 bit. If that's the case, and you are using an 18Fxxx part, then you can use LONG variables to handle 32 bit (large) numbers.