Interrupt Problem

[J_Brittian]

I think Ingvar's right. I'm not sure you're leaving any room for an interrupt to occur. Try it like this:

loop:
For y = 0 to 100
pause 1
Next y
Goto loop

[Kamikaze47]

well the interrupt is def occuring or the led wouldnt come on at all. an interrupt handled in assembly doesnt need "room" for it to occur. It will jump right to the interrupt handler no matter what the processor is doing at the time... but ill try what you suggest

*edit* just tried it and no change... when i press the button attached to the interrupt pin the led goes high for 2 secs and then the whole thing crashes and restarts

[J_Brittian]

I'm sorry. I just realized that. Do you reset you're interrupt flag somewhere? Should there be an Intf = 0 just before the retfie?

[tom]

first off all you forgot to clear int flag
in your int handler so your PIC will always
be in interrupt routine. you have to put line

bcf INTCON,1

before retfie instruction.
also I suggest you to turn on and off
LED in int routine with little delay
in between (although it is not adviceable to use
delays in interrupt)
to see the interrupt more clearly. you can
use this int handler for example:

asm
int_handler
    ; Save Resisters ;
    movwf   wsave               ; Save W Register into wsave
    swapf   STATUS,W            ; Save STATUS Register into ssave
    clrf    STATUS                  
    movwf   ssave              
    movf    PCLATH,W            ; Save PCLATH Register into psave
    movwf   psave
    movf    FSR,W               ; Save FSR Register into fsave
    movwf   fsave
endasm
    high LED
    pause 100
    low LED
    ; Interrupt Code ;
    ;bsf     _LED                ; Turn on LED
asm
    ; Restore Resisters ;
    movf    fsave,W             ; Restore FSR Resister
    movwf   FSR                 
    movf    psave,W             ; Restore PCLATH Resister
    movwf   PCLATH
    swapf   ssave,W             ; Restore STATUS Resister
    movwf   STATUS
    swapf   wsave,F             ; Restore W Resister
    swapf   wsave,W
    bcf INTCON,1
    retfie
endasm

[Kamikaze47]

I would have thought the interrupt flag would be reset automatically when it returns from the interrupt handler. I havnt seen interrupt routines that reset the flag, but I guess its worth a try.

[Kamikaze47]

Ahh yep, that did the trick. Thanks Ingvar.

Just a single line at the end of the interrupt handler: bcf _INTF

[Kamikaze47]

Tom: is there any down side of including picbasic commands in your interrupt handler. I thought to work as a proper interrupt it had to be in asm?

[tom]

You always have to clear interrupt flag in software
before retfie instruction. If you don't clear the flag,
instruction retfie will set GIE bit and PIC will be
interrupted again. Logical AND function beetwen
int flag bit and int enabled bit (AND-ed with GIE)
will result in interrupt.

[tom]

kamikaze 47:
well, of course it's better to use asm in my opinion
but this also work. I try it.

[Darrel Taylor]

Kamikaze47 is right.

There is definately a problem using PAUSE in an ASM interrupt.

Pause uses 2 internal PBP variables. (R0 and R1). So if, another PBP statement that uses either R0 or R1 gets interrupted, the interrupt routine will change those values and the main program will get confused.

It's possible to have a pause in the interrupt, IF you save both of the system vars first, then restore them when the int is finished.

In that case, toms example would look like this...

R0save VAR WORD
R1save VAR WORD

asm
int_handler
    ; Save Resisters ;
    IF (CODE_SIZE <= 2)
        movwf   wsave               ; Save W Register into wsave
        swapf   STATUS,W            ; Save STATUS Register into ssave
        clrf    STATUS                  
        movwf   ssave              
        movf    PCLATH,W            ; Save PCLATH Register into psave
        movwf   psave
        movf    FSR,W               ; Save FSR Register into fsave
        movwf   fsave
    endif
endasm
    R0save = R0
    R1save = R1
    high LED
    pause 100
    low LED
    R1 = R1save
    R0 = R0save
asm
    ; Restore Resisters ;
    movf    fsave,W             ; Restore FSR Resister
    movwf   FSR                 
    movf    psave,W             ; Restore PCLATH Resister
    movwf   PCLATH
    swapf   ssave,W             ; Restore STATUS Resister
    movwf   STATUS
    swapf   wsave,F             ; Restore W Resister
    swapf   wsave,W
    bcf INTCON,1
    retfie
endasm

But then, like tom says ... "it is not advisable to use delays in interrupt"
<br>