Does my code look ok or im I missing something out. No joy on identifing the model but I tried it on a door controler an it works fine. The door controler is compatable with clock and data readers only acording to the spec sheet. Would I need pullup resistors on the clock and data lines.

Thanks for the help Sphere