|
Re: Losing data when extracting bytes from words - 16F18855
got nothing to do with that , its intent was to give the other end time to setup for reception.Doesn't this WHILE do the same thing? Make sure everything is gone before doing anything else?
your handshake method is extremely awkward and incapable of recovery from a missed transmission.
turns out it was not needed and should be removed
Last edited by richard; - 15th March 2025 at 03:47.
Warning I'm not a teacher
|
Re: Losing data when extracting bytes from words - 16F18855
more robust demand/response handshaking
rxCode:;pic18f26k22 #CONFIG CONFIG FOSC = INTIO67 ; Internal oscillator block CONFIG PLLCFG = OFF ; Oscillator used directly CONFIG PRICLKEN = OFF ; Primary clock can be disabled by software CONFIG FCMEN = OFF ; Fail-Safe Clock Monitor disabled CONFIG IESO = OFF ; Oscillator Switchover mode disabled CONFIG PWRTEN = OFF ; Power up timer disabled CONFIG BOREN = SBORDIS ; Brown-out Reset enabled in hardware only (SBOREN is disabled) CONFIG BORV = 190 ; VBOR set to 1.90 V nominal CONFIG WDTEN = ON ; WDT is always enabled. SWDTEN bit has no effect CONFIG WDTPS = 32768 ; 1:32768 CONFIG CCP2MX = PORTC1 ; CCP2 input/output is multiplexed with RC1 CONFIG PBADEN = OFF ; PORTB<5:0> pins are configured as digital I/O on Reset CONFIG CCP3MX = PORTB5 ; P3A/CCP3 input/output is multiplexed with RB5 CONFIG HFOFST = ON ; HFINTOSC output and ready status are not delayed by the oscillator stable status CONFIG T3CMX = PORTC0 ; T3CKI is on RC0 CONFIG P2BMX = PORTB5 ; P2B is on RB5 CONFIG MCLRE = INTMCLR ; MCLR pin enabled, RE3 input pin disabled CONFIG STVREN = ON ; Stack full/underflow will cause Reset CONFIG LVP = OFF ; Single-Supply ICSP disabled CONFIG XINST = OFF ; Instruction set extension and Indexed Addressing mode disabled (Legacy mode) CONFIG DEBUG = OFF ; Disabled CONFIG CP0 = OFF ; Block 0 (000800-001FFFh) not code-protected CONFIG CP1 = OFF ; Block 1 (002000-003FFFh) not code-protected CONFIG CP2 = OFF ; Block 2 (004000-005FFFh) not code-protected CONFIG CP3 = OFF ; Block 3 (006000-007FFFh) not code-protected CONFIG CPB = OFF ; Boot block (000000-0007FFh) not code-protected CONFIG CPD = OFF ; Data EEPROM not code-protected CONFIG WRT0 = OFF ; Block 0 (000800-001FFFh) not write-protected CONFIG WRT1 = OFF ; Block 1 (002000-003FFFh) not write-protected CONFIG WRT2 = OFF ; Block 2 (004000-005FFFh) not write-protected CONFIG WRT3 = OFF ; Block 3 (006000-007FFFh) not write-protected CONFIG WRTC = OFF ; Configuration registers (300000-3000FFh) not write-protected CONFIG WRTB = OFF ; Boot Block (000000-0007FFh) not write-protected CONFIG WRTD = OFF ; Data EEPROM not write-protected CONFIG EBTR0 = OFF ; Block 0 (000800-001FFFh) not protected from table reads executed in other blocks CONFIG EBTR1 = OFF ; Block 1 (002000-003FFFh) not protected from table reads executed in other blocks CONFIG EBTR2 = OFF ; Block 2 (004000-005FFFh) not protected from table reads executed in other blocks CONFIG EBTR3 = OFF ; Block 3 (006000-007FFFh) not protected from table reads executed in other blocks CONFIG EBTRB = OFF ; Boot Block (000000-0007FFh) not protected from table reads executed in other blocks #ENDCONFIG define OSC 64 ANSELC = 0 OSCCON = $70 OSCTUNE.6 = 1 RCSTA = $90 ' Enable serial port & continuous receive TXSTA = $24 ' Enable transmit, BRGH = 1 SPBRG = 21 ' 57600 Baud @ 64MHz, -0.08% SPBRGH = 1 BAUDCON.3 = 1 ' Enable 16 bit baudrate generator asm ADCcode = _MsgData Num0 = _MsgData + 1 Num1 = _MsgData + 3 Num2 = _MsgData + 5 Num3 = _MsgData + 7 Num4 = _MsgData + 9 Num5 = _MsgData + 11 Num6 = _MsgData + 13 Num7 = _MsgData + 15 Num8 = _MsgData + 17 Num9 = _MsgData + 19 endasm MsgOK var byte[2] MsgLoop VAR WORD MsgData var byte[21] ADCcode var BYTE ext Num0 VAR WORD ext Num1 VAR WORD ext Num2 VAR WORD ext Num3 VAR WORD ext Num4 VAR WORD ext Num5 VAR WORD ext Num6 VAR WORD ext Num7 VAR WORD ext Num8 VAR WORD ext Num9 VAR WORD ext Mainloop: ADCcode = 2 for MsgLoop = 0 to 390 step 10 ' loop by multiples of 10 tol: hserin 50,tol,[ wait("<OK>") ] gosub TransmitData next MsgLoop goto mainloop end TransmitData: Num0 = MsgLoop Num1 = MsgLoop + 1 Num2 = MsgLoop + 2 Num3 = MsgLoop + 3 Num4 = MsgLoop + 4 Num5 = MsgLoop + 5 Num6 = MsgLoop + 6 Num7 = MsgLoop + 7 Num8 = MsgLoop + 8 Num9 = MsgLoop + 9 hserout [ "[",21,str MsgData\21] RETURN
Code:;pic18f26k22 #CONFIG CONFIG FOSC = INTIO67 ; Internal oscillator block CONFIG PLLCFG = ON ; Oscillator used directly CONFIG PRICLKEN = OFF ; Primary clock can be disabled by software CONFIG FCMEN = OFF ; Fail-Safe Clock Monitor disabled CONFIG IESO = OFF ; Oscillator Switchover mode disabled CONFIG PWRTEN = OFF ; Power up timer disabled CONFIG BOREN = SBORDIS ; Brown-out Reset enabled in hardware only (SBOREN is disabled) CONFIG BORV = 190 ; VBOR set to 1.90 V nominal CONFIG WDTEN = ON ; WDT is always enabled. SWDTEN bit has no effect CONFIG WDTPS = 32768 ; 1:32768 CONFIG CCP2MX = PORTC1 ; CCP2 input/output is multiplexed with RC1 CONFIG PBADEN = OFF ; PORTB<5:0> pins are configured as digital I/O on Reset CONFIG CCP3MX = PORTB5 ; P3A/CCP3 input/output is multiplexed with RB5 CONFIG HFOFST = ON ; HFINTOSC output and ready status are not delayed by the oscillator stable status CONFIG T3CMX = PORTC0 ; T3CKI is on RC0 CONFIG P2BMX = PORTB5 ; P2B is on RB5 CONFIG MCLRE = INTMCLR ; MCLR pin enabled, RE3 input pin disabled CONFIG STVREN = ON ; Stack full/underflow will cause Reset CONFIG LVP = OFF ; Single-Supply ICSP disabled CONFIG XINST = OFF ; Instruction set extension and Indexed Addressing mode disabled (Legacy mode) CONFIG DEBUG = OFF ; Disabled CONFIG CP0 = OFF ; Block 0 (000800-001FFFh) not code-protected CONFIG CP1 = OFF ; Block 1 (002000-003FFFh) not code-protected CONFIG CP2 = OFF ; Block 2 (004000-005FFFh) not code-protected CONFIG CP3 = OFF ; Block 3 (006000-007FFFh) not code-protected CONFIG CPB = OFF ; Boot block (000000-0007FFh) not code-protected CONFIG CPD = OFF ; Data EEPROM not code-protected CONFIG WRT0 = OFF ; Block 0 (000800-001FFFh) not write-protected CONFIG WRT1 = OFF ; Block 1 (002000-003FFFh) not write-protected CONFIG WRT2 = OFF ; Block 2 (004000-005FFFh) not write-protected CONFIG WRT3 = OFF ; Block 3 (006000-007FFFh) not write-protected CONFIG WRTC = OFF ; Configuration registers (300000-3000FFh) not write-protected CONFIG WRTB = OFF ; Boot Block (000000-0007FFh) not write-protected CONFIG WRTD = OFF ; Data EEPROM not write-protected CONFIG EBTR0 = OFF ; Block 0 (000800-001FFFh) not protected from table reads executed in other blocks CONFIG EBTR1 = OFF ; Block 1 (002000-003FFFh) not protected from table reads executed in other blocks CONFIG EBTR2 = OFF ; Block 2 (004000-005FFFh) not protected from table reads executed in other blocks CONFIG EBTR3 = OFF ; Block 3 (006000-007FFFh) not protected from table reads executed in other blocks CONFIG EBTRB = OFF ; Boot Block (000000-0007FFh) not protected from table reads executed in other blocks #ENDCONFIG define OSC 64 ANSELC = 0 include "strtok.pbpmod" OSCCON = $70 OSCTUNE.6 = 1 RCSTA = $90 ' Enable serial port & continuous receive TXSTA = $24 ' Enable transmit, BRGH = 1 SPBRG = 21 ' 57600 Baud @ 64MHz, -0.08% SPBRGH = 1 BAUDCON.3 = 1 ' Enable 16 bit baudrate generator asm ADCcode = _MsgData Num0 = _MsgData + 1 Num1 = _MsgData + 3 Num2 = _MsgData + 5 Num3 = _MsgData + 7 Num4 = _MsgData + 9 Num5 = _MsgData + 11 Num6 = _MsgData + 13 Num7 = _MsgData + 15 Num8 = _MsgData + 17 Num9 = _MsgData + 19 endasm incoming var byte[21] MsgData var byte[21] ADCcode var BYTE ext Num0 VAR WORD ext Num1 VAR WORD ext Num2 VAR WORD ext Num3 VAR WORD ext Num4 VAR WORD ext Num5 VAR WORD ext Num6 VAR WORD ext Num7 VAR WORD ext Num8 VAR WORD ext Num9 VAR WORD ext Pause 1000 ' Let PIC stabilize and start after RX PIC Mainloop: hserout [ "<OK>"] hserin 50,mainloop,[ wait("[",21), STR incoming \21] if incoming[0] = 2 then strcpy MsgData , incoming ,21 hserout [ "[", dec4 Num0, _ " ", dec4 Num1, " ", dec4 Num2, " ", dec4 Num3, _ " ", dec4 Num4, " ", dec4 Num5, " ", dec4 Num6, _ " ", dec4 Num7, " ", dec4 Num8, " ", dec4 Num9, "]",13,10] hserout [ 10] ' this is just to maintain alignment on Serial Communicator endif GOTO Mainloop end
Warning I'm not a teacher
|
Re: Losing data when extracting bytes from words - 16F18855
1. Why does this compile OK? I mean the asm/endasm block is before defining the variables. Shouldn't the compiler complain about that?
2. the sub TransmitData transfers data to variables Num0-Num9 from MsgLoop but then sends the str MsgData. Is this correct?
Ioannis
|
Re: Losing data when extracting bytes from words - 16F18855
why would it complain? the asm block generates no code at all , it only creates labels for the assembler1. Why does this compile OK? I mean the asm/endasm block is before defining the variables. Shouldn't the compiler complain about that?
yes, MsgData is a 21 byte structure that holds the vars Num0-Num9 + ADCcode2. the sub TransmitData transfers data to variables Num0-Num9 from MsgLoop but then sends the str MsgData. Is this correct?
Warning I'm not a teacher
|
Re: Losing data when extracting bytes from words - 16F18855
Originally Posted by richard
Once I TX data, I waited till TX complete:
(16F18855 p.146)The TXIF flag does not indicate transmit completion (use TRMT for this purpose instead).
Then I sit in a loop waiting for RX interrupt:
(16F18855 p.553)To ensure that no actual data is lost, check the RCIDL bit to verify that a receive operation is not in process...
Code:;--- Interrupts ---------------------------------------------------------------- RXInterrupt: hserin [ STR MsgData\3 ] while BAUDCON1.6 = 0 ' Check RCIDL bit wend RXoccurred = 1 ' Set flag @ INT_RETURN ;--- Subroutines --------------------------------------------------------------- SendData: hserout [ MsgData[0], MsgData[1], MsgData[2] ] while TX1STA.1 = 0 ' Check TRMT bit wend while RXoccurred = 0 ' Check for interrupt wend RXoccurred = 0 ' Set flag ADCchange = 1 RETURN
I turned the pot pretty fast and this is the fastest interval I got from start of 1st TX to start of 2nd TX:
I'm still studying your TX/RX module. At least now I have a control that I can compare with.
Last edited by Demon; - 16th March 2025 at 00:43.
My Creality Ender 3 S1 Plus is a giant paperweight that can't even be used as a boat anchor, cause I'd be fined for polluting our waterways with electronic devices.
Not as dumb as yesterday, but stupider than tomorrow!
|
Re: Losing data when extracting bytes from words - 16F18855
To make sure I wasn't losing data, I returned the data I received. I also used the 45mm slide pot for another speed test; zipping that sucker as fast as I could: 1.234 mSec from start to start of TX.
These are the signals, in case the text from Saleae probe is not clear enough (they get a little fudgy or some reason):
Primary PIC:
- TX
Secondary PIC:
- RX-INT
- LCDout ADC values
- TX confirmation
- LCDout "X" indicator (this is for testing only, to see if other pots "jitter")
Note that data is not lost even if bottom LCDout overlaps into next message.
My Creality Ender 3 S1 Plus is a giant paperweight that can't even be used as a boat anchor, cause I'd be fined for polluting our waterways with electronic devices.
Not as dumb as yesterday, but stupider than tomorrow!
|
Re: Losing data when extracting bytes from words - 16F18855
I figure I'd push the envelope a bit faster with that 45mm slide pot; 1.228 mSec from start to start of TX.
I also took out that 2nd LCDout with the "x" indicator, it was just for testing anyways.
This time I went faster than the previous ADC increment changes of 3, I managed to go to 7 and still no data lost:
My Creality Ender 3 S1 Plus is a giant paperweight that can't even be used as a boat anchor, cause I'd be fined for polluting our waterways with electronic devices.
Not as dumb as yesterday, but stupider than tomorrow!
Members who have read this thread : 14You do not have permission to view the list of names.
Posting Permissions
Reply With Quote
Bookmarks