How to measure how long I pressed a button ?

[richard]

in order to measure a buttons hold time you need to either note time button was pressed then the time button was released
the duration is release time - when pressed time, or when button is pressed start a timer and then stop it when button released
you are not doing either of these things
you never start timer1, you never note when the button is released

[fratello]

Thanks for reply !
T1CON = %00000110 ; this command does not start timer1?
Or do I have to use the command: T1CON.0 = 1 'start Timer1 ?
How to see if button is released ? IF DataW.... it's not enough ?

[richard]

No it just sets it to use external clock

[richard]

you have set timer1 to overflow every 16.38 mS , you never count the overflows
also adding 65535 to a word var seems very odd do you actually intend to subtract 1


i can't see how any of this can work, i makes no sense to me

while durata < longpress
    	if T1CON.0 == 1 then
        	overflow_counter_low = overflow_counter_low + 1
        	if overflow_counter_low == 65535 then
            		overflow_counter_low = 0
            		durata = durata + 65535
        	endif
    	endif    
    	durata = durata + (TMR1H * 256 + TMR1L)
wend

[fratello]

you have set timer1 to overflow every 16.38 mS , you never count the overflows
also adding 65535 to a word var seems very odd do you actually intend to subtract 1
....
i can't see how any of this can work, i makes no sense to me

Gemini code !

[HenrikOlsson]

What happens if more than one button is pressed at the same time?

Anyway, this might serve as starting point. It compiles but it is not tested.

Long_Press CON 5000
Short_Press con 100

cnt VAR WORD
b_level VAR BYTE
DataW VAR WORD

Main:
    GOSUB ReadButton
    
    IF b_level > 0 THEN
    	cnt = 0
        WHILE b_level > 0  
    	   cnt = cnt + 10  
    	   if cnt > Long_Press THEN EXIT
    	   PAUSE 10
    	   GOSUB ReadButton
    	WEND
    	
    	SEROUT GPIO.2, 2, ["You pressed button ", #b_level, " for ", #cnt, "ms", 13, 10]
    endif
Goto Main	


ReadButton:
    ADCON0.1 = 1
	While ADCON0.1 = 1 : Wend 
	
    DataW.HighByte = ADRESH 
    DataW.LowByte = ADRESL

	b_level = 0
	if DataW < 805 then
        	if DataW > 50  AND DataW < 160 THEN b_level = 1
        	if DataW > 180 AND DataW < 270 THEN b_level = 2
        	if DataW > 290 AND DataW < 380 THEN b_level = 3
        	if DataW > 400 AND DataW < 500 THEN b_level = 4
        	if DataW > 540 AND DataW < 650 THEN b_level = 5
        	if DataW > 690 AND DataW < 800 THEN b_level = 6
	ENDIF
RETURN

[fratello]

Thanks !
But nothing on serial ...(in Proteus 8)

[Ioannis]

forget Proteus.

Also I think Henrik forgot to add the label Exit: just before the Serout command.

Ioannis

[richard]

How to see if button is released ? IF DataW.... it's not enough ?

i possibly could be enough but you never reevaluate it until the whole timing mess has long completed