Help with realtime clock and timer

[Melanie]

> I tried to do every thing by the book.

Time to consign that book to land-fill.

Darrel has already said that your schematic is screwed. The best code in the world isn't going to make it run and it's pointless even looking at it. Go away, create a circuit that is likely to actually work, then at least when you write some code you've half a chance it might do something sensible. While we're at it, you're using a CAD program, so let's layout the drawing that's easy to read.

[Darrel Taylor]

YES, I did say that. Many times infact!   I just don't remember typing it.

Did you bug my computer again Melanie?

Actually, I found so many problems with the schematic, I didn't want to say anything, for fear I'd have to come up with ways to fix it.

I am however, fairly impressed with the program. Every time I thought I found something wrong, a quick look at the datasheet proved that whomever wrote it, spent a lot of time looking at the datasheets too.

You definately gotta work on that circuit though.
<br>

[Darrel Taylor]

Oh yeah, I forgot,

The only real problem I found in the program was that the Comparator Interrupt section is resetting the Enable bit instead of the Interrupt Flag.

After the first time through, the comparator won't cause an interrupt anymore. But, it will keep the External Interrupt section from ever executing.<br>

[geselaw]

Thank you Darrel for your suggestion ,here is the new code.

COMP_INT BSF _Charger ;porta.0 will be on.it will be used for charging the battery
MOVF CMCON,F ;read and clear comparator mismatch condition
bcf PIR1, CMIF ;clear comparator interrupt flag
movf _hour,w ;*** read hour to w register
addlw 008h ;*** add 8 to hour which is in the w register
movwf _Bat_hour ;move the result to the Bat_hour var
goto Unsave

The schematic was never meant to be published ,it was only for reference.I know this is lame excuse so I am working on it and I will post it ASAP.In the mean time you said you don't like the circuit,good. Which part do you think need improvement/change. I don't ask people to do my leg work for me .All I am asking is for suggestion.

I am a Network Engineer by profession never had formal education in electronics. All the small things I know ,I learned it from internet. I really need to make this project work .Please help.

[geselaw]

I have tried to make the schematic readable. The schematic that I posted last time was unreadable even to me ,and I found so many silly mistakes and tried to correct them. If you find any more mistakes ,it is just because I don't know better for the time being ,but I am hear to learn.

I have also made minor correction under the "Start" Label

Start:

'Initial Battery charging (if not intiated yet by low battery from assembely interupt)
if (charger = 1) and (bat_hour != 0) then 'This will stop the programe from adding another charging-
goto System_Start '-hour if the battery is already being charged caused by low battery-
endif '-in the begining of the programe
bat_hour = hour + 8 '*** charge the battery no matter what at start
charger = 1 'Charge pin on

[Melanie]

Look, lets start with basics...

1. Go download the Datasheet for your PIC...
2. Go see where the Crystal IS SUPPOSED TO BE CONNECTED

Come back and tell us which pins it has got to be nailed to, and then tell us why you insist on having it on RB6/7 in your schematic. This I've got to hear...

And whilst were teaching schematics, you never, ever, ever draw lines or connections through a component! Go around it.

[Bruce]

Looks like he's using the internal osc with external crystal for Timer1, but there are still a TON of errors in that schematic.