DEFINE RESET_ORG and DEC modifier issue

[richard]

the obvious thing is that the bootloader is not right.
is the pbp re-entry point from bootloader correct ?
is the bootloader really capable of 128k operation ? eg are all the two word commands goto ,lfsr ... correctly configured
have the pbp shared lib routines been corrupted or inappropriately shifted ?
have you compared the lst files of working and no working code ?

or are you trying to make a bootloader ?
if so then have you enough room between 1ec00h and the end of memory to fit the
shared pbp routines library ? long version may be a fair bit bigger

[Marcick]

uhhmmm.... where do you see I'm using a bootloader?
Well, I was really working on a bootloader but when I started to see this issue I wrote this simple code (not involving bootloader) to make this post.
I'm talking here also http://support.melabs.com/forum/picb...modifier-issue

[richard]

. where do you see I'm using a bootloader?

my bad, i was thinking back to bootloader issues i had with a 87j11 and 128k relocations going bad
with similar results.

a quick look at a lst file of your code shows a fair bit of this going on for the "DEC" section of your code
the upper portion of the hserout2j label address is ignored.

                          M     endif01EE4E 6A1C               M         clrf    (R2)   + 2
01EE50 6A1D               M         clrf    (R2)   + 3
                      00270         HSEROUT2DEC?    
                          M         MOVE?CW HSEROUT2J, R8     /// hserout2j  is a  more than a word long when >64k
                          M     ifdef USE_LINKER
                          M         CHK?RP  R8
                          M         movlw   low (HSEROUT2J)
                          M         movwf   R8
                          M         movlw   high (HSEROUT2J)
                          M         movwf   (R8)   + 1

hserout2j being a label

HSEROUT2                          0001EC06HSEROUT2?C                        
HSEROUT2COUNT?C                   
HSEROUT2DEC?                      
HSEROUT2J                         0001EC04
HSEROUT2J_USED                    00000001
HSEROUT2NUM?W                     
HSEROUT2_USED                     00000001
HSER_BAUD                         00000960
HSER_BITS                         00000008

[Marcick]

hi,
It's a very long time I don't eat assembly...
Are you saying it's a PBP bug?

[richard]

i'm not really sure what exactly the code is doing but the highlighted sections are doing something with the label but ignoring the upper byte of its address. below 64k its not an issue i would not say its bug , more like its not designed to be relocated beyond the 64k boundary.
anyways its the only thing i see in the code thats likely to be an issue.

01EE52 0E04               M         movlw   low (low (HSEROUT2J))MPASM 5.61                          MCKD.ASM   1-30-2021  23:44:34         PAGE 32




LOC  OBJECT CODE     LINE SOURCE TEXT
  VALUE


01EE54 6E0A               M         movwf   R8
                          M       endif
                          M     endif
                          M         MOVE?CB high (HSEROUT2J), (R8) + 1
                          M         CHK?RP  (R8) + 1
                          M     if ((((R8) + 1) & 8000h) != PREV_ALT)
                          M       if (((R8) + 1) & 8000h)
                          M         bsf     WDTCON, ADSHR
                          M       else
                          M         bcf     WDTCON, ADSHR
                          M       endif
                          M PREV_ALT = ((R8) + 1) & 8000h
                          M     endif
                          M     if (((((R8) + 1) & 0fffh) > BANKA_END) & ((((R8) + 1) & 0fffh) < (0f01h + BANKA_END)))
                          M       if ((((R8) + 1) & 0f00h) != (PREV_BANK << 8))
                          M         movlb   high ((R8) + 1)
                          M PREV_BANK = high ((R8) + 1)
                          M       endif
                          M     endif
                          M     if (low (high (HSEROUT2J)) == 0)
                          M         clrf    (R8) + 1
                          M     else
                          M       if (low (high (HSEROUT2J)) == 255)
                          M         setf    (R8) + 1
                          M       else
01EE56 0EEC               M         movlw   low (high (HSEROUT2J))
01EE58 6E0B               M         movwf   (R8) + 1

[richard]

maybe crashing here

01EDA8 6EE9 08880 JUMPMAN movwf FSR0L
01EDAA 6AFB 08881 clrf PCLATU
01EDAC 500B 08882 movf R8 + 1, W
01EDAE 6EFA 08883 movwf PCLATH
01EDB0 500A 08884 movf R8, W
01EDB2 6EF9 08885 movwf PCL

[Marcick]

Looks like it is definitely a bug (I have bought one week ago the 3.1 update to be sure).
I'm writing in the bug report section of Melabs to see what they say. Here.
Thanks