Rotary encoder with DT interrupts


Results 1 to 34 of 34

Threaded View

  1. #12
    Join Date
    May 2013
    Location
    australia
    Posts
    2,672


    Did you find this post helpful? Yes | No

    Default Re: Rotary encoder with DT interrupts

    i breadboarded a 1788 and using the code as posted in reply 8 with one slight change in that serout2 is set to T9600 it
    1. fails to count properly as predicted
    2. shows no signs of resets occurring

    interestingly using an encoder with no filtering it gives the appearance of functioning
    curious , not sure what to think .

    Code:
    '****************************************************************************************************'*  Name    : RE test WJS.pbp                                                                       *                                      
    '*  Author  : WJ Sherwood                                                                           *
    '*  Notice  : Copyright (c) 2021                                                                      *
    '*          : All Rights Reserved                                                                   *
    '*  Date    : 07/02/21                                                                              *
    '*  Device  : 16F1788                                                                               *
    '*  Version : 1    (PBP 3.0.10.4)                                                                   *
    '*  Notes   : Spurious "I'm Alive" serial traffic following RE action (still) and corrupt chars if  *
    '*          : Pause at line 75 (following MaxLimit = 60) removed - what am I missing?               *
    '*          :                                                                                                             *
    '*          : REa portb.6, REb portb.5, REsw portb.4 all pulled up, active low.                     *
    '*          :                                                                                                             *
    '****************************************************************************************************
    .
    '=========================================================================================================
    '        CONFIGURE DEVICE 
    '=========================================================================================================
    #CONFIG  ; 16F1788
            __config _CONFIG1, _FOSC_INTOSC & _WDTE_ON & _PWRTE_ON &  _MCLRE_ON & _CP_OFF & _CPD_OFF & _BOREN_OFF & _CLKOUTEN_OFF & _IESO_OFF & _FCMEN_OFF
            __config _CONFIG2, _WRT_OFF & _VCAPEN_OFF & _PLLEN_OFF & _LVP_OFF & _BORV_HI & _LPBOR_OFF
    #ENDCONFIG
    
    
    ' -----[ Initialization ]--------------------------------------------------------------------------------- 
        TRISA = 000000       ' Set I/O.
        TRISB = 111111       ' Set I/O.
        TRISC = 000000       ' Set I/O.
    
    
    define  OSC  4
            OSCCON = 101010   ' 4Mhz (F1788).
    'define  OSC  32
    '        OSCCON = 110000   ; 32 MHz, 
    
    
        ANSELA = 0           ; all digital          
        ANSELB = 0           ; all digital 
    
    
    ' Define LCD connections       
        DEFINE  LCD_DREG        PORTA  ' LCD Data Port
        DEFINE  LCD_DBIT        0           ' Starting Data Bit
        DEFINE  LCD_RSREG       PORTA  ' Register Select Port
        DEFINE  LCD_RSBIT       4           ' Register Select Bit
        DEFINE  LCD_EREG        PORTA  ' Enable Port
        DEFINE  LCD_EBIT        7           ' Enable Bit
        DEFINE  LCD_BITS            4           ' Data Bus Size
        DEFINE  LCD_LINES       2           ' Number of Lines on LCD
    
    
    '=========================================================================================================
    '        PIN ASSIGNMENTS, SYSTEM CONSTANTS, TEMPORARY VARIABLES
    '=========================================================================================================
    ' Rotary Encoder stuff
    Old_Bits    VAR BYTE bank0  ' Encoder port bits before change.
    New_Bits    VAR BYTE bank0  ' Encoder port bits after change.
    RotEnc1_val VAR word bank0  ' Connected to PORTB<6:5>.
    MaxLimit    var word bank0  ' Used for setting upper limit for encoder counts.
    RotEncDir   VAR BIT  bank0  ' Direction of rotation bit.
    ButtPush    var bit  bank0  ' Flag shows button was pushed, allows quick exit from Int handler.
    REdec       var bit  bank0  ' Flag shows RE decrement, allows quick exit from Int handler.
    REinc       var bit  bank0  ' Flag shows RE increment, allows quick exit from Int handler.
                        
        Include "MODEDEFS.BAS"      ' Include Shiftin/out modes.
        INCLUDE "DT_INTS-14.bas"    ' Needs to be assembled with MPASM **********
        INCLUDE "ReEnterPBP.bas"    ; Include if using PBP interrupts    
    
    
        OPTION_REG.6 = 0        ' INTEDG set to interrupt on falling edge.
    '    OPTION_REG.6 = 1        ' INTEDG set to interrupt on rising edge.
    
    
    '   IOCBP = 110000        ; REa portb.6, REb portb.5  pos edge trigger
       IOCBN = 110000        ; REa portb.6, REb portb.5, REsw portb.4  neg edge trigger - falling edge only.
       IOCBF = 0                ; Reset the PortB flag.
       INTCON = 001000       ; GIE, PEIE, IOCIE.
       
      MaxLimit = 60           ' Menu value limit.  
    '  pause 100               ' Let everything settle...
    
    
    latc.6 = 1                  ' Prevent garbled serial - newer PICs, inverted.        
    serout2 PORTC.6,84,[13,10,"I'm Alive",13,10,10]
    
    
    ASM
    INT_LIST  macro    ; IntSource,         Label,  Type, ResetFlag?
            INT_Handler    IOC_INT,  _Rot_Encoder,   PBP,  yes  ; Newer PICs.
        endm
        INT_CREATE              ; Creates the interrupt processor .
    ENDASM
    
    
    @    INT_ENABLE   IOC_INT   ; Newer PICs.
    Old_Bits = PORTB & (100000)  ; RE uses B.6,B.5 - REa and REb.
    
    
    
    
    Main:   
      if PortB.4 = 0 then            ' Check if Encoder pushbutton was pushed.
      while PortB.4 = 0:wend         ' Wait for release.
      pause 50                       ' Debounce delay.
      serout2 PORTC.6,84,[13,10,"ButtPush = 1, RE ",dec5 RotEnc1_val]
      endif
      
      if REdec or REinc = 1 then 
      serout2 PORTC.6,84,[13,10,"RE_val ",dec5 RotEnc1_val]
      REdec = 0:REinc = 0           ' Reset the flags.  
      endif
      
    goto main                       ' endless loop waiting for INT. 
    
    
    
    
       
    '---[IOC - interrupt handler]---------------------------------------------------
    ' Don't forget 4 counts per detent (Quadrature).
    Rot_Encoder:
         New_Bits = PORTB & (100000)         ' Set port bits for Encoder's chosen A and B channels.
         IF (New_Bits & 100000) = (Old_Bits & 100000) then DoneRotEnc ' No change.
         RotEncDir = New_Bits.6 ^ Old_Bits.5    ' Bit XOR compare to get direction of rotation.
         if RotEncDir = 0 then                  ' CCW so decrement.
            if PORTB.6 and PORTB.5 = 1 then     ' Only when RE both pins high (convert quad counts to singles).
            RotEnc1_val = RotEnc1_val - 1       ' Decrement the count.
              if RotEnc1_val => 65530 then RotEnc1_val = 0  ' Limit the max.
              if RotEnc1_val <= 4 then RotEnc1_val = 0      ' Limit the min.
            REdec = 1                                       ' Flag the event.
            endif
         ELSE                                   ' RotEncDir = 1, CW so increment.
            if PORTB.6 and PORTB.5 = 1 then     ' Only when RE both pins high (convert quad counts to singles).
              RotEnc1_val = RotEnc1_val + 1     ' Increment the count.
              if RotEnc1_val >= MaxLimit then RotEnc1_val = MaxLimit ' Limit the count.
            REinc = 1                           ' Flag the event.
            endif                               
         ENDIF
    
    
    DoneRotEnc:
        Old_Bits = New_Bits
        INTCON.0 = 0        ; Clean up and exit - clear IOCIF.
        IOCBF = 0           ; Reset the flag.
    @ INT_RETURN
    
    
    end
    Last edited by richard; - 10th February 2021 at 00:22.
    Warning I'm not a teacher

Similar Threads

  1. Rotary encoder subroutine
    By Fanias in forum mel PIC BASIC Pro
    Replies: 1
    Last Post: - 10th October 2018, 13:13
  2. Using an incremental rotary encoder?
    By keithv in forum mel PIC BASIC Pro
    Replies: 5
    Last Post: - 12th January 2016, 22:23
  3. Instant Interrupts for rotary encoder
    By fnovau in forum mel PIC BASIC Pro
    Replies: 7
    Last Post: - 15th August 2014, 08:24
  4. New approach to Rotary Encoder
    By Ioannis in forum Code Examples
    Replies: 90
    Last Post: - 11th July 2013, 21:05

Members who have read this thread : 3

You do not have permission to view the list of names.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts