Rotary Encoder on 20x4 LCD with pushbutton digit select and other features

[csantex]

Thanks Richard for commenting and posting code. Your code takes up much less space. I made the hardware changes to my setup and included the necessary configuration registers for programming. I don't understand why you "and" PortA with decimal 48. Please explain. See example below.
As per your code, it does not function properly on my setup even though I made the LCD changes. What am I not seeing or missing? See video of power up and what happens when I turn the knob of the encoder. See what happens when I select a digit and then turn the knob. I can only get it to respond to the knob turn when I do it fast, not when it is done slowly.


Encoder type used: I had used 3 10nF caps on the 3 lines to ground for debounce in my original setup. Failed to mention that, but I used a new one with no caps and still didn't work.



Video:


Thanks, csantex

if you do it more algorithmically the size can be reduced dramatically ,it becomes scalable digit wise

more functions can easily be added and the mcu can be employed to perform a real task like pid control of a power supply and not just become a display controller


ps note my lcd defines suite my setup and are different

'*************************************************  ***************
'*  Name    : LCD_TEST.BAS                                      *
'*  Author  : RICHARD                                           *
'           
'*  Date    : 4/8/2017                                          *
'*  Version : 1.0                                               *
'*  Notes   :                                      *
'*          :       16f887                                   *
'*************************************************  ***************
 

    #CONFIG
 __CONFIG    _CONFIG1, _LVP_OFF & _FCMEN_OFF & _IESO_OFF & _BOR_ON & _CPD_OFF & _CP_OFF & _MCLRE_ON & _PWRTE_ON & _WDT_OFF & _INTOSCIO 
 __CONFIG    _CONFIG2, _WRT_OFF & _BOR40V
 #ENDCONFIG
 
    DEFINE OSC 8

    
'LCD defines begin here   
    DEFINE LCD_BITS 4  'defines the number of data interface lines (4 or 8) 
    DEFINE LCD_DREG PORTB 'defines the port where data lines are connected to
    DEFINE LCD_DBIT 0  'defines the position of data lines for 4-bit interface (0 or 4)
    DEFINE LCD_RSREG PORTB 'defines the port where RS line is connected to
    DEFINE LCD_RSBIT 4  'defines the pin where RS line is connected to 
    DEFINE LCD_EREG PORTB  'defines the port where E line is connected to 
    DEFINE LCD_EBIT 5  'defines the pin where E line is connected 
    DEFINE LCD_COMMANDUS 1500  'defines the delay after LCDOUT statement 
    DEFINE LCD_DATAUS 50   'delay in micro seconds
'END of LCD DEFINES

;TRIS REGISTERS FROM MY CODE WITH COMMENTS****************************

    OSCCON  = %01110000     ; Set PIC16F88 to 4MHz = %01100000, or
                            ; 8MHz = %01110000
'    TRISA   = %11111111     ; Port A set to inputs    'COMMENTED OUT SINCE IT BOOTS UP AS INPUTS ANYWAYS.   <<<<<<<<<<<<<<<
'    TRISB   = %11101100     ; Port B set to OUTPUTS   'COMMENTED OUT SINCE LCD DEFINES SET DATA DIRECTIONS.   <<<<<<<<<<<<<<<<
    TRISC   = %01111111     ; Port C set to inputs
'    TRISD   = %00000000     ; Port D set to Ouputs     'NOT USED IN YOUR CODE    <<<<<<<<<<<<<<<<<<<<<<<
    ANSEL   = %00000000     ; Set all analog pins to digital
    ANSELH  = %00000000

;*************************************************  *********************

; YOUR CODE==============================================                            
Pause 500       ' LCD initialize time
lcdout $FE,1 
  
num_digits      con 5        ; range 4 t0 9 tested ok     note sum_total will not work for more than 5 digits 
sw_threshhold   con 10
lp_threshhold   con 100      ;long press
sw_inhibit_time con 100
msd_limit       con 5        ;limit value for msd  note sum_total will not work for more than 5 digits and limit > 5  ;optional
digit       var byte[num_digits-1]
d_index     var byte
overflow    var bit
underflow   var bit
noroll_flg  var bit    ;optional
d_inx       var byte
sw_cnt      var byte 
sw_flag     var bit
re          var byte 
last_re     var byte 
ev          var byte 
tmp1        var byte
tmp2        var byte  ;optional
tmp3        var byte  ;optional   
sw_inhibit  var byte
total       var word 
enc_sw var PORTC.4
enc_a  var portc.5
enc_b  var portc.6
clear
d_index = num_digits
re = porta&48     '<<<<<<<<<<<<<<<  Why do you "&" dec48 with Port A?
last_re = re    
gosub dup

The rest of the code is as you wrote it....