LCD BARgraphs

[Christopher4187]

Darrel,

I got it, thanks for the help. The problem was that both files were saved as .pbp files. All of my programs are saved the same way and I have never had an issue.....until now. So, that part works but now I have another problem.

I have a 2X16 LCD set up on a development board. I have one simple LCD program and that works fine. I put the same LCD commands into the bargraph program and it doesn't work. I can see weird charecters displayed on the first line but nothing on the second line. Within those charecters I do see numbers every now and again and when I turn the pot, I can see the value change so I know it's functional but just not displaying correctly. Here is the program:

; Initialize your hardware and LCD first.
define osc 20

' Set LCD Data port
DEFINE LCD_DREG PORTB
' Set starting Data bit (0 or 4) if 4-bit bus
DEFINE LCD_DBIT 4
' Set LCD Register Select port
DEFINE LCD_RSREG PORTB
' Set LCD Register Select bit
DEFINE LCD_RSBIT 2
' Set LCD Enable port
DEFINE LCD_EREG PORTB
' Set LCD Enable bit
DEFINE LCD_EBIT 3
' Set LCD bus size (4 or 8 bits)
DEFINE LCD_BITS 4
' Set number of lines on LCD
DEFINE LCD_LINES 2
' Set command delay time in us
DEFINE LCD_COMMANDUS 2000
' Set data delay time in us
DEFINE LCD_DATAUS 100
'This setup will tell PBP a 2-line LCD is connected in 4-bit mode with the data bus on the
'top 4 bits of PORTB, Register Select on PORTB.1, and Enable on PORTB.0.





DEFINE ADC_BITS 8 ' Number of bits in ADCIN result
ADCON1.7 = 1 ' Right Justify AD result

INCLUDE "LCDbar_INC.bas" ' Include the BARgraph routines

Value VAR WORD ' Must be a WORD even though AD is 8bit

LCDOUT $FE, 1 ' Clear Screen
pause 500

Loop1:
ADCIN 2, Value
LCDOUT $FE,2,"Value = ",DEC Value," "

; syntax- BARgraph Value, Row, Col, Width, Range, Style
@ BARgraph _Value, 2, 0, 16, 255, lines



GOTO Loop1


Like I said, these LCD commands were copied word for word from another known program. Any ideas?

Thanks again for the help.

Chris

[Darrel Taylor]

The DEFINEs don't match the comments. Might be the prob.

Defines show RS on PORTB.2, and Enable on PORTB.3

But, your comment says...
<pre>'This setup will tell PBP a 2-line LCD is connected in 4-bit mode with the data bus on the<br>'top 4 bits of PORTB, Register Select on PORTB.1, and Enable on PORTB.0.</pre>

[Christopher4187]

Now, I am really confused. How come this program worked but the other one didn't?

DEFINE OSC 20
INCLUDE "LCDbar_INC.bas" ' Include the BARgraph routines
' Set LCD Data port
DEFINE LCD_DREG PORTB
' Set starting Data bit (0 or 4) if 4-bit bus
DEFINE LCD_DBIT 4
' Set LCD Register Select port
DEFINE LCD_RSREG PORTB
' Set LCD Register Select bit
DEFINE LCD_RSBIT 2
' Set LCD Enable port
DEFINE LCD_EREG PORTB
' Set LCD Enable bit
DEFINE LCD_EBIT 3
' Set LCD bus size (4 or 8 bits)
DEFINE LCD_BITS 4
' Set number of lines on LCD
DEFINE LCD_LINES 2
' Set command delay time in us
DEFINE LCD_COMMANDUS 2000
' Set data delay time in us
DEFINE LCD_DATAUS 100.

DEFINE ADC_BITS 8 ' Number of bits in ADCIN result
ADCON1.7 = 1 ' Right Justify AD result

Value VAR WORD ' Must be a WORD even though AD is 8bit
pause 1000
LCDOUT $FE, 1, " "
loop1:

adcin 2,value

LCDOUT $FE,2,"Value = ",DEC Value," "

; syntax- BARgraph Value, Row, Col, Width, Range, Style
@ BARgraph _Value, 2, 0, 16, 255, lines

goto loop1


The only thing I adjusted was the pause commands and I moved the include file to the top of the program. I'm happy that it's working but I'd like to know for future reference incase it happens again. Thanks for the help Darrel.

[Darrel Taylor]

You probably have an LCD that is very slow starting up and requires more than 500 ms before receiving it's first command.

Being that you also have DEFINE LCD_DATAUS 100, it's seems reasonable.
Most LCD's are happy with LCD_DATAUS 50, and only 250 ms power-up delay. But there are some that aren't.

Try leaving the INCLUDE where it was, with the longer pauses. Just to see what happens.
<br>

[Christopher4187]

Well, after searching for a while, I found the problem and it's strange. At the tops of both programs, look at the OSC commands. One is in CAPS and the other isn't. I guess it has to be in CAPS or PBP won't know what it is. I wonder why it doesn't give you an error when compling?

[mister_e]

It's been already mentioned a lot of time since the Forum birth.

DEFINEs must be WRITTEN AS STATED in the manual. Case not, they will never be considered by the compiler
http://www.picbasic.co.uk/forum/show...light=spelling

[Darrel Taylor]

Ha, that's funny. Didn't even see it.

>> I wonder why it doesn't give you an error when compling? <<

You can DEFINE almost anything you want

<pre>DEFINE GreatGoogly Moogly</pre>But it only has an effect if it matches up with something the program is expecting to see.
And, when using MPASM the case has to match too.

Well, now that you've got things going, I hope the BarGraphs work out for you.
<br>

[mister_e]

Yup, i guess the MPASM AND PM IFDEF can't be bypassed like Variable and Labels.