A question for the Macro experts....

[forgie]

Hi there.
On my current project I am sending data out to my PC by using HSEROUT. I am sending data from a 12-bit ADC, so to transmit it I use:
<code>
HSEROUT [Data / 100, Data // 100]
</code>

I use this method so that I can reserve numbers above 100 for communication messages. I'm wondering if it is possible to write a macro that does the above that I could use like this:
<code>
@ TRANSMIT _Data
</code>

Any tips from the masters would be much appreciated. (I have written a few simple macros, some fully asm, some a mix of asm and PBP, but I could never work out how to use an argument with a macro and then use that argument with a PBP command inside the macro)

[Darrel Taylor]

Hi forgie,

Give this a try...

Data  VAR  WORD
Temp  VAR  WORD

@TRANSMIT  macro Variable
@   MOVE?WW  Variable, _Temp    
    HSEROUT [Temp / 100, Temp // 100]
@ endm

@ TRANSMIT _Data

[Darrel Taylor]

OR, this one will use less Code Space on each use of the TRANSMIT macro.

Data  VAR  WORD
Temp  VAR  WORD

TX_Code:
    HSEROUT [Temp / 100, Temp // 100]
RETURN

ASM
TRANSMIT  macro Variable
    MOVE?WW  Variable, _Temp    
    L?CALL   _TX_Code
  endm
ENDASM

@ TRANSMIT _Data

[mister_e]

Sorry, i'm not an expert but you could try something like

DEFINE OSC 20

DEFINE HSER_RCSTA 90h
DEFINE HSER_TXSTA 24h
DEFINE HSER_SPBRG 129 ' 9600 Bauds

wData   var word SYSTEM
ADCData var word SYSTEM
xyzData var word SYSTEM

GOTO START

ASM
TRANSMIT macro ToSend
         MOVE?WW ToSend, wData
         L?CALL UTransmit
         endm

UTransmit 
         endasm  
         HSEROUT [wdata / 100, wdata // 100]
         return

START:
      adcdata=1024
      @ TRANSMIT ADCData
      xyzdata = 500
      @ TRANSMIT xyzData
      
      PAUSE 500
      GOTO START

[mister_e]

OUPS!!! didn't see ya Darrel... Sorry.

mm it looks quite the same BTW... i still learn

[Darrel Taylor]

No Problem,

That's what happens when both our brains are grinding at the same time.

It also gives forgie some confirmation that they will probably work, since 2 people came up with almost the same thing independantly.


<br>

[mister_e]

Hehe, i agree.

Just a question. Is there any possible problem by using

wData   var word SYSTEM

against

wData   var word

[Darrel Taylor]

Well, can't say for sure, but I've never had any problems with SYSTEM.

PBP tries to protect against duplicate variable names by adding an underscore "_" in front of everything that's specified by the user.

The only thing that "SYSTEM" does, is prevent that underscore from being added.

It could cause a Naming Conflict with other things being used at the ASM level, but when that happens, the compiler will let you know.

It does make things look nicer without all those _'s. &nbsp;&nbsp;But then, those _'s can make it easier to differentiate between what's PBP and what's ASM variables, when it's debugging time.

It's hard to say which way is better.
<br>