Counting better ?

[Franko]

Hi,
I'm trying to get this to count pulses from an opto detector which goes High when the beam is broken.
Problems are,it stops the Hmtr at three pulses instead of four and if the beam isn't broken in quick succession,hmtr continues to run no matter how many times beam is broken.
My complete thanks to Melanie for the first (most so far) part of code!



DEFINE OSC 4
CMCON=7

'Declare Variables,Constants and Aliases for Ports


In1 VAR PORTA.1 'pulse input from selector 24vac/dc via optocoupler
In2 VAR PORTA.2 'pulse input from selector 24vac/dc via optocoupler
In3 VAR PORTA.3 'pulse input from selector 24vac/dc via optocoupler
Button1 VAR PORTA.4 'pulse input from selector 24vac/dc via optocoupler
Hmtr VAR PORTB.0 ' motor on/off
DATAPLS VAR PORTA.0 'sense output from passthru opto
Alert VAR PORTB.1 'Beeper
CounterA VAR BYTE 'counter
i VAR WORD 'General purpose variable


'Set initial state of ports

Hmtr=0 ' motor off
TRISA = %11111111 'Make all Porta pins Inputs
TRISB = %00000000 'Make all Portb Outputs
Pause 500 'Settling time


'Start of program

runloop:
While In1=1 'Wait here for input pulse
CounterA=0 'Rest time counter
Wend



Timerloop:

While Button1=1 'Wait for dispense button to be pressed
CounterA=CounterA+1 'Increment counter by 100ms
IF CounterA=200 Then Startloop 'If 20 sec elapses,goto start and await new activation

Pause 100 'Wait 100ms for smooth operation
Wend



runit:

High Hmtr
Pause 100
While DATAPLS=0 'wait for High from passthru opto
Wend
GoSub cnt

GoTo runloop


cnt:
PulsIn DATAPLS, 1, i
IF i > 4 Then
Low Hmtr
Else
GoTo runit
EndIF
Return


Any suggestions ?

Thank you

[yettie]

franko,

what is your configuration for you PORTA inputs? did you used a pull down resistor to ground? You have an alternative to use internal weak pull-up features (OPTION_REG=7). PIC have sensitive inputs if you used pull downs. I had some problems that I also count the noise spikes if i used external pull downs, and most likely in activating motors. the motors are inductors that could spread some unwanted signals seen by the microcontroller. proper hardware design could prevent this kind of problems.

also, use

  ...(code here in betweens)

for ease. thanks

regards,

[Franko]

Hi Yettie,
The config for porta pins are as inputs (if I did the code right).inputs A.1 and A.4 are pulled high via a 470 ohm. A.0 is pulled low via a 470.

I've never tried setting the internal pull up/dn but I will.The motor is power by a seperate 24vdc supply but with a common ground.The motor is switched by a relay which is controlled by the PIC via a NPN transistor and the coil of the relay has a diode across the coil and is correct direction.

I presume the problem is with the way I've done the code as I'm still learning (and loving it). I'll use the Quote function in the future as you said.

Thanks for your ideas.

[Franko]

Is it that no one sees anything wrong with this ? There must be something wrong with how I've done it.

I'm not asking for anyone to write it for me,rather just some advice on the correct way to make the motor low after four (or whatever) pulses.

  runit:

High Hmtr 
Pause 100
While DATAPLS=0 'wait for High from passthru opto 
Wend
GoSub cnt

GoTo runloop


cnt:
PulsIn DATAPLS, 1, i
IF i > 4 Then
Low Hmtr
Else
GoTo runit
EndIF
Return

Thanks

[CocaColaKid]

Isn't using a 470R resistor a little low for a pull-up? Using a value this low will only increase the current the IO has to produce in order to change the pins state.

[yettie]

franko,

some points:
- cokekid seems to be right. try to increase the pull-up to 10K.
-

Problems are,it stops the Hmtr at three pulses instead of four and if the beam isn't broken in quick succession,hmtr continues to run no matter how many times beam is broken.

seems to be your PULSIN DATAPLS,1,i is the culprit. if theres anyway you can monitor your WORD "i", verify it. If you have a serial port, plug it. otherwise you'll be convinced of what you will find out. then recode. it's my style of debugging.

[Franko]

Yeah, I agree with you CocaColaKid and yettie, I usually use 1K or 10K (depending).But, I breadboarded this kinda quickly and grabbed what I had the most of.

I'll switch them to 10K and see if that makes any difference.

Yetti, I'm not sure what you mean by...

" seems to be your PULSIN DATAPLS,1,i is the culprit. if theres anyway you can monitor your WORD "i", verify it."

But I'll keep trying different methods.

Thanks for the advice,
Franko