The routine I call outside of the ISR has DISABLE & ENABLE either side of it.
It was my understanding that I can call this other routine and that it will complete the routine then jump back to the ISR.

This part appears to work fine. My problem is/was that even when an interrupt hasn't occured my code inside the ISR seems to the execute?
(it seems to execute the "ELSE" statments)

Can someone confirm I have the correct flags bits set and clear for the "on change" interrupt.

Lastly having local VARS, I have compiled like this before and never had a problem. Does the compiler just pick the VAR out at compilation time regardless of where they are?
Again with the ON INTERRUPT call does this need to be anywhere specific? it seems to my no difference where I put it.

Rob