Quote Originally Posted by richard View Post
your right about the schematic I have uploaded a correct version , I have replaced the transistor with a pch mosfet (saves two resistors) but it still loses a little brightness and is no better than the transistor version
Thanks for the schematic update. Now I have to start gathering all needed components.
Why you have selected BS250, which has quite huge Rds(on), it is round 10 Ohm or more @3.3V. Why not go with a good PFET like IRLML9301TRPbF, which has ~100-200mOhm Rds(on) @3.3V. Also price is half of the BS250. With this FET you will not burn energy in transistor -> LED will be brighter.