Life after 2k w/ 16F648

[Dwayne]

How is the GoSub returning??

If I remember correctly, you are only allowed 4 levels of "GoSubs"

Thus, my first impression would be a "illegal" return from your GoSub... Something like the following:

Loop:

.....
......
......
if (something happens gosub Loop2)
goto Loop

Loop2:
......
......
......
if (something happens goto Loop) ' This is a NO NO!!!!
.....
.....
return

end


Dwayne

[Acetronics2]

No, it's much simpler ...

Start:

result = 0

For I = 1 to 16....

GOSUB Thesub
PULSIN input,1, value

IF (value < A) OR ( value > B ) then

error = 1 ( it's a red led ! )
value1 = ...
value2 = ...
GOTO Start

ENDIF

result = result + value

NEXT I

result = result >> 4 ( the mean value ....)


.
.
.

the sub:
Low out1
Pulsout out1,value1...
Low out2
Pulsout out2,value2

RETURN

That's all !!!
Alain

[Bruce]

Is there another GOTO Start that's not enclosed in the IF/THEN block?

If program execution falls-through, lands in TheSub, then hits the RETURN, it will go haywire on you.

[Acetronics2]

Hi, Bruce

No, nothing else.

Note without the FOR NEXT, it works well , but a further (in the 2 following lines ) " If result = ...THEN" test always passes, even if values should make the test fail ...

another strange thing.

Alain

[Bruce]

Remove the GOTO Start from the IF/THEN block. Place it after the NEXT.

[Dwayne]

How about a interupt??

Maybe a wrong return on a interupt (Like a Goto Start), instead of not returning on the GoSub?

I was looking at your code....

What happens if A = Value? and that IF statement fails?

It goes right through 16 times, and then continues to the Subroutine...hits REturn... and...and...<g>

DWayne

[Dwayne]

Hello Ace,
>>>
Ace
For I = 1 to 16....

GOSUB Thesub
PULSIN input,1, value

IF (value < A) OR ( value > B ) then

error = 1 ( it's a red led ! )
value1 = ...
value2 = ...
GOTO Start

ENDIF

result = result + value

NEXT I

result = result >> 4 ( the mean value ....)
<<<<

REwrite it as the following:; I think this will solve your problem...This is assuming you have a goto start BEFORE your subroutine...like after your
result = result >> 4 ( the mean value ....) statement.


i=1
while(i<17)

GOSUB Thesub
PULSIN input,1, value

IF (value < A) OR ( value > B ) then

error = 1 ( it's a red led ! )
value1 = ...
value2 = ...
i=18
else
result = result + value
endif
I=I+1
endwhile
if I>18 then goto start

result = result >> 4 ( the mean value ....)

[Acetronics2]

Hi, Bruce

The "GOTO Start" has to be here to allow a pulsout for each value of I ....

It works very well with no FOR -NEXT loop ...

But there's another problem on the line past "result = result >> 4" :

( with >> 4 neutralised ...of course !!! )

IF ABS ( result - refvalue ) > 100 THEN Start

Whatever the value of result ... test result is YES !!!

So, I begin to think the problem is located on the IF THEN tests ...

Note this works with R/C signals ... 1 to 2 ms pulses @ 40 Hz

Alain