Blinking LED will not Blink

[andybarrett1]

Hi thank you for reading this:-

I am attempting to do simple litle program using a 627 / 628 that just loops a sequence of morse Led port on and off ... to Say "Don't Panic"

ll works ok as it should but for one flash of LED 2nd or 3rd charactor (dots) in the D'

See attached code.... I have attempted to re write the code... Use another chip... I have used another compiler but the thing will not flash that one last dot for me... I just get Dash, dot... D is Dash,dot,dot !!!!

What am I doing wrong.... Have marked up the line :--

XXXX dot !!!

I have stuggled with this all afternoon....... Help !!!

BR
Andy

[mark_s]

I think you need to change your tris settings. Unless I missed something?

You Have

       TRISA=0          'All A Port outs
       TRISB=15         'All B Port Ins
       CMCON=7
        
       LED VAR PORTB.0

TRISB = 15 = %00001111 which means you have portb 0 - 3 as inputs

Try Trisb.0 = 0 or trisb = 0

[EarlyBird2]

Hi thank you for reading this:-

I am attempting to do simple litle program using a 627 / 628 that just loops a sequence of morse Led port on and off ... to Say "Don't Panic"

ll works ok as it should but for one flash of LED 2nd or 3rd charactor (dots) in the D'

See attached code.... I have attempted to re write the code... Use another chip... I have used another compiler but the thing will not flash that one last dot for me... I just get Dash, dot... D is Dash,dot,dot !!!!

What am I doing wrong.... Have marked up the line :--

XXXX dot !!!

I have stuggled with this all afternoon....... Help !!!

BR
Andy

There is nothing wrong with your code.

Except

morse:pause 3500
      High led
      pause 5000       'Led on for 5 seconds

D:    high led          'dash
      pause 1500      low led
      pause 500
      high LED         'XXXX  dot !!!
      pause 500
      low led
      pause 500
      high LED         'XXXX  dot !!!
      pause 500
      low led
      pause 1500       'gap

The LED is high for five seconds then stays high for another 1.5 seconds on the "D dash" therefore you will not see any change and this could be the flash you are missing. To check add another "low led pause 500" after the "pause 5000".

morse:pause 3500
      High led
      pause 5000       'Led on for 5 seconds
      low led
      pause 500

D:    high led          'dash
      pause 1500
      low led
      pause 500
      high LED         'XXXX  dot !!!
      pause 500
      low led
      pause 500
      high LED         'XXXX  dot !!!
      pause 500
      low led
      pause 1500       'gap

[andybarrett1]

Hi Steve...

It was the missing pause.. I worked it out just now...All working now :-)

Totally didn't see that for 4 hours yesterday.....


Thank you both Mark and Steve

Have also righted the port setup too

BR
Andy

[EarlyBird2]

I can make some suggestions for improvements if you want. Like use GOSUB. Bye the way as you use HIGH and LOW the tris is set automatically and you do not need to set it in your code. If you used LED=1 and LED=0 then you have to set tris in your code.

[andybarrett1]

Hi

Always open to suggestion…. I did think of using Gosubs…But then reasoned as my code only 0k5 not worth it..

Seems to be TRIS's seem to depend on how the sea state is in Liverpool as to when to set or not set. :-)

Thank you again…..

All help / suggestions welcome

[EarlyBird2]

The only reason is to learn as one never knows when or indeed if what one learns will be useful.

Create two subroutines one for dot and one for dash. Then in main D will be

Gosub Dash
Gosub Dot
Gosub Dot

Just as a start.

[Acetronics2]

Hi,

May be it is a bit overkill here ....

but, When Melanie deals with something ....

WOOOOHOOOO !!! ...

that's great !!!

http://www.picbasic.co.uk/forum/showthread.php?t=5510

Alain