Blinking LED will not Blink

[andybarrett1]

Hi Steve...

It was the missing pause.. I worked it out just now...All working now :-)

Totally didn't see that for 4 hours yesterday.....


Thank you both Mark and Steve

Have also righted the port setup too

BR
Andy

[EarlyBird2]

I can make some suggestions for improvements if you want. Like use GOSUB. Bye the way as you use HIGH and LOW the tris is set automatically and you do not need to set it in your code. If you used LED=1 and LED=0 then you have to set tris in your code.

[andybarrett1]

Hi

Always open to suggestion…. I did think of using Gosubs…But then reasoned as my code only 0k5 not worth it..

Seems to be TRIS's seem to depend on how the sea state is in Liverpool as to when to set or not set. :-)

Thank you again…..

All help / suggestions welcome

[EarlyBird2]

The only reason is to learn as one never knows when or indeed if what one learns will be useful.

Create two subroutines one for dot and one for dash. Then in main D will be

Gosub Dash
Gosub Dot
Gosub Dot

Just as a start.

[andybarrett1]

Hi

Thank you…. Pity I couldn't have them all on same line…:-

D: GOSUB Dash, Dot, Dot

Or could I ?

TY Again !!

[EarlyBird2]

What PBP do you have?

[andybarrett1]

2.50C

Thinking of PBP3 Silver but is it that much different…?

[mackrackit]

Hi

Thank you…. Pity I couldn't have them all on same line…:-

D: GOSUB Dash, Dot, Dot

Or could I ?

TY Again !!

From the book...

4.13. Multi-statement Lines

In order to allow more compact programs and logical grouping of related commands, PBP supports the use of the colon ( to separate statements placed on the same line. Thus, the following two examples are equivalent:

W2 = W0
W0 = W1
W1 = W2

is the same as:

W2 = W0 : W0 = W1 : W1 = W2

This does not, however, change the size of the generated code.