I used pulldowns on both encoder outputs, I never got into using pullups on PIC inputs.

Robert