LED ON and OFF with 2 Push button switches

[HenrikOlsson]

Hi,
Read thru your mainloop, line by line, and try to figure out what's happening.

You check if PB is pressed, if it is you turn on the LED - that's fine. But if PB isn't pressed you turn off the LED - that's not what you want, is it?
Do you have the two switches wired the same way? I ask because you check PB for a logic 1 while you check PB1 for a logic 0 - that's all fine if it's the way you have it wired, don't forget pullup/pulldown resistors though.
Finally, the comments are somewhat confusing because at one place you say that LOW LED turns the LED on while in another place you say that LOW LED turns the LED off - I don't know which is correct.....

/Henrik.

[tasmod]

LED CON 0 doesn't clearly map the LED to a pin.

LED VAR GPIO.0 does. Just easier to understand.


I like to put a pinout connection diagram for the chip as a reminder what is connected to what. It also helps when asking a question.
Similar to this example

;
; Target Controller -      PIC16F628A 
;                                  __________  
;                       d6--RA2 |1       18| RA1--d5
;                       d7--RA3 |2       17| RA0--d4
;              LED-------RA4 |3       16| OSC1--------
;     +5V-----------!MCLR |4       15| OSC2--------
;     Ground----------Vss |5       14| VDD---------+5 V
;              gps in-----RB0 |6       13| RB7--------- 
;                         ---RB1 |7       12| RB6--------- 
;                         ---RB2 |8       11| RB5--e
;                   pbutt--RB3 |9       10| RB4--rs
;                                     ----------