help with ad pic16f88

[lopgar71]

Hi, this is the code sample page of melabs,
Error when compiling throws me online 23

what happens?

Greetings!


' Name : ADCX18.pbp
' Compiler : PICBASIC PRO Compiler 2.6
' Assembler : PM or MPASM
' Target PIC : PIC16F88 or similar
' Hardware : LAB-X18 Experimenter Board
' Oscillator : 4MHz external crystal
' Keywords : ADCIN, LCDOUT
' Description : PICBASIC PRO program to read potentiometer on LAB-X18
' and display on LCD.
'

' Define LCD pins
Define LCD_DREG PORTA
Define LCD_DBIT 0
Define LCD_RSREG PORTB
Define LCD_RSBIT 6
Define LCD_EREG PORTB
Define LCD_EBIT 3

' Allocate variables
x Var Byte

ANSEL = %00010000 ' Make the pot input analog and rest digital
CMCON = 7 ' Set PORTA to digital
Pause 100 ' Wait for LCD to start

mainloop:
Adcin 4, x ' Read the pot
Lcdout $fe, 1, "pot=", #x ' Send value to LCD
Pause 100 ' Do it about 10 times a second
Goto mainloop ' Do it forever

End

[AvionicsMaster1]

Just FYI "CMCON = 7 ' Set PORTA to digital" actually turns off the comparators and doesn't set the ports to digital.

It also looks as if you need to set the ADCON bits 3-5 also to use ports as analog inputs.

Shouldn't this "Lcdout $fe, 1, "pot=", #x ' Send value to LCD" read "Lcdout $fe, 1, "pot=", DECx ' Send value to LCD"? I [U]think[U] the # returns ASCII and NOT decimail numbers. Which may or may not be what you are seeking.

Best wishes