Stumped with word variable

[Scampy]

Hi,
I have NO idea what's going on with this Illegal Character error. The only thing I can think of is, as I've said before, some kind of hidden character that makes the compiler hick up. I copy/pasted all of the sections in the previous post into MCS, resulting in the following:

Blue_On_Time_H var byte
Blue_on_Time_M var byte
Blue_Off_Time_H var byte
Blue_off_Time_M var byte

White_On_Time_H var byte
White_on_Time_M var byte
White_Off_Time_H var byte
White_off_Time_M var byte

data    14      'Blue ON time hours
Data    00      'Blue ON time minutes
data    15      'Blue OFF time hours
Data    00      'Blue OFF time minutes
Data    14      'Whites ON time hours
data    01      'Whites ON time minutes
data    14      'Whites OFF time hours
Data    20      'Whites OFF time minutes
    
write 10,white_on_time_h              'Whites ON time hours
write 11,white_on_time_m              'Whites ON time minutes
write 12,white_off_time_h             'Whites OFF time hours
write 13,white_off_time_m             'Whites OFF time minutes
write 14,blue_on_time_h             'Whites ON time hours
write 15,blue_on_time_m             'Whites ON time minutes
write 16,blue_off_time_h            'Whites OFF time hours
write 17,blue_off_time_m            'Whites OFF time minutes

Read 10,white_on_time_h              'Whites ON time hours
Read 11,white_on_time_m              'Whites ON time minutes
read 12,white_off_time_h             'Whites OFF time hours
read 13,white_off_time_m             'Whites OFF time minutes
read 14,blue_on_time_h             'blue ON time hours
read 15,blue_on_time_m             'blue ON time minutes
read 16,blue_off_time_h            'blue OFF time hours
read 17,blue_off_time_m            'blue OFF time minutes

END

Needles to say it compiles just fine for the 12F683, 16F877, 18F8620 and any other device I try with onboard EEPROM. I've tried this with both PBP3.0.7.4 and with PBP2.60. My MPBLAB installation is v8.88 containing MPASM v5.47.

/Henrik.

Just created a new blank page in MCS and copied and pasted the above from post #17, added the config settings etc and tried compiling

'*******************************************************************************
'  18F4520 config settings - for use with MPSAM
'*******************************************************************************

ASM 
  __CONFIG    _CONFIG1H, _OSC_HS_1H
  __CONFIG    _CONFIG2L, _PWRT_ON_2L  
  __CONFIG    _CONFIG2H, _WDT_ON_2H & _WDTPS_512_2H
  __CONFIG    _CONFIG3H, _MCLRE_ON_3H & _LPT1OSC_OFF_3H & _PBADEN_OFF_3H  
  __CONFIG    _CONFIG4L, _LVP_OFF_4L & _XINST_OFF_4L
ENDASM

'*******************************************************************************
' Defines and LCD (20 x 4) set up
'*******************************************************************************

DEFINE  OSC 20  ; 48 was old config settings 18F4520, 20mhz crystal
ADCON1 = $0F
clear

DEFINE  WRITE_USED  1

DEFINE LCD_DREG  PORTB           ' LCD Data port
DEFINE LCD_DBIT  0               ' starting Data bit (0 or 4)
DEFINE LCD_EREG  PORTB           ' LCD Enable port
DEFINE LCD_EBIT  5               '     Enable bit  (on EasyPIC 5 LCD)
DEFINE LCD_RSREG PORTB           ' LCD Register Select port
DEFINE LCD_RSBIT 4               '     Register Select bit   (on EasyPIC 5 LCD)
DEFINE LCD_BITS  4               ' LCD bus size (4 or 8 bits)
DEFINE LCD_LINES 4               ' number of lines on LCD
DEFINE LCD_COMMANDUS 2000        ' Command delay time in us 
DEFINE LCD_DATAUS 50             ' Data delay time in us 

'*******************************************************************************
'DS18B20 setting
'*******************************************************************************

DQ              VAR     PORTA.5         ' One-wire data pin
temperature     VAR     WORD            ' Temperature storage
count_remain    VAR     BYTE            ' Count remaining
count_per_c     VAR     BYTE            ' Count per degree C

'*******************************************************************************
'analog and Comparator settings
'*******************************************************************************

ADCON0 = 0                      'Set ADCON0
ADCON1 = %00001111              'Set D i/o
CMCON = 7                       'Disable Comparators

'*******************************************************************************
'Port and Register settings
'*******************************************************************************

CCP1CON = %00001100             ' 
CCP2CON = %00001100             '     
TRISA  = %11101111              '
TRISB  = %00000011 
TRISD  = %00000011              '
T0CON  = %11000111

Blue_On_Time_H var byte
Blue_on_Time_M var byte
Blue_Off_Time_H var byte
Blue_off_Time_M var byte

White_On_Time_H var byte
White_on_Time_M var byte
White_Off_Time_H var byte
White_off_Time_M var byte

data    14      'Blue ON time hours
Data    00      'Blue ON time minutes
data    15      'Blue OFF time hours
Data    00      'Blue OFF time minutes
Data    14      'Whites ON time hours
data    01      'Whites ON time minutes
data    14      'Whites OFF time hours
Data    20      'Whites OFF time minutes
    
write 10,white_on_time_h              'Whites ON time hours
write 11,white_on_time_m              'Whites ON time minutes
write 12,white_off_time_h             'Whites OFF time hours
write 13,white_off_time_m             'Whites OFF time minutes
write 14,blue_on_time_h             'Whites ON time hours
write 15,blue_on_time_m             'Whites ON time minutes
write 16,blue_off_time_h            'Whites OFF time hours
write 17,blue_off_time_m            'Whites OFF time minutes

Read 10,white_on_time_h              'Whites ON time hours
Read 11,white_on_time_m              'Whites ON time minutes
read 12,white_off_time_h             'Whites OFF time hours
read 13,white_off_time_m             'Whites OFF time minutes
read 14,blue_on_time_h             'blue ON time hours
read 15,blue_on_time_m             'blue ON time minutes
read 16,blue_off_time_h            'blue OFF time hours
read 17,blue_off_time_m            'blue OFF time minutes

Guess what - I got the error

If I comment out the write statements it compiles....

[HenrikOlsson]

Hi,
OK, so there was a lot more to the code than you showed earlier....
The actual problem seems to be the DEFINE WRITE_USED 1. Comment that out and it compiles fine.ything. Where did you find that and what's the purpose of it?

/Henrik.

[Scampy]

I can confirm that when that is commented out it too compiles fine this end. I have no Idea where that came from, I guess that's the problem when using previous code from existing projects or porting examples from forums and websites. Chances are a previous project required this for some reason, but with out opening every file I can't say where it came from.

Thanks for identifying this problem. Could you explain to me what this define means or does, and when it might be used.

I'll now go back over this thread and see if using the highbyte and lowbyte resolves my other issue of the case statement not changing when the blue on time value matches that of the current clock counter.

Malcolm

[HenrikOlsson]

Could you explain to me what this define means or does, and when it might be used.

No, not really. That's why I asked where you found it and what the reason for adding it was.

A bit of forum search turned up a couple of leads, apparently there's a bug in 2.60 which affects WRITE with WORD variables. But now, you might be on a later version of PBP where that bug is not present making the DEFINE either not needed or actually causing problems. I can't really say for sure.

The issue is described here.

I strongly suggest you update to 2.60C (or even better to PBP3), you can download the PBP2.60C patch here, scroll down to find 2.60C:
http://support.melabs.com/content/29...ersion-History

Someone else might be able to shed some more light on it.

/Henrik.

[Scampy]

Thanks Henrik, I'll have a browse and look at my options to upgrade.

Malcolm

[Scampy]

I've been re-reading the reference guide and this may explain it:

If interrupts are used in a program, they must be turned off (masked, not
DISABLEd) before executing a WRITE, and turned back on (if desired) after the
WRITE instruction is complete. An interrupt occurring during a WRITE may cause
it to fail. The following DEFINE turns interrupts off and then back on within a
WRITE command. Do not use this DEFINE if interrupts are not used in the
program.

DEFINE WRITE_INT 1

I'm not using interrupts in this code, so it's not needed - I must of added from one of the previous versions which does use interrupts

[Scampy]

Richard / Henrik

Code is now working. This is the data section

'*******************************************************************************
' Data presets
'*******************************************************************************
data @0
    data    00      'Blue fade IN duration hours
    data    30      'Blue fade IN duration minutes
    data    00      'Blues fade OUT duration hours
    data    30      'Blue fade OUT duration minutes
    data    00      'Whites fade IN duration hours
    data    30      'Whites Fade IN duration MINS
    data    00      'Whites Fade OUT duration HOURS
    data    30      'Whites Fade OUT duration MINS
    data    255     'Blue MAX Intensity %
    data    255     'Whites MAX Intensity %
    data    word 842      'Blue ON time 
    Data    word 841      'Whites ON time 
    data    word 1200      'Blue OFF time 
    Data    word 1200      'White OFF time

Then the read statement

Read 0,fadesetHR[0]    'Blue fade IN duration hours
Read 1,fadesetMN[0]    'Blue fade IN duration minutes
Read 2,fadeoutHR[0]    'Blue fade OUT duration hours
read 3,fadeoutMN[0]    'Blue fade OUT duration minutes

read 4,fadesetHR[1]    'Whites fade IN duration hours
read 5,fadesetMN[1]    'Whites fade IN duration minutes
read 6,fadeoutHR[1]    'Whites fade OUT duration hours
read 7,fadeoutMN[1]    'Whites fade OUT duration minutes

Read 8,B_max
Read 9,W_max

read 10,Blue_on_Time.lowbyte
read 11,Blue_on_Time.highbyte
read 12,white_on_Time.lowbyte
read 13,white_on_Time.highbyte

read 14,Blue_off_Time.highbyte
read 15,Blue_off_Time.lowbyte
read 16,white_off_Time.lowbyte
read 17,white_off_Time.highbyte

Return

I then have a simple test line of

lcdout $FE,$D4+11,dec Counter1
lcdout $FE,$D4+16,dec Blue_on_Time

This shows the value for Blue_on_time as 842, and the counter starting at 840 as per the data statement. When the counter reaches 842 the case statement changes as required.

Thank you both, and I apologise for putting you guys to so much trouble having tested parts of the code on various chips. Your guidance and input on my posts have been much appreciated

Malcolm

[Art]

An alternative to using high/lowbyte for a word is to shift bits within the word

Some code might be pseudo

word var word
byte var byte

DATA at EEPROM location 0 = $FF // low byte of the word you want to read
DATA at EEPROM location 1 = $FF // high byte of the word you want to read

// program run time

READ EEPROM, 0, byte
word = byte
word = word << 8
READ EEPROM, 1,byte
word = word + byte

// now the word is in memory - word = $FFFF

byte = word
WRITE EEPROM 0,byte
word = word >> 8
byte = word
WRITE EEPROM 1,byte

// the value in word was not preserved here,
// it would have been needed to be saved first

This is helpful if you want to use variables larger than PBP supports
for some operations.
It would be simple to do a binary addition on two 64 bit integers this way,
and is more familiar outside of BASIC.

[HenrikOlsson]

When applying the patch it looks like it's replacing all the .inc files so if you've edited ANY of them they will have to be re-editied.

/Henrik.