Code Review?


Results 1 to 5 of 5

Thread: Code Review?

Threaded View

  1. #1
    Join Date
    Feb 2005
    Location
    Bellevue
    Posts
    125

    Default Code Review?

    Hey folks: Not sure if the is an appropriate ask for this group, but over the past few months I've been writing a PBP app that listens to a data link for a custom GPS(non NMEA) data stream, and then displays this on an LCD - largely based on feedback from this forum and others who have been kind enought to help me along. You may even recognize some of the code - like in the interrupt and timing routine (which I am still not sure I fully understand, tho it appears to work for me)..

    Now that I am pretty well done with it, I'd like to find someone to take a look at this project and give me a code review - suggest areas where I am making novice mistakes, etc. I know there will be many - I AM a novice.

    Some of the things I notice in the operation of the code:

    1. If it does not hear a signal for a while it crashes. Not sure why it would do that.
    2. There are sections of the code that just don't work and are marked as such.
    3. It takes up more codespace than I thought it would..

    If someone has some time to help out that'd be great.

    TG
    Attached Files Attached Files

Similar Threads

  1. Reading in Manchester code
    By brid0030 in forum Code Examples
    Replies: 0
    Last Post: - 10th March 2009, 21:55
  2. How much code space do PBP statements use.
    By Darrel Taylor in forum Code Examples
    Replies: 5
    Last Post: - 13th February 2009, 21:31
  3. Loop with two motor and 2 sensors
    By MrRoboto in forum mel PIC BASIC
    Replies: 4
    Last Post: - 8th December 2008, 23:40
  4. Making Program Code Space your playground...
    By Melanie in forum Code Examples
    Replies: 15
    Last Post: - 19th July 2008, 08:26
  5. A little code review by the Group
    By manwolf in forum mel PIC BASIC Pro
    Replies: 8
    Last Post: - 30th June 2008, 01:14

Members who have read this thread : 0

You do not have permission to view the list of names.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts