Best way to use USART/HSERIN

[RossWaddell]

The 2 LEDs which are on when they shouldn't be are still perplexing me, but this code works now if anyone's interested:

' :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
' Based on Hserin with Darrel Taylor's Instant Interrupts
' :::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

'  MPASM, LabX-1 , PBP3, Using PIC 16F877A @ 4mHz, 9600 Baud,
'  USART and MAX232 to MCS Serial Communicator on PC

' ***************************************************************
' >>>>>>>>>>>>>>>>>    Slave IC ID: 1    <<<<<<<<<<<<<<<<<<<<<<<
' ***************************************************************

ThisChipID CON "1"

DEFINE OSC 4

DEFINE HSER_RCSTA 90h ' enable serial port, 
DEFINE HSER_TXSTA 24h ' enable transmit, 
DEFINE HSER_BAUD 9600 ' set baudrate to 9600                   
DEFINE HSER_CLOERR  1 ' automatic clear overrun error  

TRISD  = %00000000    ' D to outputs for the LEDs
TRISC  = %10000000    ' PORTC.7 is the RX input, PORTC.6 is the TX output
ADCON1 = %00001111    ' Set up ADCON1 register no matter what yr doing!!!                      
        
':::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
INCLUDE "DT_INTS-14.bas"     ' Base Interrupt System
INCLUDE "ReEnterPBP.bas"     ' Include if using PBP interrupts

;-- Place a copy of these variables in your Main program -------------------
;--   The compiler will tell you which lines to un-comment                --
;--   Do Not un-comment these lines                                       --
;---------------------------------------------------------------------------
;wsave   VAR BYTE    $20     SYSTEM      ' location for W if in bank0
wsave   VAR BYTE    $70     SYSTEM      ' alternate save location for W 
                                         ' if using $70, comment wsave1-3

' --- IF any of these three lines cause an error ?? ------------------------
'       Comment them out to fix the problem ----
' -- Which variables are needed, depends on the Chip you are using -- 
wsave1  VAR BYTE    $A0     SYSTEM      ' location for W if in bank1
wsave2  VAR BYTE    $120    SYSTEM      ' location for W if in bank2
wsave3  VAR BYTE    $1A0    SYSTEM      ' location for W if in bank3
' --------------------------------------------------------------------------

' ***************************************************************
' ASM Interrupt Definitions
' ***************************************************************

ASM
INT_LIST  macro    ; IntSource,           Label,  Type, ResetFlag?
        INT_Handler   TMR1_INT,      ReloadTMR1,   ASM,  no       ; MUST be first
        INT_Handler   TMR1_INT,      _T1handler,   PBP,  yes
        INT_Handler     RX_INT,        _GetBytes,  PBP,  yes
    endm
    INT_CREATE     ; Creates the interrupt processor
ENDASM

':::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
    '   Variable definition
':::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
        
led0       var     PORTD.0
led1       var     PORTD.1
led2       var     PORTD.2
led7       var     PORTD.7

ERROR_LED  VAR led7            ' rename the LED's
LATE_LED   VAR led2
HEART_LED  VAR led0

LEDonDELAY CON 4

TxEndChar   CON "~"
SyncByte    CON "S"

SerialData  VAR BYTE
CmdVal      VAR BYTE
AdjVal      VAR BYTE
ERRORtime   VAR BYTE
LATEtime    VAR BYTE
HEARTtime   VAR BYTE

state         VAR BYTE         
  SyncRcvd    VAR state.0      ' sync byte received
  ForMe       VAR state.1      ' packet is for this device
  CmdRcvd     VAR state.2      ' command has been received
  AdjRcvd     VAR state.3      ' adjustment factor has been received
  MsgRcvd     VAR state.4      ' compelte message received
  ERROR       VAR state.5      ' sync received out of order
  LATE        VAR state.6      ' command received before last one was processed
  SyncIndx    VAR state.7      ' index # of incoming byte

state      = 0                 ' Initialize default values

cmdVal     = 0
AdjVal     = 0
serialdata = 0                 ' message sample: "S3B1~"

;--- Change these to match the desired interrupt frequency -------------------
;--- See http://DarrelTaylor.com/DT_INTS-14/TimerTemplate.html for more Info.
@Freq       = 10                  ; Frequency of Interrupts in Hz
@Prescaler  = 2                   ; Timers Prescaler setting
T1CON = $10                       ; $30 = Prescaler 1:8, TMR1 OFF
; $00=1:1, $10=1:2, $20=1:4, $30=1:8 --  Must match @Prescaler value

' Enable interrupts
@ INT_ENABLE  RX_INT        ; enable USART RX_INT interrupts
@ INT_ENABLE  TMR1_INT      ; enable Timer 1 interrupts
GOSUB StartTimer            ; Start Timer 1 ('MotorRPM' will be saved on every
                            ; interrupt if dirty

Main:
    IF MsgRcvd THEN GOSUB ProcessCmdAdj    ' Process incomming data

    IF ERROR THEN                          ' if there's been an Error
        HIGH ERROR_LED                     '   Turn ON ERROR LED
        ERROR = 0                          '   reset the error flag
        ERRORtime = LEDonDELAY             '   start countdown till LED-OFF
        HSEROUT ["Error",13,10]
        HSEROUT ["SyncRcvd: ", DEC SyncRcvd,", SyncIndx: ",DEC SyncIndx, _
                ", ForMe: ", DEC ForMe,", CmdRcvd: ",DEC CmdRcvd, _
                ", AdjRcvd: ",DEC AdjRcvd,", Cmd: ",CmdVal, ", Adj: ",DEC AdjVal,13,10] 
    ENDIF
    IF LATE THEN                           ' if command took too long
        HIGH LATE_LED                      '   Turn ON LATE LED
        LATE = 0                           '   reset the LATE flag
        LATEtime = LEDonDELAY              '   start countdown till LED-OFF
        HSEROUT ["Late",13,10]
    ENDIF
GOTO Main

'*********** Process received command **************************************
ProcessCmdAdj:
    HSEROUT ["Cmd: ", CmdVal, _ ' send ThisChipID, Command, Adjustment and CR/LF
             ", Adj: ",AdjVal,_
             " [",DEC AdjVal,"]",13,10]       
    
    state      = 0               ' indicate CMD & ADJ has been processed

    cmdVal     = 0
    AdjVal     = 0
RETURN

' ***************************************************************
' [TMR1_INT - interrupt handler]
' ***************************************************************
T1handler:
    IF ERRORtime > 0 THEN                  ' if the Error LED is ON
        ERRORtime = ERRORtime - 1          '   decrement the count
        IF ERRORtime = 0 THEN              '   when it reaches 0
            LOW ERROR_LED                  '   turn the Error LED OFF
        ENDIF
    ENDIF        
    IF LATEtime > 0 THEN                   ' if the LATE LED is ON
        LATEtime = LATEtime - 1            '   decrement the count
        IF LATEtime = 0 THEN               '   when it reaches 0
            LOW LATE_LED                   '   turn the LATE LED OFF
        ENDIF
    ENDIF
    HEARTtime = HEARTtime + 1              ' Toggle heartbeat ~.5sec
    IF HEARTtime = 7 THEN
        HEARTtime = 0
        TOGGLE HEART_LED
    ENDIF       
@ INT_RETURN

' ***************************************************************
' [RX_INT - interrupt handler]
' ***************************************************************
GetBytes: 
' Darrel Taylor's code (http://www.picbasic.co.uk/forum/showthread.php?t=9932&p=65066#post65066)

    HSERIN [Serialdata]                    ' Get the serial data (guaranteed here to have at

    IF Serialdata = SyncByte THEN          
        IF SyncRcvd THEN                   ' if it's a Sync byte,
            state = 0                      '   last command was corrupted; reset 'state'
            ERROR = 1                      '   and indicate error
        ENDIF
        SyncRcvd = 1                       '   indicate Sync was rcvd
    ELSE
        IF SyncRcvd THEN
            IF !ForMe THEN                 ' if we haven't rcvd the ID
                IF Serialdata = ThisChipID THEN 'and this byte matches the ID
                    ForMe = 1              '     indicate ID rcvd
                ELSE
                    state = 0               '   and wait for next Sync
                ENDIF                      
            ELSEIF !CmdRcvd THEN
                CmdVal = SerialData
                CmdRcvd = 1
            ELSEIF !AdjRcvd THEN
                AdjVal = SerialData
                AdjRcvd = 1
            ELSEIF !MsgRcvd THEN
                If SerialData = TxEndChar THEN
                    MsgRcvd = 1
                ENDIF
            ENDIF
        ENDIF
    ENDIF

@ INT_RETURN

;---[TMR1 reload - interrupt handler]-----------------------------------------
ASM                               ; Calculate Timer Reload Constant
ReloadInst  = 8                   ; # of Intructions used to reload timer
  if ((Prescaler == 1)||(Prescaler == 2)||(Prescaler == 4)||(Prescaler == 8))
MaxCount    = 65536 + (ReloadInst / Prescaler)
TimerReload = MaxCount - (OSC*1000000/4/Prescaler/Freq)
    if ((TimerReload < 0) || (TimerReload > (65535-ReloadInst)))
        error Invalid Timer Values - check "OSC", "Freq" and "Prescaler"
    endif
  else
      error Invalid Prescaler
  endif
ENDASM

@Timer1 = TMR1L                   ; map timer registers to a word variable
Timer1       VAR WORD EXT
TimerReload  CON EXT              ; Get the External Constant
TMR1ON       VAR T1CON.0          ; Alias the Timers ON/OFF bit

;---Reload Timer1------
ASM
ReloadTMR1
    MOVE?CT  0, T1CON, TMR1ON     ;  1     stop timer
    MOVLW    LOW(TimerReload)     ;  1     Add TimerReload to the 
    ADDWF    TMR1L,F              ;  1     value in Timer1
    BTFSC    STATUS,C             ;  1/2
    INCF     TMR1H,F              ;  1
    MOVLW    HIGH(TimerReload)    ;  1
    ADDWF    TMR1H,F              ;  1
    MOVE?CT  1, T1CON, TMR1ON     ;  1     start timer
  INT_RETURN
ENDASM

;---Start/Stop controls -----
StartTimer:
    Timer1  = TimerReload         ; Load Timer
    TMR1ON = 1                    ; start timer
RETURN

StopTimer:
    TMR1ON = 0                    ; stop timer
RETURN

Any suggestions for improvement gratefully appreciated.

[Demon]

Did you set the pull-up/down jumper for the Lab X1 LEDs?

I remember I had to set "something".

Robert

[RossWaddell]

No, I didn't Robert. Do I need to do that for all of them?

[Demon]

Check the Lab X1 schematic, I'm pretty sure there was a jumper for this. It handled all the LEDs at once.

[RossWaddell]

Check the Lab X1 schematic, I'm pretty sure there was a jumper for this. It handled all the LEDs at once.

Is this what you're referring to Robert?

LED Bargraph

8 programmable LEDs connected to PORTD and 2 power LEDs are provided by
the LED bargraph. Resistor pack RP4 provides the current limit series
resistors for the LEDs. The LED bargraph may be inserted in the socket so
that the LEDs are lit when the PICmicro MCU pin is in either its high or low
state.

To make the LEDs light up when a PICmicro MCU pin is high, insert the LED
bargraph into the socket with pin 1 toward the edge of the board (this will
also line it up with pin 1 on the socket and is the default placement).
Jumper JP2 must have pins 2 and 3 connected (jumper on the top 2 JP2 pins).
When the LAB-X1 is powered up, the leftmost LED will light up to show that
power is on. To make an LED light up, set the appropriate PORTD pin to
output high.

To make the LEDs light up when a PICmicro MCU pin is low, insert the LED
bargraph into the socket with pin 1 toward the center of the board. Jumper
JP2 must have pins 1 and 2 connected (jumper on the bottom 2 JP2 pins). When
the LAB-X1 is powered up, the second to the leftmost LED will light up to
show that power is on. To make an LED light up, set the appropriate PORTD
pin to output low.

The LED bargraph shares PORTD with the LCD module data lines. If the
program is not using the LCD module, it can effectively be ignored. If the
LCD module is also being used, it may leave the LEDs in a different state
than it found them in. If the LCD is operating on a 4-bit data bus, only the
top 4 LEDs, 4 - 8, will be affected. If the LCD is using an 8-bit data bus,
all 8 LEDs will be affected. The proper LED state will need to be reset
after each LCD access.

See BLINKX.BAS for a programming example.

I'll check the jumpers tonight, but it seems like it's an all-or-nothing thing - on my board, the leftmost LED lights up when powered on and the ERROR LED from my code does blink, but a few of the other ones are always on.

[Demon]

Yup, JP2, that's the one.

[RossWaddell]

Looking at the board with the power jack on the left and the 16F8777A on the bottom, the JP2 jumper has the top two pins tied together. The LED bargraph has the writing towards me. That would seem to be the pick-pin-HIGH-LED-On scenario described above, so I don't get why the LEDs which aren't referenced are on. <Sigh>

[RossWaddell]

Problem solved:

':::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
'   Variable definition
':::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

ERROR_LED  VAR PORTD.1            ' rename the LED's
LATE_LED   VAR PORTD.2
HEART_LED  VAR PORTD.0

PORTD = 0