IF ....THEN.... problems

[El_AMPo]

You've got a redundancy in your code (maybe on purpose),

First you activate the timer = 1 flag, and in the next line of code you put an " IF timer = 1..."

Also the second IF THEN ELSE is inside the first IF THEN, try separating them.

Try using indent in your coding to see in a better way your routine operation

this is your code...commented

begin:
pause 100
IF timer = 1 AND relay = 1 THEN
    pause 500
    timer = 0 'turn off timer'
    PAUSE 1000
    portb.1 = 0
    timer = 1 'turn on timer'               '--turned timer = 1 

    IF timer = 1 AND relay = 1 THEN   '--inside first loop? move it out.  Timer already turned 1 on previous line, so is always true for that part
        pause 500
        timer = 0 'turn off timer'
        pause 1000
        portb.1 = 1
        pause 1000
        timer = 1 'turn on timer'
    ENDIF
ENDIF

[bursach]

Ok, first of all thanks .

This was part of code.... there is more. First is BUTTON command which activate timer. Then comes the rest of code.... then timer = 0 and again just turn the timer on without pressing button. Here is complete code with button command and corrections:

TRISA = $FF
TRISB = $00
B0 var byte
symbol t1 = porta.1
symbol timer = portb.0
symbol relay = porta.0


begin:
pause 100
IF timer = 1 AND relay = 1 THEN
pause 500
timer = 0 'turn off timer'
PAUSE 1000
portb.1 = 0
timer = 1 'turn on timer'
ENDIF

IF timer = 1 AND relay = 1 THEN

pause 500
timer = 0 'turn off timer'
pause 1000
portb.1 = 1
pause 1000
timer = 1 'turn on timer'
ENDIF

B0 = 0
button t1,0,255,0,B0,1,step 'if button is pressed, go to step'
pause 50
goto begin

step:
timer = 1

goto begin

End


This still do the same. Any help now?

[cncmachineguy]

try coding like this:

IF (timer = 1) and (relay = 1) then

I am not sure if this will work, it seems maybe relay never = 1?

[bursach]

yes relay will be =1 . I will explain. The timer is hardware piece with ne 555 and it has a relay on board. The portb.0 turning on timer(with transistor), and timer relay is on(relay = 0) for some time depending of potentiometer position. After timer turn off(ne555 ), the portb.0 is still on, but timer is not on becouse ne555 turn it off.The relay is off but it is connected to a porta.1 like button. So if relay is off, the pin porta.1 is on high (1) (pull up resistor). That is why the relay = 1 (it should be off and portb.0 is on, but timer is off).
I hope you have understand me .

All I need is to do this, example:
begin:
IF step1 AND step2 THEN
step3

IF step1 AND step2 THEN
step4

IF step1 AND step2 THEN
step5

goto begin
end



with this order.

[cncmachineguy]

so can you do this:

IF (step 1) and (step 2) then : ' notice the : it lets you have multiple steps
 step 3
 step 4
 step 5
endif

did you try it with () around the conditions?

[bursach]

I am using 16F84, all porta have been declarated as inputs( it is like pushbuttons) It works on the begining.. Yes I`ve tried this with ( ) and there is no difference still not working as I want. Maybe this can be done with while....wend or for.... cycle....just don`t know how.

[El_AMPo]

In 16F84 MCLR pin can't be disabled, so 4k7 resistor pullup to +5V or its never going to work
Also for the used inputs use 10K pullups and instead of using the button command, try something a lot simpler:

b0 = 0 'reset flag
if ti = 0 then 'if pullup pin is in ground
    b0 = 1 'activate button press flag
    pause 250 'debounce
endif

Try explaining a little better your circuit so i can help you with your code (maybe an schematic or diagram?)

Also remeber that a 16F84 its not the same as a 16F84A for the compiler, check for that.

[mark_s]

Dumb question, what pic are you using and have you set PORTA.0 and 1 to digital?