help with PIC16F628 conditional program

[joseph]

 IF ( FWD ^ REVS ) AND NOT NEUT THEN   
        forward = FWD : revers = NOT forward
       ELSE
        forward = 0 : revers = 0
       ENDIF

IF ( FWD ^ REVS ) AND NOT NEUT THEN <---- do this mean, if FWD and REVS are opposite and NEUT is low then

forward = FWD : revers = NOT forward <---- forward is equal to what is FWD and revers is equal to opposite of forward else

forward = 0 : revers = 0 <---- turn the outputs low

[joseph]

RA7 won't be an input until i independently configured it as an input so i placed this line

INPUT neut

@ DEVICE PIC16F628A, INTRC_OSC_NOCLKOUT, WDT_OFF, PWRT_OFF, MCLR_OFF,PROTECT_ON,CPD_ON, BOD_OFF, LVP_OFF

DEFINE OSC 4

CMCON = 7
pause 1
VRCON = 0
pause 1

TRISA = 95
TRISB = 0
PORTB = 0

GS1  var PORTA.0
GS2  var PORTA.1
TEMP var PORTA.2
FWD  VAR PORTA.3
REvs VAR PORTA.4
Neut var PORTA.7

forward  var PORTB.0
revers   var PORTB.1
one      var PORTB.2
two      var PORTB.3
three    var PORTB.4
starterd var PORTB.5

input neut


start: IF ( FWD ^ REVS ) and not neut THEN
        forward = FWD : revers = NOT forward
       ELSE
        forward = 0 : revers = 0
       ENDIF
goto start
end

this works, but for some reason instead of revers/portb.0 going steady high when the input condition rules i got some oscillations, the led connected on this on my simulation blinks

thanks

[Acetronics2]

RA7 won't be an input until i independently configured it as an input so i placed this line

INPUT neut

Did you notice IF you want Porta.7 as an input ... the TRIS value must be > 127 ???

here you have 95 ... tadaaaa ...

this works, but for some reason instead of revers/portb.0 going steady high when the input condition rules i got some oscillations, the led connected on this on my simulation blinks

no reason for that ... simulators are just toys , so do not believe what they say ...
may be you could add some debouncing to your inputs ... but simulation won't show anything.

Alain

[joseph]

i didn't notice that

here's a screenshot:


this happens to all ports on portb except rb0 where i get a straight line


thanks

[Acetronics2]

Could you post your ISIS file here ??? ( xxx.DSN )

Alain

[joseph]

here
direct link:
http://dc187.2shared.com/download/D7...42736-ef003566

if the direct link doesn't work, here:
http://www.2shared.com/file/D7VAeRiX/ecu.html


thanks

[Acetronics2]

Hi, Joseph

Definitly a simulator issue ... ( one MORE for Proteus ... )

Just run your program in MPSIM ( MPLAB Simulator ) in step by step mode, and you won't see any change for the output ...

I did told you Sims are toys ... , forget about them !!!

BTW, Correct code is:

 IF ( FWD ^^ REVS ) AND NOT NEUT THEN   
        forward = FWD : revers = NOT forward
       ELSE
        forward = 0 : revers = 0
       ENDIF

Doesn't change anything ... but brain satisfying !!! ( it's a logical EXOR, and not a bitwise one )

Alain