New approach to Rotary Encoder

[fratello]

I tried to ad a second check of direction :

loop:
    PortA.1 = 0
    newState = PortA & 011100         ; this is for my hw : 11100 = 28
    pause 50                             ; no matter what I put here : none, @ nop , pause 100 !
        newa = PortA & 011100
    PortA.1 = 1
    If newState <> 28 THEN
        If newState <> oldState THEN
              
            Select Case oldState
                Case 12
                If NewState = 20 THEN 
                        if newa = 24 then dir=up
                endif        
                
                case 12
                If NewState = 24 THEN 
                        if newa = 20 then dir=dn
                endif
 
                
                Case 20
                If NewState = 24 THEN 
                        if newa = 12 then dir=up
                endif  
                
                Case 20
                If NewState = 12  THEN 
                        if newa = 24 then dir=dn
                endif     
                
                Case 24
                If NewState = 12 THEN
                        if newa = 20 then dir=up
                endif
                
                Case 24
                If NewState = 20 THEN
                        if newa = 12 then dir=dn
                endif

            END SELECT
            oldState = newstate
            GOSUB UpOrDn 
       endif     
    ENDIF

But, in this way, any direction I rotate, the command is always "Dir Up" ?! Never goes "down" ...

[HenrikOlsson]

And what does the UpOrDn routine look like?

[fratello]

This routine should do "Track+" /"Track-" :

UpOrDn:
if dir=1 then
    PortB.4 = 0
    pauseus 3850
    PortB.4 = 1
    pauseus 3850
    PortB.4 = 0
    pauseus 660
    PortB.4 = 1
endif

if dir=0 then
    PortB.4 = 0
    pauseus 4450
    PortB.4 = 1
    pauseus 4400
    PortB.4 = 0
    pauseus 660
    PortB.4 = 1
endif    
return

[HenrikOlsson]

And what do we have in there, if not delays... They are quite short (8-10ms in total) but it's still possible that that is what's messing with you.
I don't know what you intended to do with that latest version though, why do you have two cases with the same value, just put the code for both in one.

[fratello]

This is schematic and code...Maybe I miss something important ...

@ DEVICE pic16F628A, XT_OSC, WDT_OFF, PWRT_ON, BOD_OFF, MCLR_ON, LVP_OFF, PROTECT_ON

include "alldigital.pbp"
   Define   OSC 4           ' 4MHz 
   CMCON = 7                ' Disable on-chip comparator, PORTA in digital mode


TrisA = %00011100           ; coloane la RA2, 3, 4 ; randuri la RA1, 0 ,7 
porta = %00011100
TRISB = %00000000
PORTB = %00010000 

oldState VAR BYTE
newState VAR BYTE

UP CON 1
DN CON 0


loop:
    PortA.1 = 0
    newState = PortA & %00011100         ; this is for my hw : 11100 = 28
    PortA.1 = 1

    If newState <> 28 THEN
        If newState <> oldState THEN
              
            Select Case oldState
                Case 12
                If NewState = 20 THEN dir=up       
                If NewState = 24 THEn dir=dn
                
                Case 20
                If NewState = 24 THEN dir=up               
                If NewState = 12 THEN dir=dn
               
                Case 24
                If NewState = 12 THEN dir=up                       
                If NewState = 20 THEN dir=dn
            END SELECT
            oldState = newstate
            GOSUB UpOrDn 
       pause 15                    ; time for UpOrDn     
       endif          
    ENDIF
;============
UpOrDn:
if dir=DN then
    PortB.4 = 0
    pauseus 3850
    PortB.4 = 1
    pauseus 3850
    PortB.4 = 0
    pauseus 660
    PortB.4 = 1
endif

if dir=UP then
    PortB.4 = 0
    pauseus 4450
    PortB.4 = 1
    pauseus 4400
    PortB.4 = 0
    pauseus 660
    PortB.4 = 1
endif    
return

end

[HenrikOlsson]

1) I don't understand why you keep putting those PAUSE statements in there, now you have a PAUSE 15 in there....
2) There's no GOTO LOOP anywhere so the program will "fall thru" into the UpOrDn routine then hit the RETURN and bad things will happpen. (BTW, Loop is a reserved word in newer versions of PBP, best to get used to not using it.
3) Try resampling the pins and set oldState when you return from the subroutine, ie (changes in red):

Main:
    PortA.1 = 0
    newState = PortA & %00011100         ; this is for my hw : 11100 = 28
    PortA.1 = 1
    If newState <> 28 THEN
        If newState <> oldState THEN
              
            Select Case oldState
                Case 12
                If NewState = 20 THEN dir=up       
                If NewState = 24 THEn dir=dn
                
                Case 20
                If NewState = 24 THEN dir=up               
                If NewState = 12 THEN dir=dn
               
                Case 24
                If NewState = 12 THEN dir=up                       
                If NewState = 20 THEN dir=dn
            END SELECT
            GOSUB UpOrDn 
            
            PAUSE 15                    ; time for UpOrDn   
         
     ' Now resample the encoder and keep the state as oldState
          PortA.1 = 0
         oldState = PortA & %00011100         ; this is for my hw : 11100 = 28
         PortA.1 = 1     
       
    ENDIF          
  ENDIF
GOTO MAIN
;============
UpOrDn:
if dir=DN then
    PortB.4 = 0
    pauseus 3850
    PortB.4 = 1
    pauseus 3850
    PortB.4 = 0
    pauseus 660
    PortB.4 = 1
endif
if dir=UP then
    PortB.4 = 0
    pauseus 4450
    PortB.4 = 1
    pauseus 4400
    PortB.4 = 0
    pauseus 660
    PortB.4 = 1
endif    
RETURN
END

[fratello]

Mr. Henrik I must get my hat in front of you ! (Hope G.translate work well !).
NOW, the code work verry good !!! Only sometimes the command are inversed , but in 9 case of 10 it's ok, so I can live with this...
Thanks for lost so much time with me ! I am verry grateful !