New approach to Rotary Encoder

[fratello]

No matter what I do, portb.1 goes high and low .... portb.0 don't change ....

TRISB = 000000
PORTB = 000000 

oldState VAR BYTE
newState VAR BYTE
DIR VAR BIT

UP CON 1
DN CON 0

oldstate = (porta & 000111)

Main_Loop: 

gosub Encoder
gosub check
goto main_loop

Check :
if dir = up then 
portb.0 = 1
pause 1000
portb.0 = 0
endif
if dir = dn then
portb.1 = 1
pause 1000
portb.1 = 0
endif
return

encoder:
portb.5 = 1
    pause 100
    newState = (porta & 000111)
portb.5 = 0
If newState <> oldState THEN        ' Changed from last time?
  Select Case oldState
    Case 1
    If NewState = 4 THEN dir=up         
    If NewState = 2 THEN dir=dn
  
    Case 2
    If NewState = 4 THEN dir=up        
    If NewState = 1 THEN dir=dn
  
    Case 4
    If NewState = 1 THEN dir=up        
    If NewState = 2 THEN dir=dn
    
  END SELECT

oldstate=newstate
endif
Return

[HenrikOlsson]

Hi,
Since you have the inputs pulled high and the wiper "grounding" each input as it cycles thru them you can't use 1, 2 and 4 as the states since that "looks for" a '1' on the individual pins. You need to use 3, 5 and 6 instead.

[fratello]

Twillight zone ....

  Select Case oldState
    Case 3
    If NewState = 6 THEN dir=up         
    If NewState = 5 THEN dir=dn
  
    Case 5
    If NewState = 3 THEN dir=up        
    If NewState = 6 THEN dir=dn
  
    Case 6
    If NewState = 5 THEN dir=up        
    If NewState = 3 THEN dir=dn
  END SELECT

No matter what I do, portb.1 goes high and low .... portb.0 don't change ....

[HenrikOlsson]

Don't know what to tell you but the code works just fine here.

HSEROUT ["Program start",13]

Main:
    PortB.5 = 0
    newState = PortA & %00000111
    PortB.5 = 1
    
    If newState <> 7 THEN
        If newState <> oldState THEN
              
            Select Case oldState
                Case 3
                If NewState = 6 THEN dir=up         
                If NewState = 5 THEN dir=dn
  
                Case 5
                If NewState = 3 THEN dir=up        
                If NewState = 6 THEN dir=dn
  
                Case 6
                If NewState = 5 THEN dir=up        
                If NewState = 3 THEN dir=dn
            END SELECT

            HSEROUT["oldState: ", DEC oldState, "   newState: ", DEC newState, "   DIR: ", DEC DIR, 13]        
        
        oldState = newState
        Pause 1000
        ENDIF
    ENDIF
    
Goto Main

This was executed on an AMICUS18 board with a PIC18F25K20. A wire from RB5 to the pulled up inputs was used to simulate the "encoder", the results are here:



As you can see, it works.

Have you verified that PortB.5 does go LOW?
Have you verified that you DO get a LOW on RA0,1 and 2 as you rotate the encoder?
Have you checked the datasheet to see if any other peripherals are multiplexed onto the pins you're trying to use? ADC? Comparator?

[mackrackit]

Been said before and I will say it again.

NEVER TRUST A SIM!

[fratello]

... ok, so work, despite the "non-working" of simulator !
Next step is to try to make the two coexist (keypad.bas & encoder.bas) .
First I will build the schematic and making some tests. Thanks again for the huge support !

[fratello]

It's this a viable options of reading encoder AND the others buttons ?

Main:
;==============
;reading buttons on line 0 (pseudo-encoder)
    PortB.5 = 0
    newState = PortA & %00000111
    PortB.5 = 1
    If newState <> 7 THEN
        If newState <> oldState THEN
              
            Select Case oldState
                Case 3
                If NewState = 6 THEN 
                dir=up         
                portb.0 = 1
                endif
                If NewState = 5 THEN 
                dir=dn
                portb.1 = 1
                endif
                
                Case 5
                If NewState = 3 THEN 
                dir=up         
                portb.0 = 1
                endif      
                If NewState = 6 THEN 
                dir=dn
                portb.1 = 1
                endif
                
                Case 6
                If NewState = 5 THEN 
                dir=up
                portb.0 = 1
                endif        
                If NewState = 3 THEN 
                dir=dn
                portb.1 = 1
                endif
            END SELECT      
            oldState = newState
          Pause 100
        ENDIF
    ENDIF
;==============
;reading buttons on line 1
    Porta.4 = 0
    status_2 = PortA & %00000111
    Porta.4 = 1
    select case status_2
                case 3
                gosub trackDn
                case 5
                gosub mute
                case 6
                gosub trackUp
    end select
;==============
;reading buttons on line 2    
    Porta.3 = 0
    status_3 = PortA & %00000111
    Porta.3 = 1
    select case status_3
                case 3
                gosub volDn
                case 5
                gosub volUp
                case 6
                gosub Sursa
    end select                           
Goto Main