Could I please ask for some help on my code

**Darrel Taylor** · - 20th January 2010, 01:46

bit0 and bit1 are aliases to bits in the B0 byte variable

So when you do something like ...

Code:

chk4: peek portA,B3
if Bit1 = 0 then fire4
goto chk4

It will get locked in the loop forever, because Bit1 can never change.

hth,

**opticaltrigger** · - 20th January 2010, 02:06

Hi Darrel and thankyou very much for the reply.
Can I ask Darrel how I should fix thiss problem,what should I type instead.
Please forgive my uninformed aproach to all this but its all quite new to me and Ive only had myself as a teacher so there are some serious gaps for me,but I love it all the same.

All the very best
O.T.

**Darrel Taylor** · - 20th January 2010, 02:24

Originally Posted by opticaltrigger

Can I ask Darrel how I should fix thiss problem,what should I type instead.

Well ... typing in your order for PicBasic Pro would probably be the easiest.

But, in lieu of that ... put your values in B0 if you want to test the bits.

Code:

chk4: peek portA,B0
if Bit1 = 0 then fire4
goto chk4

<br>

**opticaltrigger** · - 20th January 2010, 22:41

Thanks very much Darrel for helping me with that.
I just fired it up with the amended B0s and worked exactly as it should do straight away.I wish I could tell you how excited I feel seing it work.Its my first proper program for doing a job.
If I lived closer I would buy you a beer Darrel.Thanks so much.

Im going to swap the LEDs for transistors tomorow and see how it all gets on runing proper ignition coils and making sparks at the spark plugs.

One last thing if I may.As said its my first proper program so I have no bench mark to go by in terms of its efficiency,and I noticed that you had mentioned BASIC PRO might be better.My question is does the code look ok or do you see a way it could be better,or perhaps is it as good as can be with ordinary BASIC?
I want to try and get it to run as fast as possible really.
Any comments would be great but once again thankyou very much for helping me with it Darrel.

Best regards
O.T.

**Darrel Taylor** · - 20th January 2010, 23:35

And if we ever meet face to face, I will have you buy me that beer.

Originally Posted by opticaltrigger

Im going to swap the LEDs for transistors tomorow and see how it all gets on runing proper ignition coils and making sparks at the spark plugs.

Well now that you put it that way ... That's the strangest distributor I've ever seen.

One last thing if I may.As said its my first proper program so I have no bench mark to go by in terms of its efficiency,and I noticed that you had mentioned BASIC PRO might be better.My question is does the code look ok or do you see a way it could be better,or perhaps is it as good as can be with ordinary BASIC?

When it comes to regular PicBasic ... If it does exactly what you wanted it to do, then it's the perfect program.

You seem to be on the right track, so I'm sure you'll get the "Perfect" program for the next step too.

Best regards,

**opticaltrigger** · - 21st January 2010, 00:34

Well now that you put it that way ... That's the strangest distributor I've ever seen.

Yeah,it does look kinda strange.
I removed the rotor arm and put the segmented wheel in its place,the wheel itself is made from the cylinder head off a radio controled nitro car engine.

Thanks again for your help with it.

Best regards
O.T.

**Acetronics2** · - 22nd January 2010, 09:26

Hi, OT

I do not want to bash ...

But using Pure Basic to trigger your coils did not need to have killed this poor engine head ... Generally speaking, only asm interrupts can do the job ...

as your four cylinders ( do not joke ... it's not a flat 8 ??? ) distributor never will have enough accuracy in machining to give precise and separate advance values for the sparks ...

I send you an example vor a V twin engine ( site has halas been modified ... no more download ! )

Alain