calculator-like code entry with matrix keypad and display

[Dennis]

Hi all

I am working on the digits now, and I think I have almost got it sorted (or not!)
I just can't see where I am going wrong and I'm sure it's the way I'm working with the array.

To somplify things I have given the variable a set number, the number 123 as in my examples above.
here's the code so far

Start:
Codex	VAR BYTE
Temp	VAR BYTE [3]
TempTot var byte 
Codex = 123
Tempx var byte
'Find character for decimal 100 column
Tempx = Codex/100 'divide Codex by 100 'cos its the digit in 100's column
Temp(0) = Tempx + 48 'add 48 to get ascii value
lcdout "first " ,temp(0)
HSEROUT ["1st digit ", Temp(0),$0d,$0a]
pause 1000

'Find character for decimal 10 column
Tempx = Codex/10 'since Codex = 123 after dividing Temp = 12
Temp(1) = Tempx//10 'Remainder is required so with Codex = 123 the number in Temp = 2
Temp(1) = Tempx + 48 'add 48 to get ascii value
 lcdout "second ",temp(1) 
HSEROUT ["2nd digit ", Temp(1),$0d,$0a]
                  pause 1000
'Find character for decimal 1 column
Tempx = Codex//10 'Get Remainder so…with Codex = 123 then Temp = 3
Temp(2) = Tempx + 48 'add 48 to get ascii value
 lcdout "third ",temp(2)
HSEROUT ["3rd digit ", Temp(2),$0d,$0a]
 pause 1000
 TempTot = Temp(0)+temp(1)+Temp(2)
  hserout ["here's the binary total ",dec temptot,$0d,$0a]
 hserout ["here's the binary total ",bin temp,$0d,$0a]
 goto start

Observations:
The first and third digits are correct , the second is a problem (and I think it's the wrong number since it shows up as a ">" character ) so this obviously messes up the total after addition which ends up as 160 as opposed to 123 :-(
Here is what I see in the MCS serial tool window

1st digit 1
2nd digit <
3rd digit 3
here's the binary total 160
here's the binary total 110001

Any help would be appreciated

Dennis

[aratti]

Dennis you can use the DIG command:

Codex  var Byte
Temp0 var Byte
Temp1 var Byte
Temp2 var Byte

Codex = 123

Temp0 = Codex DIG 0 ' set Temp0 = to digit 0 of Codex
Temp1 = Codex DIG 1 ' set Temp1 = to digit 1 of Codex
Temp2 = Codex DIG 2 ' set Temp2 = to digit 2 of Codex

That all you need.

Al.

[Archangel]

Hi Dennis,
Your code looks much more difficult to me than it needs to be, you are doing a lot of "yuck" MATH, Math not my forte' , Anyway after you
get your actual number into a variable, use the DIG function to acquire the digits.

Digit1 var byte
Digit2 var byte
Digit3 var byte
TempX var byte

Digit1 = TempX DIG 0
Digit2 = TempX DIG 1
Digit3 = TempX DIG 2

HSEROUT ["1st digit ", DEC Digit0,$0d,$0a] 'copied from your code
HSEROUT ["2nd digit ", DEC Digit1,$0d,$0a] 'copied from your code
HSEROUT ["3rd digit ", DEC Digit2,$0d,$0a] 'copied from your code

I haven't looked at your code close enough to understand what the Hex 0D and Hex 0A are for, nor have I tested this code snippet, but it should give you some ideas.
Dadgummit Al posted while I was typing! Same idea too! HiYa Al !

[Dennis]

Joe S and Al thanks so much for the reply !!

And both your codes snippets work like a charm !

I love the DIG command ...very cool !

They certainly did simplify mine somewhat :-)

OK so here's the deal so far.
The HSEROUT line is working well !
Each decimal digit is displayed correctly and in the correct order!
So a number like 123 gets sent and displayed correctly :-)

Now what remains is what I have been on about since the beginning of this thread and that is the following.

I need to get each keypress stored in an array and then 'JOIN' (either by adding them or some other method ) them up into one number..that's why I went off on a tangent in the last post.
All I would like to do is be able to send one bye or word containing the actual number keyed in.
I would like to be able to key in the number 123 (and see it on screen) and then send it as the actual number 123 decimal or binary or hex ...just not as 3 separate bytes. Consider the same thing being done with a bank of 8 dip switches ... I set the dip switches to reflect the number 123 (bin=11110111 and hex =A3) and that's what I would read in and send.
But this seems to be rather difficult to do using a keypad not so ?

Again any suggestions etc would be greatly appreciated

Kind regards
Dennis

[Byte_Butcher]

How about something like this:

keypressed var byte ' latest keypad entry
mynumber var word 'your number, built up from multiple key presses

' each time a key is pressed, do this:

mynumber = (mynumber * 10) + keypressed

Maybe?


steve

[Dennis]

Tried that ... it yeilds undesirable results .. and with each keypress a different value appears in MCS serial tool window :-(

the numbers are 34113
the numbers are 13500
the numbers are 3978
the numbers are 39830
the numbers are 5134

This is probably because the number is continuously multiplied each time the program loops at each keypress ... and the word value aslo can only store two bytes (16 bits)
This is how I tried your suggestion

'end of variables
    
           Pause 2000       ' Wait for LCD to startup
Start:

  @ READKEYPAD _myvar  'read keypress variable and place in myvar
  
  LOOKUP myvar,[0,"123A456B789C*0#D"],myvar 'use lookup table to display proper keypress
           
               
                    

                   lcdout myvar
                   lcdout $fe,1
                   pause 1000
mynumber = (mynumber * 10) + myvar 
lcdout "my number ", dec mynumber
hserout ["the numbers are " ,dec mynumber,$0d,$0a]

The plan is along the right lines though!

1.Check keypress to see if it's valid (0-9,A,B,C,D)
2.Store each vaild keypress eg. 1,2,3 (number is 123) <<<<<<<<<<<THIS IS WHERE I HAVE A PROBLEM DON'T KNOW HOW TO WORK WITH THE ARRAY!
3.Check for # character which denotes a valid input
4.Take first character and (LSB) and multiply it by 1(byte 1)
5.Take next character and multiply by 10 (byte 2)
6.Take next character and multiply by 100 (byte 3)
7. Now add them up (in this example 100+20+3 = 123)
8.Check that number is valid ... <255 since it must be max one byte (8 bits)
123 is valid since it's less than 255
9.Display and send the number

Those are the steps I need to go through :-)

Hope that helps

Kind regards
Dennis

[aratti]

Dennis tray this snippet:

Array var Byte [3]
A0 var byte
B0 var Byte
KeyPress Var Byte ' will contain the ascii character of the key pressed

A0=0

Ini:
If KeyPress = "#" then
B0= (Array[0]*100)+(Array[1]*10)+Array[2]
HSEROUT [B0]
A0=0
ENDIF

If A0>2 then Ini

Array[A0]=KeyPress -48
A0=A0+1
goto Ini

Al.

[Dennis]

Al .... it's sort of working :-) YAY at least some light at last :-)

I tried your code snippet :-) and it sort of works :-)

You can now enter digits, each keypress shows up on the LCD , a # value denotes a send and a * denotes a clear and retry.

Ok so when I enter 123# , the correct number is sent to the PC com port and arrives perfectly at MCS serial tool window! YAY
In fact any 3 digit number within the range of 100 to 255 works well.
Anything larger is obviously too large for the var byte value so shows up as the number less 256 which means it is behaving correctly since I only want a max of one byte (0 to 255).
For example I enter 455# ,MCS serial tool shows the number as 199 (455-256) .

So the problem now is how to get numbers which are less than 3 digits to work.
For example if I enter the number 99 I get 227 in MCS serial tool
Another example is the number 1 (single digit) shows up as 195

I am trying to figure out why but can't see it as yet.

Another thing is if you do send a number larger that 255 or something less than 3 digits , the next few times , any valid 3 digit number entered is incorrectly displayed ...still looking to slove that one!
I added a retry: label .. which runs when you enter the * key. It clears the vars send pointer to beginning of the main loop :-)


If you have any updates or suggestions I would gladly try them

Please find the current (semi-working) code attached below

Kind regards

Dennis

myvar var byte 'var output from keypress
Array var Byte [3] 'array variable to hold 3 keypresses
A0 var byte 'counter/index
B0 var Byte 'sum of digits
KeyPress Var Byte 'holds each keypress as it happens
           Pause 2000       ' Wait for LCD to startup

  
   A0=0   'index = 0

Ini:

lcdout $fe,1
lcdout "enter number"
@ READKEYPAD _myvar  'read keypress variable and place in myvar
  
  LOOKUP myvar,[0,"123A456B789C*0#D"],myvar 'use lookup table to diplay proper keypress
  keypress = myvar 'pass the variable to solve strange character problem
 ' will contain the ascii character of the key pressed
  
  lcdout keypress
  pause 1000
  lcdout $fe,1  
'If keypress = "a" or "b" or "c" or "d" then goto numbers
if keypress = "*" then goto retry
If KeyPress = "#" then    'check input keypress for a # value
B0= (Array[0]*100)+(Array[1]*10)+Array[2]'multiply each bit in the array by the correct column value
'if B0 > 255 then goto overflow 'test for overflow B0>255
HSEROUT ["here is the total ",dec B0,$0d,$0a]  'send result to pc com port 
 
A0=0
 
ENDIF

If A0>2 then retry 'Ini

Array[A0]=KeyPress -48
A0=A0+1

goto ini

numbers: 'tell person to enter only numbers
lcdout "numbers only"
pause 1000
A0=0
myvar=0
goto ini

retry: 'is the * key is pressed then prompt for a retry and clear A0 and myvar
lcdout "retry"
pause 1000
lcdout $fe,1
A0=0
myvar=0
goto ini

overflow: 'tell person to enter 0 to 255 only
lcdout $fe,1
lcdout "0 to 255 ONLY!"
pause 1000
A0=0
myvar=0

goto ini