a little help with keypad on 18f4520 please

[aratti]

Then the # is encountered and we do an hserout

Will we send a total of a 3 character string using hserout (in other words 24bits)

Hserout [str Ret_Char \ Ret_count-1], will send out a string of Ret_count-1 bytes, so "#" will not be sent

You could use SEROUT2

SEROUT2,pin,baud,[str Ret_Char \ Ret_count-1]

or you could use SEROUT

For A0 = 1 to Ret_count-1
Serout pin,baud,[Ret_Char [A0]]
NEXT A0


Al.

[Dennis]

Thanks for hserout clairfying the code and the option for serout2.

Let me re-phrase that last question
"Then the # is encountered and we do an hserout

Will we send a total of a 3 character string using hserout (in other words 24bits)"

So it will be 24 bits ... 134 (0000001 11000000 01000000) as opposed to the 8 bit number 134 (10000110)

I am after a single 8 bit number , at the end of the key capture
(or more depending on whether the number keyed in is larger than 255- perhaps I should cap it at 255).

So perhaps I need to do a little math in the array, perhaps (+) OR-ing ?

[Dennis]

Hi Al

How are you ?

I am experimenting with your code snippet .. here's what I have so far.

'keypad variables for array keypress capture begin here 
        Retain         var byte
        Ret_Char     var byte [10]
        Ret_Count   var byte
        Ret_Prnt      var byte
        Ret_Clst       var byte
        Ret_Prnt = "#"
        Ret_Clst = "*"
        'keypad capture code begins here
        Ret_Char[Ret_Count]=datatx ' here you transfer the char of the key pressed

        If Retain = 0 then ' Retain is a flag then if set will do your job 
        For A0 = 1 to Ret_count -1
        Serout portc.6,T2400,baud,[Ret_Char [A0]]
        NEXT A0

        lcdout datatx 'display the variable on the LCD
        pause 1000
        lcdout $fe,1          'clear lcd screen
        else

        If Ret_Char[Ret_Count] = Ret_Clst then ' if key = "*" then step-back counter
        Ret_Count = Ret_Count - 1
        goto Clear_Count
        endif

        If  Ret_Char[Ret_Count] = Ret_Prnt then ' if key = "#" then send string
        For A0 = 1 to Ret_count -1
        Serout portc.6,T2400,[Ret_Char [A0]]
        NEXT A0

        lcdout datatx 'display the variable on the LCD
        pause 1000
        lcdout $fe,1          'clear lcd screen
        RetCount = 0
        goto Clear_Count
        endif
        Ret_Count = Ret_Count + 1
        Clear_Count:
        endif
goto start

As i try to compile I encounter an error here
For A0 = 1 to Ret_count -1

Not quite sure why ?

Do you think I could attain the same thing with either a case select statement or a do...while loop ?
So if I were using a do ... while (or while wend) for example
do
keep allowing keypress
While
key_press_variable is not equal to '#" 'until we see #

then serout

Kind regards
Dennis

[aratti]

...... As i try to compile I encounter an error here
For A0 = 1 to Ret_count -1
Not quite sure why ?

Simply because variable A0 has not been declared! Add A0 var Byte to your code.

While wend loop could work as well, if properly structured.

Remember you should place two limits: Ret_Count cannot be greater then the array dimension and # command should be ignored if Ret_Count = 0.

Al.

[Dennis]

Al

I feel a little stupid for missing that obvious one :-)

Will make the change and feedback asap :-)

Stay tuned :-)

And once again thanks for the reply and help :-)

Kind regards
Dennis