16f887 44 pin demo board code problem?

[jessey]

Hello,
I was wondering if someone could suggest why this code below doesn't work to change the oscillator speed of the Internal Oscillator while the program is running but the other code block below does work? Another thing I was pondering is, shouldn't I be setting bit 0 of the OSCCON register to 1? The datasheet for the 16f887 says this about bit 0:
1 = Internal oscillator is used for system clock
0 = Clock source defined by FOSC<2:0> of the CONFIG1 register.

'this doesn't work
   IF Push_Button = Is_Pressed THEN 
      IF OSCCON = %01100000 THEN 
         OSCCON = %01110000  
      ELSE 
         OSCCON = %01100000 
      ENDIF 
      WHILE Push_Button = Is_Pressed  
           PORTD = %10000001 ' Show that button press has stopped the code here
      WEND 
   ENDIF

'this works
   IF Push_Button = Is_Pressed THEN
      IF B = 0 THEN 
         B = 1 
      ELSE 
         B = 0
      ENDIF
      WHILE Push_Button = Is_Pressed  
           PORTD = %10000001 ' Show that button press has stopped the code here
      WEND
   ENDIF 
   IF B = 0 THEN OSCCON = %01110000 ' 8 MHz 
   IF B = 1 THEN OSCCON = %01100000 ' 4 MHz

Thanks
jessey

[Acetronics2]

hi,

I think it is "not so good" to change osc settings WHILE you touch the button ( debounce issue guaranteed !!! ...PORTD can show anything but truth !!! )

good reason for #2 to work better ... ONLY better.

I ( it's me ...) Would look for button state CHANGES instead of simply the button state ...

Alain

[mackrackit]

Another thing I was pondering is, shouldn't I be setting bit 0 of the OSCCON register to 1? The datasheet for the 16f887 says this about bit 0:
1 = Internal oscillator is used for system clock
0 = Clock source defined by FOSC<2:0> of the CONFIG1 register.

See post #4
You have the OSC set for internal at the start. In the config settings. You do not need to change the source.