Outside the Mainloop

[pescador]

First post - first program - I want to initialize some variables before the mainloop executes and have subroutines below the mainloop controlled by gosubs within the mainloop. The problem I've been seeing is the gosubs seems to execute without being called, for example a initialize the variables sub routine, like the program kept going instead of returning to the top of the mainloop. Do I need an "end" after goto mainloop?

for example

gosub init:

MAINLOOP:
if x = 2 then
gosub dothis
endif

goto mainloop

dothis:
program
return

init:
x = 1
return

I've seen the dothis sub routine get executed without gosub being executed...like the program just keeps going past the goto mainloop command - (crude example of my real program)

I'm wondering if I'm missing a golden rule of keeping my program flow within the mainloop.

[HenrikOlsson]

Hi,
Except for the colon in the line GOSUB Init: I don't see any issues with this piece of code. Make sure ALL subroutines ends with a RETURN. If you GOTO something FROM a subroutine then makes sure THAT piece of code ends with a RETURN. That's all the advice I can give you ATM.

You'd be much better helped if you boil down your ACTUAL code to something small that still shows the error and post that.

/Henrik.

[Demon]

I used to write like you, except with the END as commented by Henrik.

I have since changed to how I've seen countless examples here:


Define variables and stuff

GOTO ProgramStart

Subroutine1:
bla bla
RETURN

ProgramStart:
bla bla
GOSUB Subroutine1
GOTO ProgramStart
END

Your code "should" work. But I've never had a freaky situation by coding like this yet.

Robert

[Charlie]

GOSUB init not GOSUB init: (which would then be a label)
MAINLOOP and mainloop are different things.

Post your actual code and we will help you find the other (likely) typos.

[HenrikOlsson]

MAINLOOP and mainloop are different things
No, they're not in this case. PBP is not case sensitive.

/Henrik.

[pescador]

ok - thanks - I will... I'm currently trying to HPWM a set of LEDs with a 12F683 next so I'll give that shot. I havea degree in CS - JAVA and C++, but haven't used it since college. I'm 60 years old this year - not kidding.. never too late.

[Charlie]

I stand corrected - labels are not case sensitive. Most other things are, however.

[HenrikOlsson]

Hi Charlie,

I'll elaborate a bit further: PBP is not case sensitive. The case of labels, commands, variables, constants, modifiers doesn't matter - not case sensitive.

It's only the case of the "things" that gets passed directly to the assembler (like anything coming after the keyword DEFINE or if you're using inline assembly) that matters because the assembler (MPASM(X)) IS case sensitive.

/Henrik.

[Charlie]

I checked the manual twice and it agrees with you, however I distinctly remember fixing a bug where I had mixed up capitalized variables and non-capitalized variables. (and I don't think it being passed to the assembler) Nevertheless, sorry for giving bad advice. In this case good form and good function are not necessarily related :-)

[Dave]

You may be thinking about the DEFINE commands. They need to be capitolized.

[Demon]

Actually, as Henrik has pointed out elsewhere, the DEFINE does not have to be capitalized, only the variables after it.

Robert