+ Reply to Thread
Page 18 of 19 FirstFirst ... 8141516171819 LastLast
Results 681 to 720 of 753
  1. #681
    Join Date
    Feb 2005
    Location
    Kolkata-India
    Posts
    558

    Default Re: Instant Interrupts - Revisited

    Hi,

    When using multiple interrupt sources you can prioritize which Interrupt flags to check when vectored to ISR, still the results may not be deterministic every time. Say you are already servicing a lower priority interrupt (not Hardware but DT's scheme) a higher priority interrupt like your time tick occurs. Generally adding the rolling timer with the offset value does the trick however if you would like more precision then use the compare module on the PIC which resets the associated timer automatically and gives a rock solid time base.
    Regards

    Sougata

  2. #682
    Join Date
    Nov 2003
    Location
    Wellton, U.S.A.
    Posts
    5,843

    Default Re: Instant Interrupts - Revisited

    You need to fine tune the timer, not the OSC.
    Here is an example
    http://www.picbasic.co.uk/forum/show...3259#post23259
    And here is another
    http://www.picbasic.co.uk/forum/show...5912#post75912
    And this will help with the calcs.
    http://www.picbasic.co.uk/forum/cont....-PICMultiCalc


    Hi, we are pleased to see that you are using our forum.

    We'd like you to become a member of our community. Membership is FREE, please REGISTER and view our forums without these annoying reminders!

    Once registered you may post on the forums, download from the file areas and use the WIKI without interruption.




    Dave
    Always wear safety glasses while programming.

  3. #683
    Join Date
    May 2012
    Posts
    5

    Default Re: Instant Interrupts - Revisited

    Hello good people,


    I follow this forum for a long time, it is excellent! I found a lot of good stuff on it.


    Now I have a problem with the code from Mr. Darrel Taylor.


    Thus, I use pic18f2550 and connect DS1307z and 4 PWM channels to PORTA


    SDA Var PORTA.1
    SCL Var PORTA.0


    ASM
    SPWM_LIST macro
    SPWM_PIN PORTA, 2, _CH1
    SPWM_PIN PORTA, 3, _CH2
    SPWM_PIN PORTA, 4, _CH3
    SPWM_PIN PORTA, 5, _CH4
    endm
    SPWM_INIT SPWM_LIST


    INT_LIST macro
    INT_Handler TMR1_INT, SPWMhandler, ASM, yes
    endm
    INT_CREATE
    ENDASM
    @ INT_ENABLE TMR1_INT


    Now i got problem with this configuration. When i enable SPWM_LIST then RTC stop working, in fact he working but value he give, its not good. When i disable software pwm, RTC is working good.


    I hope that you understande what is my problem and that one of you has a solution for this problem.


    Sory for my english


    Thanks a lot, Damir

  4. #684
    Join Date
    Jul 2003
    Location
    Colorado Springs
    Posts
    4,935

    Default Re: Instant Interrupts - Revisited

    Do you have this in your program ... ?

    Code:
    ADCON1 = 15
    DT

  5. #685
    Join Date
    May 2012
    Posts
    5

    Default Re: Instant Interrupts - Revisited

    Thank you for quick reply!

    Yes i have, this is configuration for my pic



    ADCON1 = $0F
    CMCON = 7
    UCFG.3 = 1
    PORTA = 0
    PORTB = 0
    PORTC = 0

  6. #686
    Join Date
    May 2012
    Posts
    5

    Default Re: Instant Interrupts - Revisited

    Just want to add,when I turn off TRM1 before reading i2c, rtc is operating normally, but problem is with LED strips on PWM channel they strart flashing.

    T1CON.0=0
    I2CRead sda,scl,$D0,$00,[RTCSec,RTCMin,RTCHour,RTCDay,RTCDate,RTCMonth,RTCY ear]
    T1CON.0=1
    Last edited by DaTiNs; - 31st May 2012 at 13:09.

  7. #687
    Join Date
    Jul 2003
    Location
    Colorado Springs
    Posts
    4,935

    Default Re: Instant Interrupts - Revisited

    Damir,

    I can duplicate the issue here, which appears to be the old R-M-W hardware problem.
    I moved the PWMs over to PORTC, and everything works fine.

    Since I2C uses pull-ups instead of bi-polar driven outputs, it's more susceptable to R-M-W problems.

    If you cannot move pins around on your project, you can get away with the following.
    In general, I do not recommend doing this type of modification.
    But in your specific case, it should work.

    Code:
      SPWM_LIST macro 
          SPWM_PIN LATA, 2, _CH1 
          SPWM_PIN LATA, 3, _CH2 
          SPWM_PIN LATA, 4, _CH3 
          SPWM_PIN LATA, 5, _CH4 
        endm
    DT

  8. #688
    Join Date
    Jul 2003
    Location
    Colorado Springs
    Posts
    4,935

    Default Re: Instant Interrupts - Revisited

    I should have also mentioned that when using the LATA register, you'll need to set the pins to output manually.
    Code:
    TRISA = %11000011
    Last edited by Darrel Taylor; - 31st May 2012 at 19:56.
    DT

  9. #689
    Join Date
    May 2012
    Posts
    5

    Default Re: Instant Interrupts - Revisited

    Thank you very much!

    I must add TRISA = 0 to the begin of code, and then start work great.

    One more time, thank you, Damir.

  10. #690
    Join Date
    May 2006
    Location
    Del Rio, TX, USA
    Posts
    345

    Default Re: Instant Interrupts - Revisited

    Darrel,
    While poking around and getting ideas, I got to looking at ver 1.2 of "Elapsed_INT-18.bas". I was particularly interested in the nice routine to calculate the timer reload constant:

    Code:
    ' -------------- calc timer reload Constants -------------------------------
    ASM
    T1PS = 1                             ; start with 1:1 postscaler
    TimerConst = ((OSC*1000000)/4/100)   ; how many timer ticks will it take
      while TimerConst > 65400           ; if it's more than the timer can count
    T1PS = T1PS * 2                      ;   double the postscaler
    TimerConst = TimerConst / 2          ;   halve the count
      endw
    TimerConst = 65536 - TimerConst + 8  ; final reload value
    But, I think there is an error in the formula. The absolute time it takes to execute the 8 instruction cycles doesn’t change. But, the time in relation to the TMR1L will be proportional to the prescaler. So, that should be accounted for in the formula, as such:
    Code:
    TimerConst = 65536 - TimerConst + (8/T1PS)  ; final reload value
    Since it's not likely the prescaler will need to be above 1:8, the 8/T1PS shouldn’t get too low.

    Thanks again for your great work and inspiring examples,
    Steve
    Last edited by SteveB; - 5th December 2012 at 23:38. Reason: typo

  11. #691
    Join Date
    May 2006
    Location
    Del Rio, TX, USA
    Posts
    345

    Default Re: Instant Interrupts - Revisited

    The code could also be changed thus, not that it makes a difference:

    Code:
    T1PS = 1                             ; start with 1:1 postscaler
    TimerConst = ((OSC*1000000)/4/100)+8 ; how many timer ticks will it take
      while TimerConst > 65400           ; if it's more than the timer can count
    T1PS = T1PS * 2                      ;   double the postscaler
    TimerConst = TimerConst / 2          ;   halve the count
      endw
    TimerConst = 65536 - TimerConst      ; final reload value

  12. #692
    Join Date
    Aug 2005
    Posts
    41

    Default Re: Instant Interrupts - Revisited

    Hi Darryl,

    Currently getting an error with Latest MPLAB IDE:
    MPLAB 8.90.00.00

    PIC is an 18F45K22 and DT_INTS-18 is latest from your website, both MPLAM and DT_INTS were downloaded from the respective sites on 15/3/2013


    ERROR: Unable to execute mpasmwin.Warning[206] M:\<FOLDERPATH><FILE>ASM 2170 : Found call to macro in column 1. (INT_ENABLE)
    Error[116] M:\<FOLDERPATH><FILE>.ASM 696 : Address label duplicated or different in second pass (Z00032)
    Error[116] M:\<FOLDERPATH><FILE>.ASM 759 : Address label duplicated or different in second pass (Z00033)
    Error[116] M:\<FOLDERPATH><FILE>.ASM 812 : Address label duplicated or different in second pass (Z00034)
    Error[116] M:\<FOLDERPATH><FILE>.ASM 843 : Address label duplicated or different in second pass (Z00035)

    Can you advise if there is any fix for this or do i need to use an older version of MPLAB IDE

  13. #693
    Join Date
    Nov 2003
    Location
    Wellton, U.S.A.
    Posts
    5,843

    Default Re: Instant Interrupts - Revisited

    Dave
    Always wear safety glasses while programming.

  14. #694
    Join Date
    Oct 2005
    Location
    New Jersey
    Posts
    408

    Default Re: Instant Interrupts - Revisited

    I've used the DT_INTS sucessfully with an 18F4550. I had to move to an 18F87J50 but the DT_INTS would not compile. Not sure if I'm doing something wrong or if the DT_INTS was never tested with J series PIC's. When I compile, I get the following warning message:
    Code:
    Unable to fit variable VP_DelayCount in requested bank 0
    In the "VirtualPort.bas" code, I changed this code:
    Code:
    VP_DelayCount  VAR WORD BANK0  ; Used for internal Delay only
    to this:
    Code:
    VP_DelayCount  VAR WORD BANK1  ; Used for internal Delay only
    and it compiled as expected. I have no clue if this will cause unexpected problems with my program or if this is the correct way to solve it but I haven't noticed any ill effects yet. Seems like this problem could be related to the SFR's but it's way above my level of knowledge.

    Just thought I'd pass it along.

  15. #695
    Join Date
    Jul 2003
    Location
    Colorado Springs
    Posts
    4,935

    Default Re: Instant Interrupts - Revisited

    NO! You can't just change the variable to BANK1!
    That variable must be in BANK0.

    Both DT_INTS-18 and VirtualPort.bas fit quite comfortably in an 18F87J50, with room to spare. Even when using PBPL.

    How many variables have you declared in BANK0 in your program?
    Or, what other include files are you using that may have variables placed in BANK0.
    DT

  16. #696
    Join Date
    Oct 2005
    Location
    New Jersey
    Posts
    408

    Default Re: Instant Interrupts - Revisited

    Quote Originally Posted by Darrel Taylor View Post
    NO! You can't just change the variable to BANK1!
    Oh. The door was locked and I couldn't find the key so I just picked the lock.

    Quote Originally Posted by Darrel Taylor View Post
    How many variables have you declared in BANK0 in your program?
    Or, what other include files are you using that may have variables placed in BANK0.
    Good questions and ones that I wish I had answers for. I'm using HIDmaker so that's probably the root cause. Do I need to figure this problem out or is there a workaround?

  17. #697
    Join Date
    Nov 2003
    Location
    Greece
    Posts
    2,268

    Default Re: Instant Interrupts - Revisited

    I am trying to make an Interrupt on Rising Edge, PortB.0 on a 16F1827 chip.

    When first POR the device, it send the message "Program started" and waits for the Interrupt.

    When interrupt happens, Portb.0 is left open (it has pull-up enabled) the ISR is executed sending the message "Hey, I am sleeping!".

    And then keeps on sending the message even if the PortB.0 has been restored (grounded).

    Anyone sees what stupid thing I missed?

    Ioannis
    Attached Files Attached Files

  18. #698
    Join Date
    Jul 2003
    Location
    Colorado Springs
    Posts
    4,935

    Default Re: Instant Interrupts - Revisited

    Ioannis,

    You just need to clear the IOCBF register before exiting the ISR.

    IOCBF = 0
    DT

  19. #699
    Join Date
    Nov 2003
    Location
    Greece
    Posts
    2,268

    Default Re: Instant Interrupts - Revisited

    Oh, I see.

    I thought this was taken care by the DT-INTS.

    Thanks Darrel,
    Ioannis

  20. #700
    Join Date
    Jul 2003
    Location
    Colorado Springs
    Posts
    4,935

    Default

    That's what everyone else thinks too, so don't feel too bad.

    However, the "Interrupt On Change" on some chips have many interrupt flags that "funnel" into a single IOCIF flag.
    DT_INTS only knows about the one IOCIF flag. It has no control over the other 8 flags in the IOCBF register.

    It's alot like the USB modules which have 12 interrupt flags that funnel into a single USBIF flag.
    But for some reason, nobody expects DT_INTS to handle all of those automatically.
    Well actually, if you add DT_HID, they are handled automatically, but that's not the point.

    There are too many variations of the IOC interrupts.
    Some chips have them on PORTB, some on PORTA, and some have combinatons of PORTA, PORTB and PORTC.
    Its the one part of a PIC that you can pretty much assume won't work the same way as the last chip you used.

    And there are too many ways you can use IOC interrupts, there's no way I could make something that would work for everybody.
    It's much easier for the user to add one or two lines of code to clear the flags the way that best fits the application.
    DT

  21. #701
    Join Date
    Nov 2003
    Location
    Greece
    Posts
    2,268

    Default Re: Instant Interrupts - Revisited

    Thanks Darrel. Yes I understand that it is too much to ask for your software to cover every variation that Microchip offers.

    It was my part to find that, though I got a little confused by the Data sheet and could not see the obvious.

    By the way, this little monster (16F1827) has got a core temperature sensor too!

    Ioannis

  22. #702
    Join Date
    Aug 2004
    Posts
    59

    Default Re: Instant Interrupts - Revisited

    Hi Darrel: I made a little test with this:
    DEFINE OSC 8
    ' **** CONFIGURACION 16F1826 *************************
    #CONFIG
    __config _CONFIG1, _FOSC_INTOSC & _MCLRE_OFF & _CP_ON & _WDTE_OFF
    __config _CONFIG2, _PLLEN_ON & _LVP_OFF
    #ENDCONFIG
    ANSELA= %00000001 'Set 'em all to digital
    ANSELB= 0 ' 'all digital
    ADCON0= 1
    adcon1=$80
    CM1CON0 = 0
    CM2CON0 = 0
    OSCCON = $72
    '*******************************
    LED1 VAR PORTB.3

    INCLUDE "DT_INTS-14.bas" ' Base Interrupt System
    INCLUDE "ReEnterPBP.bas" ' Include if using PBP interrupts

    ASM
    INT_LIST macro ; IntSource, Label, Type, ResetFlag?
    INT_Handler TMR1_INT, _ToggleLED1, PBP, yes
    endm
    INT_CREATE ; Creates the interrupt processor
    ENDASM

    T1CON = $31 ; Prescaler = 8, TMR1ON
    @ INT_ENABLE TMR1_INT ; enable Timer 1 interrupts

    Main:
    PAUSE 1
    GOTO Main

    '---[TMR1 - interrupt handler]--------------------------------------------------
    ToggleLED1:
    TOGGLE LED1
    @ INT_RETURN

    When I compile, I got 2 errors:
    574 Illegal opcode (aftersave)
    581 Illegal code (AfterUserRoutine)

    and two warnings:
    574 found label after column 1 (GetAddress)
    581 found label after column 1 (GetAddress)
    Please help...
    Greetings...
    Ruben de la Pena V.

  23. #703
    Join Date
    Jul 2003
    Location
    Colorado Springs
    Posts
    4,935

    Default Re: Instant Interrupts - Revisited

    Ruben,

    1) Did you retype the errors, or copy&paste them? The errors are not even the correct format.

    2) Have you modified the DT_INTS-14.bas file? The stated errors do not occur when I compile your code.

    Try downloading the include files again.
    http://www.darreltaylor.com/DT_INTS-14/downloads.htm
    DT

  24. #704
    Join Date
    May 2013
    Location
    australia
    Posts
    329

    Default Re: pbppi14e.lib errors

    I have had similar problems , it seems I cut and pasted the asm section from somewhere that included an illegal non printing character. simple solution is to retype the asm section ,remember its case sensitive
    ASM
    INT_LIST macro
    INT_Handler TMR1_INT, _ToggleLED1, PBP, yes
    endm
    INT_CREATE
    ENDASM

  25. #705
    Join Date
    Aug 2004
    Posts
    59

    Default Re: pbppi14e.lib errors

    Hi Darrel:
    Thanks ... I reloaded the files and now it works...

    Ruben de la Pena V.

  26. #706
    Join Date
    Aug 2010
    Location
    Chiang Mai University, Thailand
    Posts
    9

    Default Re: pbppi14e.lib errors

    1st off wish to thank Darrel for a very useful routine. Now my issue. It seems when in a WHILE loop or a REPEAT..UNTIL look the interrupts are no longer detected. I am using the UART interrupts and they work flawlessly until I call a subroutine which has the WHILE loop and can't get out of it. I have a command protocol where I send a START command via serial which will call the looping program. I stop the loop by sending a STOP command. I minimized the routine to have only the loop and not the code within the loop to simply the trouble shooting. Below the code snippets.

    The uart interrupt entry routine reduced to just the command of interest.

    SERIALINT:
    HSERIN [COMMAND,DEC1 MODE,DEC5 IODATA]
    SELECT CASE COMMAND
    CASE "N" 'Control scan position and start/stop PIEZO1
    MOTORADDR = PIEZO1
    SELECT CASE MODE
    CASE STARTPOS 'READ START POS DATA 16-BITS
    PIEZO1START = IODATA
    CASE ENDPOS 'READ END POS DATA 16-BITS
    PIEZO1END = IODATA
    CASE STARTSCAN 'START SCANNING
    SCAN = TRUE
    HSEROUT ["START",13,10] '0-65535
    CASE STOPSCAN 'STOP SCANNING
    SCAN = FALSE
    HSEROUT ["STOP",13,10] '0-65535
    END SELECT
    GOSUB BEGINSCAN
    END SELECT
    @ INT_RETURN

    The subroutine being called below. When I send the start command it enters the routine fine but sending another command to stop it never enters the interrupt handler.
    debugging lines to transmit START or STOP in the handler. START is sent to the terminal but STOP doesn't which shows it doesn't recognize another interrupt. Without the WHILE
    loop, works fine. I commented the main code to make it as simple as possible


    BEGINSCAN: 'START SCANNING PIEZO1
    IF (PIEZO1END - PIEZO1START) < 1000 THEN
    SCANSTEP = 1
    ELSE
    SCANSTEP = (PIEZO1END - PIEZO1START)/1000 'LIMIT TO 1000 STEPS
    ENDIF
    '
    WHILE SCAN = TRUE
    ' SCANINDEX = PIEZO1START
    ' ARRAYCOUNT = 0
    ' WHILE SCANINDEX <= PIEZO1END
    ' PIEZO1POS = SCANINDEX
    ' GOSUB SETPIEZO
    ' PDSELECT = pd1 'CONVERT PD1 DATA AND STORE IN ARRAY
    ' GOSUB READPD
    ' PD1ARRAY[ARRAYCOUNT] = PD1DATA
    ' SCANINDEX = SCANINDEX + SCANSTEP
    ' ARRAYCOUNT = ARRAYCOUNT + 1
    ' WEND
    'GOSUB SENDARRAY 'SEND SAVED DATA TO PC
    WEND
    RETURN

    Is there something about WHILE or REPEATS that doesn't allow interrupts? I also put a 1 ms pause in the loop and same problem.

  27. #707
    Join Date
    Dec 2010
    Posts
    279

    Default Re: pbppi14e.lib errors

    You'll need to post ALL the code before folks can help I think, since the problem is not necessarily in this little bit. The "@ INT_RETURN" suggests these are the actual interrupt routines? One thing to be cautious about is that interrupts can occur while you are in your handler routine, causing the routine to restart and all sorts of other strange problems. Your interrupt routine should be as fast as possible - usually only a flag is set, that your main program loop can quickly detect and take action on. If you must do a few things in the routine, then you need to disable interrupts while in the routine, and risk missing something.

  28. #708
    Join Date
    Jul 2003
    Location
    Colorado Springs
    Posts
    4,935

    Default Re: pbppi14e.lib errors

    If you call a subroutine from the Interrupt Handler, you are still in the Interrupt.

    Interrupts will not interrupt an interrupt.
    The handler must complete and exit before another interrupt can occur.
    DT

  29. #709
    Join Date
    Aug 2010
    Location
    Chiang Mai University, Thailand
    Posts
    9

    Default Re: pbppi14e.lib errors

    Quote Originally Posted by Charlie View Post
    You'll need to post ALL the code before folks can help I think, since the problem is not necessarily in this little bit.
    The entire code is a couple of hundred lines so not practical to post all of it. I stripped it down to the absolute minimum to focus on the handler. I am using the uart interrupt to monitor for a command. If the command is "S" then it will enter the scan subroutine which is just a while loop and print START on the terminal. If when in the loop I send a F it should exit the sub and print "STOP" to the terminal. The start works as it can be seen entering the SCAN subroutine but never exits when I send a stop request. The simplified code here, interrupt handler in red. No timing issues as I am entering the commands via a terminal manually.

    Darrel's comment indicates that the scan routine has to complete on its own to exit the interrupt handler, which of course is not possible with the While loop as it is. That means that the Instant Interrupts doesn't support re-entry. I've written interrupt handlers but on large non-pic systems and re-entry is critical to real time OSes but it makes stack management complex. Guess one way to do it is to monitor the receive buffer in the scan loop to look for an exit character. Not as elegant as interrupt re-entry capability but may be my only solution.

    Thanks for your feedback.

    DEFINE OSC 40 ' 18F6628
    @ __CONFIG _CONFIG1H, _OSC_HSPLL_1H
    @ __CONFIG _CONFIG2H, _WDT_ON_2H & _WDTPS_512_2H
    ;@ __CONFIG _CONFIG3H, _PBADEN_OFF_3H
    @ __CONFIG _CONFIG4L, _LVP_OFF_4L & _XINST_OFF_4L
    '
    '************** UART Definitions ******************
    DEFINE HSER_SPBRG 42 '21=115200 42=57600 4=512000 @40MHz 2=921000
    DEFINE HSER_TXSTA 24h '%00100100 brgh high
    DEFINE HSER_RCSTA 90h '%10010000
    DEFINE HSER_BAUD 57600 '57600 '512000 '115200 '57600

    TRISC = %10010000

    '*********** Interrupt Definitions & Init ***********
    include "DT_INTS-18.bas"
    include "ReEnterPBP-18.bas"
    '
    TRUE CON 1
    FALSE CON 0
    SCAN VAR BYTE
    COMMAND VAR BYTE

    ASM
    INT_LIST macro ; IntSource, Label, Type, ResetFlag?
    INT_Handler RX_INT, _SERIALINT, PBP, yes
    endm
    INT_CREATE ; Creates the interrupt processor
    ENDASM

    @ INT_ENABLE RX_INT ; enable external (INT) interrupts

    MAIN:
    PAUSE 1
    GOTO MAIN

    BEGINSCAN: 'START SCANNING PIEZO1
    HSEROUT ["START",13,10] '0-65535
    WHILE SCAN = TRUE
    PAUSE 1
    WEND
    RETURN

    SERIALINT:
    HSERIN [COMMAND]
    IF COMMAND = "S" THEN
    SCAN = TRUE
    GOSUB BEGINSCAN
    ENDIF
    IF COMMAND ="F" THEN
    SCAN = FALSE
    HSEROUT ["STOP",13,10] '0-65535
    ENDIF
    @ INT_RETURN

  30. #710
    Join Date
    Aug 2010
    Location
    Chiang Mai University, Thailand
    Posts
    9

    Default Re: pbppi14e.lib errors

    I made the following change in the WHILE loop to allow me to exit. As mentioned, I use the receive register and poll it for the command. Does work, just not as elegant as I would prefer. Addition in red.

    Code:
    BEGINSCAN:  'START SCANNING PIEZO1
       '
        WHILE SCAN = TRUE
        PAUSE 1
           if RCREG1 = "F" THEN 
             SCAN = FALSE
             RETURN
           ENDIF   
        WEND
    RETURN

  31. #711
    Join Date
    Dec 2010
    Posts
    279

    Default Re: Instant Interrupts - Revisited

    My comment, and Darrel's comment both said the same thing - it is bad form to put a bunch of code in the interrupt routine. Using a GOSUB essentially puts the bulk of your code inside the routine at compile time.

    In order to not get stuck in an interrupt routine forever, typically you would stop servicing interrupts while in the routine. Either you shut them off and risk missing other interrupts, or you set a flag, and exit fast (having only executed a couple instructions). Your main program loop, then checks for the flag and if it is set, executes the GOSUB code. That can be the whole main program loop: (start: -> IF flag=1 THEN GOSUB do_stuff ELSE GOTO start) Then your routine just makes flag = 1 and exits.

    There are a number of reasons to not do it the way you are doing - when an interrupt occurs, everything going on in the processor is stuffed into memory and a new program is executed. If a second interrupt happens, then those memory locations get overwritten and your original point in the program is destroyed. It is not practical to allow many levels of saving - if you wish to do that, you'll have to write your own interrupt program. It won't be easy, because of the way the PIC does interrupts, and it is unlikely to be generic, or fast.
    But honestly, I have not encountered a situation where it's necessary to do that, and neither have you with the code you posted.

  32. #712
    Join Date
    Aug 2010
    Location
    Chiang Mai University, Thailand
    Posts
    9

    Default Re: Instant Interrupts - Revisited

    Quote Originally Posted by Charlie View Post
    My comment, and Darrel's comment both said the same thing - it is bad form to put a bunch of code in the interrupt routine. Using a GOSUB essentially puts the bulk of your code inside the routine at compile time.
    Thanks, your post cleared it up nicely for me. New strategy now as it is a complex program with dozens of subroutines all invoked via a command from the serial port. As I mentioned, most of my interrupt handler experience has been with large scale mini-computers with realtime OSes and interrupt reentry was the norm. See now the pic architecture & picbasic is limited but still doable with the flags mentioned. That code snippet was just one of dozens of similar subroutines.

    Thanks for the feedback.

  33. #713
    Join Date
    Sep 2006
    Location
    Venezuela - Caracas
    Posts
    48

    Default Re: Instant Interrupts - Revisited

    Darrel, exist in DTS RTTC INT ??

    i use pic 18F26J50 ..... i need control rtc interrupt

    ASM
    INT_LIST macro ; IntSource, Label, Type, ResetFlag?
    INT_Handler RX_??, _Relogio, PBP, yes
    endm
    INT_CREATE ; Creates the interrupt processor
    ENDASM

    @ INT_ENABLE ??_INT ; enable external (RTTC INT) interrupts
    ..: Don't worry, be happy :..

  34. #714
    Join Date
    Sep 2006
    Location
    Venezuela - Caracas
    Posts
    48

    Default Re: Instant Interrupts - Revisited

    RTTC is correct Darrel ?


    Code:
    '****************************************************************
    '*  Name    : DT_INTS-18.bas                                    *
    '*  Author  : Darrel Taylor                                     *
    '*  Notice  : Copyright (c) 2003                                *
    '*  Version : 3.3    MAR 24, 2008                               *
    '*  Date    : JUL 11, 2006                                      *
    '****************************************************************
    '*  Versions:                                                   *
    '*   3.3  : MAR 24, 2008                                        *
    '*           Corrects an initialization problem affecting the   *
    '*           first pass if CLEAR is not used                    *
    '*   3.2  : Aug 26, 2007                                        *
    '*           Update for PBP 2.50 using LONG's with PBPL         *
    '*           Added many new INT sources                         *
    '*   3.1  : JUL 18, 2006                                        *
    '*           Modified to handle smaller BANKA in the newer chips*
    '****************************************************************
    DISABLE DEBUG
    
    DEFINE  INTHAND       INT_ENTRY_H  ' Context saving for High Priority Ints
    DEFINE  INTLHAND      INT_ENTRY_L  ' Context saving for Low Priority Ints
    
    wsave       var byte  BANKA  SYSTEM   ' location for WREG
    ssave       var byte  BANK0  SYSTEM   ' location for STATUS register
    bsave       var byte  BANK0  SYSTEM   ' location for BSR register
    psaveUH     VAR BYTE  BANK0  SYSTEM   ' PCLATU Hi Pri.
    psaveUL     VAR BYTE  BANK0  SYSTEM   '        Lo Pri.
    psaveH      VAR BYTE  BANK0  SYSTEM   ' PCLATH Hi Pri.
    psaveL      VAR BYTE  BANK0  SYSTEM   '        Lo Pri.
    fsave0H     var WORD  BANK0  SYSTEM   ' locations for FSR registers
    fsave1H     var WORD  BANK0  SYSTEM
    fsave2H     var WORD  BANK0  SYSTEM
    fsave0L     var WORD  BANK0  SYSTEM   ' low priority FSR locations
    fsave1L     var WORD  BANK0  SYSTEM
    fsave2L     var WORD  BANK0  SYSTEM
    RetAddrH    VAR BYTE[3]  BANKA  SYSTEM  ' 21-bit return address Hi Pri.
    RetAddrL    VAR BYTE[3]  BANKA  SYSTEM  '                       Lo Pri.
    INT_Flags   VAR BYTE  BANKA  SYSTEM
      Serviced_H  VAR INT_Flags.0
      Serviced_L  VAR INT_Flags.1
      InHPint     VAR INT_Flags.2
      NoPriority  VAR INT_Flags.3
    
    INT_Flags = 0 
    
    goto  OVER_DT_INTS_18
    
    ASM
    ;____ Check for PBPL (PBP ver. 2.50 and above only)__________________________
    PBPLongs_Used = 0
      if (R1 - R0 == 4)
    PBPLongs_Used = 1
    ;    messg PBPL Used = 1
      endif
    
      nolist
    ;____ DEFINE available interrupt sources_____________________________________
    
      #define INT_INT   INTCON, INT0IF  ;-- INT External, 16F compatible
      #define INT0_INT  INTCON, INT0IF  ;-- INT0 External 
      #define INT1_INT  INTCON3,INT1IF  ;-- INT1 External 
      #define INT2_INT  INTCON3,INT2IF  ;-- INT2 External 
      #define INT3_INT  INTCON3,INT3IF  ;-- INT3 External 
      #define RBC_INT   INTCON, RBIF    ;-- RB Port Change 
      #define TMR0_INT  INTCON, TMR0IF  ;-- TMR0 Overflow  18F
      #define TMR1_INT  PIR1, TMR1IF    ;-- TMR1 Overflow 
      #define TMR2_INT  PIR1, TMR2IF    ;-- TMR2 to PR2 Match 
      #define TMR3_INT  PIR2, TMR3IF    ;-- TMR3 Overflow 
      #define TMR4_INT  PIR3, TMR4IF    ;-- TMR4 Overflow 
      #define TX_INT    PIR1, TXIF      ;-- USART Transmit 
      #define TX1_INT   PIR1, TX1IF     ;-- USART1 Transmit 
      #define TX2_INT   PIR3, TX2IF     ;-- USART2 Transmit 
      #define RX_INT    PIR1, RCIF      ;-- USART Receive 
      #define RX1_INT   PIR1, RC1IF     ;-- USART1 Receive 
      #define RX2_INT   PIR3, RC2IF     ;-- USART2 Receive 
      #define CMP_INT   PIR2, CMIF      ;-- Comparator 
      #define EE_INT    PIR2, EEIF      ;-- EEPROM/FLASH Write Operation 
      #define BUS_INT   PIR2, BCLIF     ;-- Bus Collision 
      #define LVD_INT   PIR2, LVDIF     ;-- Low Voltage Detect 
      #define HLVD_INT  PIR2, HLVDIF    ;-- High/Low Voltage Detect 
      #define PSP_INT   PIR1, PSPIF     ;-- Parallel Slave Port Read/Write 
      #define AD_INT    PIR1, ADIF      ;-- A/D Converter 
      #define SSP_INT   PIR1, SSPIF     ;-- Master Synchronous Serial Port 
      #define CCP1_INT  PIR1, CCP1IF    ;-- CCP1 
      #define CCP2_INT  PIR2, CCP2IF    ;-- CCP2 
      #define CCP3_INT  PIR3, CCP3IF    ;-- CCP3 
      #define CCP4_INT  PIR3, CCP4IF    ;-- CCP4 
      #define CCP5_INT  PIR3, CCP5IF    ;-- CCP5 
      #define OSC_INT   PIR2, OSCFIF    ;-- Oscillator Fail 
      
    ; -- Added for ver. 3.3 --
      #define RTTCC_INT PIR3, RTCCIF    ;-- RTTC
    
    ; -- Added for ver. 3.2 --
      #define SPP_INT   PIR1, SPPIF     ;-- Streaming Parallel Port Read/Write
      #define BUS1_INT  PIR2, BCL1IF    ;-- Bus 1 Collision 
      #define BUS2_INT  PIR3, BCL2IF    ;-- Bus 2 Collision
      #define ECCP1_INT PIR2, ECCP1IF   ;-- ECCP1
      #define LCD_INT   PIR3, LCDIF     ;-- LCD Driver
      #define PMP_INT   PIR1, PMPIF     ;-- Parallel Master Port
      #define SSP1_INT  PIR1, SSP1IF    ;-- Synchronous Serial Port 1
      #define SSP2_INT  PIR3, SSP2IF    ;-- Synchronous Serial Port 2
      #define TMR5_INT  PIR3, TMR5IF    ;-- Timer 5
      #define PT_INT    PIR3, PTIF      ;-- PWM Time Base
      #define IC1IF_INT  PIR3, IC1IF    ;-- Motion Feedback
      #define IC2QEIF_INT  PIR3, IC2QEIF  ;-- Motion Feedback
      #define IC3DRIF_INT  PIR3, IC3DRIF  ;-- Motion Feedback
    
    ;_____ Comparators __________________________________________________________
      #define CMP0_INT  PIR1, CMP0IF    ;-- Comparator 0 - 1230/1330 only
    
    CMPIFREG = PIR2                     ;-- Comparator 1
    CMPIEREG = PIE2
    CMPIPREG = IPR2
        ifdef C1IF                      ;     18F24K20  18F25K20  18F26K20
    CM1IFBIT = C1IF                     ;     18F44K20  18F45K20  18F46K20
        endif
        ifdef CM1IF
    CM1IFBIT = CM1IF                    ;     several J PICs
        endif
        ifdef CMP1IF
    CMPIFREG = PIR1                     ;     1230/1330 only
    CM1IFBIT = CMP1IF
    CMPIEREG = PIE1
    CMPIPREG = IPR1
        endif
    
        ifdef CM1IFBIT
           #define CMP1_INT  CMPIFREG, CM1IFBIT     
        endif
    
        ifdef C2IF                      ;-- Comparator 2
    CM2IFBIT = C2IF                     ;     18F24K20  18F25K20  18F26K20
        endif                           ;     18F44K20  18F45K20  18F46K20
        ifdef CM2IF
    CM2IFBIT = CM2IF                    ;     several J PICs
        endif    
        ifdef CMP2IF
    CM2IFBIT = CMP2IF                   ;     1230/1330 only
        endif    
    
        ifdef CM2IFBIT
          #define CMP2_INT  CMPIFREG, CM2IFBIT     
        endif
    
    ;_____ USB Module ___________________________________________________________
    
      #define USB_INT       PIR2, USBIF   ;-- USB Interrupt (funnel)
      #define USB_ACTV_INT  UIR,  ACTVIF  ;-- Bus Activity Detect 
      #define USB_ERR_INT   UIR,  UERRIF  ;-- USB Error Condition INT (funnel)
      #define USB_RST_INT   UIR,  URSTIF  ;-- USB Reset 
      #define USB_IDLE_INT  UIR,  IDLEIF  ;-- Idle Detect 
      #define USB_STALL_INT UIR,  STALLIF ;-- A STALL Handshake 
      #define USB_TRN_INT   UIR,  TRNIF   ;-- Transaction Complete 
      #define USB_SOF_INT   UIR,  SOFIF   ;-- START-OF-FRAME Token 
    
    ; -- USB Error Flags --
      #define USB_BTO_INT   UEIR, BTOEF   ;-- Bus Turnaround Time-out Error
      #define USB_BTS_INT   UEIR, BTSEF   ;-- Bit Stuff Error
      #define USB_CRC16_INT UEIR, CRC16EF ;-- CRC16 Failure
      #define USB_CRC5_INT  UEIR, CRC5EF  ;-- CRC5 Host Error
      #define USB_DFN8_INT  UEIR, DFN8EF  ;-- Data Field Size Error
      #define USB_PID_INT   UEIR, PIDEF   ;-- PID Check Failure
       
    ;_____ Ethernet Module ______________________________________________________
      #define ETH_INT       PIR2, ETHIF   ;-- Ethernet Module
      #define ETH_DMA_INT    EIR, DMAIF   ;-- DMA Interrupt
      #define ETH_LINK_INT   EIR, LINKIF  ;-- Link Status Change
      #define ETH_PKT_INT    EIR, PKTIF   ;-- Receive Packet Pending
      #define ETH_RXER_INT   EIR, RXERIF  ;-- Receive Error
      #define ETH_TXER_INT   EIR, TXERIF  ;-- Transmit Error
      #define ETH_TX_INT     EIR, TXIF    ;-- Transmit
    
    ;_____ CAN Module ___________________________________________________________
      #define CAN_ERR_INT    PIR3, ERRIF    ;-- CAN bus Error
      #define CAN_IRX_INT    PIR3, IRXIF    ;-- Invalid Received Message
      #define CAN_RXB0_INT   PIR3, RXB0IF   ;-* Receive Buffer 0      Mode 0
      #define CAN_FIFOWM_INT PIR3, FIFOWMIF ;-- FIFO Watermark        Mode 1, 2
      #define CAN_RXB1_INT   PIR3, RXB1IF   ;-* Receive Buffer 1      Mode 0
      #define CAN_RXBn_INT   PIR3, RXBnIF   ;-- Any Receive Buffer    Mode 1, 2
      #define CAN_TXB0_INT   PIR3, TXB0IF   ;-- Transmit Buffer 0
      #define CAN_TXB1_INT   PIR3, TXB1IF   ;-- Transmit Buffer 1
      #define CAN_TXB2_INT   PIR3, TXB2IF   ;-* Transmit Buffer 2     Mode 0
      #define CAN_TXBn_INT   PIR3, TXBnIF   ;-- Any Transmit Buffer   Mode 1, 2
      #define CAN_WAKE_INT   PIR3, WAKIF    ;-- CAN bus Activity Wake-up
    ENDASM
    
    asm
    ; -- macro --
    INT_Source  macro  IFR, IFB, IER, IEB, IPR, IPB
        if (IflagReg == IFR) && (IflagBit == IFB)  
      list  
    INT_Flag_Reg = IFR
    INT_Flag_Bit = IFB
    INT_Enable_Reg = IER
    INT_Enable_Bit = IEB
    INT_Priority_Reg = IPR
    INT_Priority_Bit = IPB
    Found = 1
        endif
      nolist  
        endm 
    endasm
    
    
    asm
    ;____________________________________________________________________________
    GetIntInfo  macro  IflagReg, IflagBit
      nolist
    INT_Flag_Reg = -1
    INT_Flag_Bit = -1
    INT_Enable_Reg = -1
    INT_Enable_Bit = -1
      ifdef  IPR1
    INT_Priority_Reg = -1
    INT_Priority_Bit = -1
      endif
    Found = 0
    
      ifdef INT0IF  ;----{ INT0 External Interrupt }----------[INTCON, INT0IF]---
          INT_Source  INTCON,INT0IF, INTCON,INT0IE, -1, -1
      endif
      ifdef INT1IF  ;----{ INT1 External Interrupt }---------[INTCON3, INT1IF]---
          INT_Source  INTCON3,INT1IF, INTCON3,INT1IE, INTCON3,INT1IP
      endif
      ifdef INT2IF  ;----{ INT2 External Interrupt }---------[INTCON3, INT2IF]---
          INT_Source  INTCON3,INT2IF, INTCON3,INT2IE, INTCON3,INT2IP
      endif
      ifdef INT3IF  ;----{ INT3 External Interrupt }---------[INTCON3, INT3IF]---
          INT_Source  INTCON3,INT3IF, INTCON3,INT3IE, INTCON2,INT3IP
      endif
      ifdef RBIF    ;----{ RB Port Change Interrupt }-----------[INTCON, RBIF]---
          INT_Source  INTCON,RBIF, INTCON, RBIE,INTCON2,RBIP
      endif
      ifdef TMR0IF  ;----{ TMR0 Overflow Interrupt }----------[INTCON, TMR0IF]---
          INT_Source  INTCON,TMR0IF, INTCON,TMR0IE, INTCON2,TMR0IP
      endif
      ifdef TMR1IF  ;----{ TMR1 Overflow Interrupt }------------[PIR1, TMR1IF]---
          INT_Source  PIR1,TMR1IF, PIE1,TMR1IE, IPR1,TMR1IP
      endif
      ifdef TMR2IF  ;----{ TMR2 to PR2 Match Interrupt }--------[PIR1, TMR2IF]---
          INT_Source  PIR1,TMR2IF, PIE1,TMR2IE, IPR1,TMR2IP
      endif
      ifdef TMR3IF  ;----{ TMR3 Overflow Interrupt }------------[PIR2, TMR3IF]---
          INT_Source  PIR2,TMR3IF, PIE2,TMR3IE, IPR2,TMR3IP
      endif
      ifdef TMR4IF  ;----{ TMR4 Overflow Interrupt }------------[PIR3, TMR4IF]---
          INT_Source  PIR3,TMR4IF, PIE3,TMR4IE, IPR3,TMR4IP
      endif
      ifndef TX1IF  ;----{ USART Transmit Interrupt }-------------[PIR1, TXIF]---
          ifdef TXIF
              INT_Source  PIR1,TXIF, PIE1,TXIE, IPR1,TXIP
          endif
      endif
      ifdef TX1IF   ;----{ USART1 Transmit Interrupt }-----------[PIR1, TX1IF]---
          INT_Source  PIR1,TX1IF, PIE1,TX1IE, IPR1,TX1IP
      endif
      ifdef TX2IF   ;----{ USART2 Transmit Interrupt }-----------[PIR3, TX2IF]---
          INT_Source  PIR3,TX2IF, PIE3,TX2IE, IPR3,TX2IP
      endif
      ifndef RC1IF  ;----{ USART Receive Interrupt }---------------[PIR1 RCIF]---  
        ifdef RCIF
            INT_Source  PIR1,RCIF, PIE1,RCIE, IPR1,RCIP
        endif
      endif
      ifdef RC1IF   ;----{ USART1 Receive Interrupt }------------[PIR1, RC1IF]---
          INT_Source  PIR1,RC1IF, PIE1,RC1IE, IPR1,RC1IP
      endif
      ifdef RC2IF   ;----{ USART2 Receive Interrupt }------------[PIR3, RC2IF]---
          INT_Source  PIR3,RC2IF, PIE3,RC2IE, IPR3,RC2IP
      endif
      ifdef CMIF    ;----{ Comparator Interrupt }-----------------[PIR2, CMIF]---
          INT_Source  PIR2,CMIF, PIE2,CMIE, IPR2,CMIP
      endif
      ifdef EEIF    ;----{ EEPROM/FLASH Write Operation Interrupt [PIR2, EEIF]---
          INT_Source  PIR2,EEIF, PIE2,EEIE, IPR2,EEIP
      endif
      ifdef BCLIF   ;----{ Bus Collision Interrupt }-------------[PIR2, BCLIF]---
          INT_Source  PIR2,BCLIF, PIE2,BCLIE, IPR2,BCLIP
      endif
      ifdef LVDIF   ;----{ Low Voltage Detect Interrupt }--------[PIR2, LVDIF]---
          INT_Source  PIR2,LVDIF, PIE2,LVDIE, IPR2,LVDIP
      endif
      ifdef HLVDIF  ;----{ High/Low Voltage Detect Interrupt }--[PIR2, HLVDIF]---
          INT_Source  PIR2,HLVDIF, PIE2,HLVDIE, IPR2,HLVDIP
      endif
      ifdef PSPIF   ;----{ Parallel Slave Port Interrupt }-------[PIR1, PSPIF]---
          INT_Source  PIR1,PSPIF, PIE1,PSPIE, IPR1,PSPIP
      endif
      ifdef ADIF    ;----{ A/D Converter Interrupt }--------------[PIR1, ADIF]---
          INT_Source  PIR1,ADIF, PIE1,ADIE, IPR1,ADIP
      endif
      ifdef SSPIF   ;----{ Synchronous Serial Port Interrupt }---[PIR1, SSPIF]---
          INT_Source  PIR1,SSPIF, PIE1,SSPIE, IPR1,SSPIP
      endif
      ifdef CCP1IF  ;----{ CCP1 Interrupt }---------------------[PIR1, CCP1IF]---
          INT_Source  PIR1,CCP1IF, PIE1,CCP1IE, IPR1,CCP1IP
      endif
      ifdef CCP2IF  ;----{ CCP2 Interrupt Flag }----------------[PIR2, CCP2IF]---
          INT_Source  PIR2,CCP2IF, PIE2,CCP2IE, IPR2,CCP2IP
      endif
      ifdef CCP3IF  ;----{ CCP3 Interrupt Flag }----------------[PIR3, CCP3IF]---
          INT_Source  PIR3,CCP3IF, PIE3,CCP3IE, IPR3,CCP3IP
      endif
      ifdef CCP4IF  ;----{ CCP4 Interrupt Flag }----------------[PIR3, CCP4IF]---
          INT_Source  PIR3,CCP4IF, PIE3,CCP4IE, IPR3,CCP4IP
      endif
      ifdef CCP5IF  ;----{ CCP5 Interrupt Flag }----------------[PIR3, CCP5IF]---
          INT_Source  PIR3,CCP5IF, PIE3,CCP5IE, IPR3,CCP5IP
      endif
      ifdef OSCFIF  ;----{ Osc Fail  Interrupt Flag }-----------[PIR2, OSCFIF]---
          INT_Source  PIR2,OSCFIF, PIE2,OSCFIE, IPR2,OSCFIP
      endif
    endasm
    
    asm
    ; -- Added for ver. 3.3 --
      ifdef RTCCIF  ;----{ RTTC }-------------------------------[PIR3, RTCCIF]---
          INT_Source  PIR3,RTCCIF, PIE3,RTCCIE, IPR3, RTTCIP
      endif
    endasm  
    
    asm
    ; -- Added for ver. 3.2 --
      ifdef SPPIF   ;----{ Streaming Parallel Port Read/Write }--[PIR1, SPPIF]---
          INT_Source  PIR1,SPPIF, PIE1,SPPIE, IPR1,SPPIP
      endif
      ifdef BCL1IF  ;----{ Bus 1 Collision }--------------------[PIR2, BCL1IF]---
          INT_Source  BUS1_INT, PIE2,BCL1IE, IPR2,BCL1IP
      endif
      ifdef BCL2IF  ;----{ Bus 2 Collision }--------------------[PIR3, BCL2IF]---
          INT_Source  BUS2_INT, PIE3,BCL2IE, IPR3,BCL2IP
      endif
      ifdef CMP0IF  ;----{ Comparator 0 }-----------------------[PIR1, CMP0IF]---
          INT_Source  CMP0_INT, PIE1,CMP0IE, IPR1,CMP0IP
      endif
      ifdef CM1IFBIT  ;--{ Comparator 1 }-----------------------------[varies]---
          INT_Source  CMP1_INT, CMPIEREG,CM1IFBIT, CMPIPREG,CM1IFBIT
      endif
      ifdef CM2IFBIT  ;--{ Comparator 2 }-----------------------------[varies]---
          INT_Source  CMP2_INT, CMPIEREG,CM2IFBIT, CMPIPREG,CM2IFBIT
      endif
      ifdef ECCP1IF  ;---{ ECCP1 }-----------------------------[PIR2, ECCP1IF]---
          INT_Source  ECCP1_INT, PIE2,ECCP1IE, IPR2,ECCP1IP
      endif
      ifdef LCDIF   ;----{ LCD Driver }--------------------------[PIR3, LCDIF]---
          INT_Source  LCD_INT, PIE3,LCDIE, IPR3,LCDIP
      endif
      ifdef PMPIF   ;----{ Parallel Master Port }----------------[PIR1, PMPIF]---
          INT_Source  PMP_INT, PIE1,PMPIE, IPR1,PMPIP
      endif
      ifdef SSP1IF  ;----{ Synchronous Serial Port 1 }----------[PIR1, SSP1IF]---
          INT_Source  SSP1_INT, PIE1,SSP1IE, IPR1,SSP1IP
      endif
      ifdef SSP2IF  ;----{ Synchronous Serial Port 2 }----------[PIR3, SSP2IF]---
          INT_Source  SSP2_INT, PIE3,SSP2IE, IPR3,SSP2IP
      endif
      ifdef TMR5IF  ;----{ Timer 5 }----------------------------[PIR3, TMR5IF]---
          INT_Source  TMR5_INT, PIE3,TMR5IE, IPR3,TMR5IP
      endif
      ifdef PTIF    ;----{ PWM Time Base }------------------------[PIR3, PTIF]---
          INT_Source  PT_INT, PIE3,PTIE, IPR3,PTIP
      endif
      ifdef IC1IF   ;----{ Motion Feedback IC1}------------------[PIR3, IC1IF]---
          INT_Source  IC1IF_INT, PIE3,IC1IE, IPR3,IC1IP
      endif
      ifdef IC2QEIF ;----{ Motion Feedback IC2QE}--------------[PIR3, IC2QEIF]---
          INT_Source  IC2QEIF_INT, PIE3,IC2QEIE, IPR3,IC2QEIP
      endif
      ifdef IC3DRIF ;----{ Motion Feedback IC3DR}--------------[PIR3, IC3DRIF]---
          INT_Source  IC3DRIF_INT, PIE3,IC3DRIE, IPR3,IC3DRIP
      endif
      
    ;  ifdef   ;----{  }-------------[, ]---
    ;      INT_Source  , ,, ,
    ;  endif
    endasm
    
    asm  ; -- USB sources --
      ifdef USBIF   ;----{ USB  Interrupt funnel }---------------[PIR2, USBIF]---
          INT_Source  PIR2,USBIF, PIE2,USBIE, IPR2,USBIP
              
                    ;----{ Bus Activity Detect }-----------------[UIR, ACTVIF]---
          INT_Source  USB_ACTV_INT, UIE,ACTVIE, _NoPriority
      
                    ;----{ USB Reset }---------------------------[UIR, URSTIF]---
          INT_Source  USB_RST_INT, UIE,URSTIE, _NoPriority
      
                    ;----{ Idle Detect }-------------------------[UIR, IDLEIF]---
          INT_Source  USB_IDLE_INT, UIE,IDLEIE, _NoPriority
      
                    ;----{ A STALL Handshake }------------------[UIR, STALLIF]---
          INT_Source  USB_STALL_INT, UIE,STALLIE, _NoPriority
      
                    ;----{ Transaction Complete }-----------------[UIR, TRNIF]---
          INT_Source  USB_TRN_INT, UIE,TRNIE, _NoPriority
      
                    ;----{ START-OF-FRAME Token }-----------------[UIR, SOFIF]---
          INT_Source  USB_SOF_INT, UIE,SOFIE, _NoPriority
      
    ; -- USB Error Flags --
                    ;----{ USB Error Condition Int funnel }------[UIR, UERRIF]---
          INT_Source  USB_ERR_INT, UIE,UERRIE, _NoPriority
       
                    ;----{ Bus Turnaround Time-out Error }-------[UEIR, BTOEF]---
          INT_Source  USB_BTO_INT, UEIE,BTOEE, _NoPriority
       
                    ;----{ Bit Stuff Error }---------------------[UEIR, BTSEF]---
          INT_Source  USB_BTS_INT, UEIE,BTSEE, _NoPriority
       
                    ;--{ CRC16 Failure }-----------------------[UEIR, CRC16EF]---
          INT_Source  USB_CRC16_INT, UEIE,CRC16EE, _NoPriority
       
                    ;---{ CRC5 Host Error }---------------------[UEIR, CRC5EF]---
          INT_Source  USB_CRC5_INT, UEIE,CRC5EE, _NoPriority
       
                    ;---{ Data Field Size Error }---------------[UEIR, DFN8EF]---
          INT_Source  USB_DFN8_INT, UEIE,DFN8EE, _NoPriority
       
                    ;----{ PID Check Failure }-------------------[UEIR, PIDEF]---
          INT_Source  USB_PID_INT, UEIE,PIDEE, _NoPriority
      endif
    endasm
    
    asm  ; -- Ethernet sources --
      ifdef ETHIF  ;----{ Ethernet Module }----------------------[PIR2, ETHIF]---
          INT_Source  ETH_INT, PIE2,ETHIE, IPR2,ETHIP
       
                   ;----{ DMA Interrupt }-------------------------[EIR, DMAIF]---
          INT_Source  ETH_DMA_INT, EIE,DMAIE, _NoPriority
       
                   ;----{ Link Status Change }-------------------[EIR, LINKIF]---
          INT_Source  ETH_LINK_INT, EIE,LINKIE, _NoPriority
       
                   ;----{ Receive Packet Pending }----------------[EIR, PKTIF]---
          INT_Source  ETH_PKT_INT, EIE,PKTIE, _NoPriority
       
                   ;----{ Receive Error }------------------------[EIR, RXERIF]---
          INT_Source  ETH_RXER_INT, EIE,RXERIE, _NoPriority
                  
                   ;----{ Transmit Error }-----------------------[EIR, TXERIF]---
          INT_Source  ETH_TXER_INT, EIE,TXERIE, _NoPriority
       
                   ;----{ Transmit }-------------------------------[EIR, TXIF]---
          INT_Source  ETH_TX_INT, EIE,TXIE, _NoPriority
      endif
    endasm
    
    asm  ; -- CAN Module --
      ifdef WAKIF  
                   ;----{ CAN bus Error }------------------------[PIR3, ERRIF]---
          INT_Source  CAN_ERR_INT, PIE3,ERRIE, IPR3,ERRIP
      
                   ;----{ Invalid Received Message }-------------[PIR3, IRXIF]---
          INT_Source  CAN_IRX_INT, PIE3,IRXIE, IPR3,IRXIP
      
                   ;----{ Receive Buffer 0 }------Mode 0--------[PIR3, RXB0IF]---
          INT_Source  CAN_RXB0_INT, PIE3,RXB0IE, IPR3,RXB0IP
                   ;----{ FIFO Watermark }--------Mode 1, 2---[PIR3, FIFOWMIF]---
          INT_Source  CAN_FIFOWM_INT, PIE3,FIFOWMIE, IPR3,FIFOWMIP
      
                   ;----{ Receive Buffer 1 }------Mode 0--------[PIR3, RXB1IF]---
          INT_Source  CAN_RXB1_INT, PIE3,RXB1IE, IPR3,RXB1IP
                   ;----{ Any Receive Buffer }----Mode 1, 2-----[PIR3, RXBnIF]---
          INT_Source  CAN_RXBn_INT, PIE3,RXBnIE, IPR3,RXBnIP
      
                   ;----{ Transmit Buffer 0 }-------------------[PIR3, TXB0IF]---
          INT_Source  CAN_TXB0_INT, PIE3,TXB0IE, IPR3,TXB0IP
      
                   ;----{ Transmit Buffer 1 }-------------------[PIR3, TXB1IF]---
          INT_Source  CAN_TXB1_INT, PIE3,TXB1IE, IPR3,TXB1IP
      
                   ;----{ Transmit Buffer 2 }-----Mode 0=-------[PIR3, TXB2IF]---
          INT_Source  CAN_TXB2_INT, PIE3,TXB2IE, IPR3,TXB2IP
                   ;----{ Any Transmit Buffer }---Mode 1, 2-----[PIR3, TXBnIF]---
          INT_Source  CAN_TXBn_INT, PIE3,TXBnIE, IPR3,TXBnIP
      
                   ;----{ CAN bus Activity Wake-up }-------------[PIR3, WAKIF]---
          INT_Source  CAN_WAKE_INT, PIE3,WAKIE, IPR3,WAKIP
      endif
      
      list
        endm
      list  
    ENDASM
    
    ;____[ if not using Low Priority INTS, create a dummy handler ]_______________
    ASM
        ifndef  USE_LOWPRIORITY
    INT_ENTRY_L
            retfie
        else
            if (USE_LOWPRIORITY != 1)
    INT_ENTRY_L
                retfie
            endif
        endif        
    ENDASM        
    
    ;_____________________________________________________________________________
    Asm
    asm = 0    ; Assembly language Interrupts
    ASM = 0
    Asm = 0
    pbp = 1    ; Basic language interrupts
    PBP = 1
    Pbp = 1
    YES = 1
    yes = 1
    Yes = 1
    NO = 0
    no = 0
    No = 0
    H equ 'H'  ; High Priority
    h equ 'H'
    L equ 'L'  ; Low Priority
    l equ 'L'
    
      nolist
      
    ;_____________________________________________________________________________
    SaveFSR  macro  F, Pr
      list
        if (F >= 0) && (F <= 2)
            if (Pr == H) || (Pr == L)
                movff    FSR#v(F)L, fsave#v(F)Pr
                movff    FSR#v(F)H, fsave#v(F)Pr + 1
              nolist
            else
                ERROR "SaveFSR - Invalid Priority"
            endif
        else
            ERROR "SaveFSR - Invalid FSR number"
        endif
        list
      endm
    ENDASM
    
    ;_____________________________________________________________________________
    Asm
    RestFSR  macro  F, Pr
      list
        if (F >= 0) && (F <= 2)
            if (Pr == H) || (Pr == L)
                movff    fsave#v(F)Pr , FSR#v(F)L
                movff    fsave#v(F)Pr + 1 , FSR#v(F)H 
              nolist
            else
                ERROR "RestFSR - Invalid Priority"
            endif
        else
            ERROR "RestFSR - Invalid FSR number"
        endif
        list
      endm
    ENDASM
    
    ;---[Stay compatible with the 14-bit version]---------------------------------
    Asm
    INT_FINISH_H   macro
      endm
    EndAsm
    
    ;---[Create the High Priority Interrupt Processor]----------------------------
    ASM
    INT_CREATE_H  macro
      local OverCREATE
        goto OverCREATE
    Priority = H    
    INT_ENTRY_H  
        movff   PCLATU, psaveUH
        movff   PCLATH, psaveH
        SaveFSR  0, H
        SaveFSR  1, H
        SaveFSR  2, H
        bsf      _InHPint, 0
    List_Start_H
        bcf      _Serviced_H, 0         ; Clear Serviced flag
        clrf  BSR
    PREV_BANK = 0
        ifdef INT_LIST_H
            INT_LIST_H                  ; Expand the users list of HP INT handlers
        else
            ifdef INT_LIST
                INT_LIST                ; Expand the 16F Compatible List
            else
                error "INT_CREATE_H - INT_LIST or INT_LIST_H not found"
            endif
        endif
        btfsc    _Serviced_H,0          ; if anything was serviced
        goto     List_Start_H           ; go around, and check again
    
        ifdef ReEnterHPused             ; was ReEnterPBP-18.bas included
            GetAddress21  INT_EXIT_H, RetAddrH
            L?GOTO   _RestorePBP_H      ; Restore PBP system Vars
        endif
    
    INT_EXIT_H
    PREV_BANK = 0
        bcf      _InHPint, 0
        RestFSR  0, H                   ; Restore FSR0, if it was saved?
        RestFSR  1, H                   ; Restore FSR1, if it was saved?
        RestFSR  2, H                   ; Restore FSR2, if it was saved?
        movff    psaveH, PCLATH
        movff    psaveUH, PCLATU
        retfie    FAST                  ; Return from Interrupt
    OverCREATE
        bsf   INTCON,GIE, 0             ; Enable High Priority Interrupts
        bsf   INTCON,PEIE, 0            ; Enable Peripheral Interrupts
      endm
    
    ;---[Stay compatible with the 14-bit version]---------------------------------
    INT_CREATE  macro
        INT_CREATE_H
      endm
    ENDASM
    
    ;---[Create the Low Priority Interrupt Processor]-----------------------------
    ASM
    INT_CREATE_L  macro
      local OverCREATE
        goto OverCREATE
        ifdef USE_LOWPRIORITY
            if (USE_LOWPRIORITY != 1)
           error "'DEFINE USE_LOWPRIORITY 1' required for Low Priority Interrupts"
            endif
        else
           error "'DEFINE USE_LOWPRIORITY 1' required for Low Priority Interrupts"
        endif
    Priority = L
    INT_ENTRY_L  
        movff   WREG, wsave             ; Wreg
        movff   STATUS, ssave           ; STATUS
        movff   BSR, bsave              ; BSR
        movff   PCLATU, psaveUL
        movff   PCLATH, psaveL
        SaveFSR  0, L                   ; FSR0
        SaveFSR  1, L                   ; FSR1
        SaveFSR  2, L                   ; FSR2
        bcf      _InHPint, 0    
    List_Start_L
      clrf  BSR
    PREV_BANK = 0
        bcf      _Serviced_L, 0
        ifdef INT_LIST_L
            INT_LIST_L                  ; Expand the users list of HP INT handlers
        else
            error "INT_CREATE_L - INT_LIST_L not defined, can not create"
        endif
        btfsc    _Serviced_L, 0         ; if anything was serviced
        goto     List_Start_L           ; go around, and check again
    
        ifdef ReEnterLPused             ; was ReEnterPBP-18LP.bas included
            GetAddress21  INT_EXIT_L, RetAddrL
            L?GOTO   _RestorePBP_L      ; Restore PBP system Vars
        endif
    
    INT_EXIT_L
    PREV_BANK = 0
        RestFSR  0, L                   ; Restore saved vars
        RestFSR  1, L
        RestFSR  2, L                
        movff   psaveUL, PCLATU
        movff   psaveL, PCLATH
        movff   bsave, BSR              ; BSR
        movff   wsave, WREG             ; WREG
        movff   ssave, STATUS           ; STATUS
        retfie                          ; Return from Interrupt
    OverCREATE
        bsf   RCON,IPEN, 0              ; Enable Interrupt Priorities
        bsf   INTCON,GIEL, 0            ; Enable Low Priority Interrupts
      endm
    ENDASM
    
    ASM
    ;---[Returns the Address of a Label as a Word]--(under 64K)------------------
    GetAddress macro Label, Wout
        CHK?RP Wout
        movlw low Label          ; get low byte
        movwf Wout
        movlw High Label         ; get high byte
        movwf Wout + 1
        endm
    
    ;---[Returns the Address of a Label as a 3 byte array]---(under/over 64k)-----
    GetAddress21 macro Label, Aout
        CHK?RP Aout
        movlw low Label          ; get low byte
        movwf Aout
        movlw high Label         ; get high byte
        movwf Aout + 1
        movlw upper Label        ; get upper byte
        movwf Aout + 2
        endm
    
    ;---[find correct bank for a PBP BIT variable]-------------------------------
    CHKRP?T  macro reg, bit
            CHK?RP  reg
        endm
        
    
    
    ;---[find Assigned Priority for specified INT Source]------------------------
    INT_Count = 0
    
    FindIntPriority  macro IntFlagReg, IntFlagBit
      local LoopCount
        nolist
    Pfound = 0
    LoopCount = 1
          while LoopCount <= INT_Count
              if  (IntFlagReg == PrList#v(LoopCount)R)
                 if (IntFlagBit == PrList#v(LoopCount)B)
      list
    Priority =  PrList#v(LoopCount)Priority
    Pfound = 1
                 endif
              endif
    LoopCount += 1
          endw
      endm  
    ENDASM
    
    ASM
    
    ;---[Add an Interrupt Source to the user's list of INT Handlers]--------------
    INT_Handler  macro  IntFlagReg, IntFlagBit, Label, Type, Reset
      list
        local AfterSave, AfterUser, NoInt
    INT_Count += 1
    PrList#v(INT_Count)R = IntFlagReg
    PrList#v(INT_Count)B = IntFlagBit
    PrList#v(INT_Count)Priority = Priority
            GetIntInfo   IntFlagReg, IntFlagBit
            if (Found == YES)
                btfss    INT_Enable_Reg, INT_Enable_Bit, 0  ; if INT is enabled
                goto   NoInt
                btfss    INT_Flag_Reg, INT_Flag_Bit, 0      ; and the Flag set?
                goto     NoInt
                if (Priority == H)
                    bsf      _Serviced_H, 0
                else
                    bsf      _Serviced_L, 0
                endif
                ifdef NO_CLRWDT
                    if  (NO_CLRWDT != 1)
                        CLRWDT
                    endif
                else
                    CLRWDT
                endif
                    
                if (Type == PBP)                         ; If INT handler is PBP
                  if (Priority == H)
                    ifdef ReEnterHPused
                        GetAddress21  AfterSave, RetAddrH  
                        L?GOTO  _SavePBP_H        ; Save PBP system Vars in HP INT
                    else
        error "ReEnterPBP-18 must be INCLUDEd to use High Priority PBP interrupts"
                    endif
                  else ; Priority = L
                    ifdef ReEnterLPused
                        GetAddress21  AfterSave, RetAddrL  
                        L?GOTO  _SavePBP_L        ; Save PBP system Vars in LP INT
                    else
       error "ReEnterPBP-18LP must be INCLUDEd to use Low Priority PBP interrupts"
                    endif
                  endif
                endif
    AfterSave
    PREV_BANK = 0
                if (Priority == H)
                      GetAddress21  AfterUser, RetAddrH  
                else ; Priority = L
                      GetAddress21  AfterUser, RetAddrL
                endif  
                L?GOTO   Label                        ; goto the users INT handler
                        
    AfterUser
    PREV_BANK = 0
                if (Reset == YES)                      ; reset flag (if specified)
                    bcf      INT_Flag_Reg, INT_Flag_Bit, 0 
                endif
            else
                error Interrupt Source (IntFlagReg,IntFlagBit) not found
            endif
    NoInt
        clrf  BSR
    PREV_BANK = 0
        endm
    ENDASM
    
    asm
    ;---[Returns from a "goto" subroutine]--(21-bit RetAddr? must be set first)---
    INT_RETURN  macro
      local Ret2LP, Ret2HP
          btfsc   _InHPint, 0
          goto    Ret2HP
    Ret2LP
          movff   RetAddrL + 2, PCLATU  ; Load PC buffers with return address
          movff   RetAddrL + 1, PCLATH
          movf    RetAddrL, W, 0
        clrf  BSR                    ; Set to BANK0 before returning
    PREV_BANK = 0                    ; Tell PBP about the BANK change
          movwf   PCL, 0             ; Go back to where we were
          
    Ret2HP       
          movff   RetAddrH + 2, PCLATU ; Load PC buffers with return address
          movff   RetAddrH + 1, PCLATH
          movf    RetAddrH, W, 0
        clrf  BSR                    ; Set to BANK0 before returning
    PREV_BANK = 0                    ; Tell PBP about the BANK change
          movwf   PCL, 0             ; Go back to where we were
        endm    
        
    ;---[Enable an interrupt source]----------------------------------------------
    INT_ENABLE  macro  IntFlagReg, IntFlagBit
          GetIntInfo   IntFlagReg, IntFlagBit
          if (Found == YES)
              FindIntPriority  IntFlagReg, IntFlagBit
              if (Pfound == 1)
                  if (INT_Priority_Reg != -1)
                      if (Priority == H)
                          bsf  INT_Priority_Reg, INT_Priority_Bit, 0
                      else
                          if (Priority == L)
                              bcf  INT_Priority_Reg, INT_Priority_Bit, 0
                          else
                              error "INT_ENABLE - Invalid Priority Specified"
                          endif
                      endif
                  else
                      if (Priority == L)
                          error "INT0_INT can NOT be assigned to Low Priority"
                      endif
                  endif
              else
                  error "INT_ENABLE - Priority State Not Found"
              endif
    ;          bcf     INT_Flag_Reg, INT_Flag_Bit, 0        ; clear the flag first 
              bsf     INT_Enable_Reg, INT_Enable_Bit, 0    ; enable the INT source  
          else
              error  "INT_ENABLE - Interrupt Source not found!"
          endif
        endm    
    
    ;---[Disable an interrupt source]---------------------------------------------
    INT_DISABLE  macro  IntFlagReg, IntFlagBit
          GetIntInfo   IntFlagReg, IntFlagBit
          if (Found == YES)
              bcf     INT_Enable_Reg, INT_Enable_Bit, 0   ; disable the INT source  
          else
              error "INT_DISABLE - Interrupt Source not found!"
          endif
        endm    
    
    ;---[Clear an interrupt Flag]-------------------------------------------------
    INT_CLEAR  macro  IntFlagReg, IntFlagBit
          GetIntInfo   IntFlagReg, IntFlagBit
          if (Found == YES)
              bcf     INT_Flag_Reg, INT_Flag_Bit, 0       ; clear the INT flag
          else
              error "INT_CLEAR -  Interrupt Source not found!"
          endif
        endm
    
    ENDASM
    
    ; ---[See if we need to save TBLPTR]------------------------------------------
    ASM
    Save_TBLPTR = 0
    
        ifdef SIN_USED
    Save_TBLPTR = 1
        endif
        ifdef DTMFOUT_USED
    Save_TBLPTR = 1
        endif
        ifdef SERDELAY_USED
    Save_TBLPTR = 1
        endif
        ifdef CONVBIT_USED
    Save_TBLPTR = 1
        endif
        ifdef ERASECODE_USED
    Save_TBLPTR = 1
        endif
        ifdef READCODE_USED
    Save_TBLPTR = 1
        endif
        ifdef WRITECODE_USED
    Save_TBLPTR = 1
        endif
        ifdef LOOKDOWN?BCLB
    Save_TBLPTR = 1
        endif
        ifdef LOOKDOWN?BCLT
    Save_TBLPTR = 1
        endif
        ifdef LOOKDOWN?BCLW
    Save_TBLPTR = 1
        endif
        ifdef LOOKDOWN?CCLB
    Save_TBLPTR = 1
        endif
        ifdef LOOKDOWN?CCLT
    Save_TBLPTR = 1
        endif
        ifdef LOOKDOWN?CCLW
    Save_TBLPTR = 1
        endif
        ifdef LOOKDOWN?WCLB
    Save_TBLPTR = 1
        endif
        ifdef LOOKDOWN?WCLT
    Save_TBLPTR = 1
        endif
        ifdef LOOKDOWN?WCLW
    Save_TBLPTR = 1
        endif
        ifdef LOOK2_USED 
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?BCLB
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?BCLT
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?BCLW
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?CCLB
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?CCLT
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?CCLW
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?TCLB
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?TCLT
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?TCLW
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?WCLB
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?WCLT
    Save_TBLPTR = 1
        endif
        ifdef LOOKUP?WCLW
    Save_TBLPTR = 1
        endif
    endasm
    
    OVER_DT_INTS_18:
    
    ENABLE DEBUG
    ..: Don't worry, be happy :..

  35. #715
    Join Date
    Nov 2007
    Location
    West Covina, CA
    Posts
    176

    Default Re: Instant Interrupts - Revisited

    Hi,
    You are on the right track. Darrel did add this interrupt:
    Code:
    ; -- Added for ver. 3.3 --
      #define RTTCC_INT PIR3, RTCCIF    ;-- RTTC
    Setup as:
    Code:
    INCLUDE "DT_INTS-18.bas"     ; Darrel Taylor's Base Interrupt System
    INCLUDE "ReEnterPBP-18.bas"  ; Include if using PBP interrupts
    ASM
    INT_LIST  macro ; IntSource,         Label,  Type, ResetFlag?
        INT_Handler   RTTCC_INT,      _Relogio,   PBP,  yes
        
        endm
        INT_CREATE             ; Creates the interrupt processor
    ENDASM
    
    @   INT_ENABLE  RTTCC_INT         ; Enable RTCC interrupt
    The RTCC interrupt flag is PIR3.0 found in Register 9-6 of the data sheet.
    Louie

  36. #716
    Join Date
    Nov 2007
    Location
    West Covina, CA
    Posts
    176

    Default Re: Instant Interrupts - Revisited

    I happen to also be working with the PIC18F24J50 for the RTCC and just tried DT's Interrupts for it and got an error. It may have already been addressed in this thread that has become short of a book but here it is:
    Symbol not previously defined (RTTCIP)
    Found a typo here:
    Code:
    asm
    ; -- Added for ver. 3.3 --
      ifdef RTCCIF  ;----{ RTTC }-------------------------------[PIR3, RTCCIF]---
          INT_Source  PIR3,RTCCIF, PIE3,RTCCIE, IPR3, RTTCIP
      endif
    endasm
    Data sheet Register 9-12 shows IPR3.0 labeled as RTCCIP, so I changed it to the following and error message gone.
    Code:
    asm
    ; -- Added for ver. 3.3 --
      ifdef RTCCIF  ;----{ RTTC }-------------------------------[PIR3, RTCCIF]---
          INT_Source  PIR3,RTCCIF, PIE3,RTCCIE, IPR3, RTCCIP
      endif
    endasm
    By the way, many thanks to Darrel for this extremely fine piece of work that looks like it took a lot of time and doing then to just give it to everyone.
    Louie

  37. #717
    Join Date
    Jan 2014
    Posts
    27

    Default Re: Instant Interrupts - Revisited

    hi to all,
    I'm a beginner , so I need your help , please! .I want to play with 3 LEDs with pwm control . For begin I tried to compile a example from Darrel Taylor's page : http://www.darreltaylor.com/DT_INTS-14/SPWM.html .
    the compilation was succesfull for 18F's and work perfectly.
    I use MCS 3.0.7.0 and MAPSM v5.42 compiler . I want to compile the sorce code for 12F683 and I have this error:

    Error[101] C:\LUCRU\TEST_SPWM_INT.ASM 238 : ERROR: (wsave variable not found,)
    Error[101] C:\LUCRU\TEST_SPWM_INT.ASM 204 : ERROR: (" Add:" wsave VAR BYTE $20 SYSTEM)
    Error[101] C:\LUCRU\TEST_SPWM_INT.ASM 259 : ERROR: (Chip has RAM in BANK1, but wsave1 was not found.)
    Error[101] C:\LUCRU\TEST_SPWM_INT.ASM 211 : ERROR: (" Add:" wsave1 VAR BYTE $A0 SYSTEM)


    I use this code :

    '************************************************* ***************
    '* Name : Test_SPWM.pbp *
    '* Author : Darrel Taylor *
    '* Date : 9/30/2006 *
    '* Version : 1.0 *
    '* Notes : *
    '* : *
    '************************************************* ***************
    ; Initialize your hardware first

    DEFINE OSC 20
    CLEAR

    INCLUDE "..\DT_INTS-14.bas" ; Base Interrupt System
    INCLUDE "SPWM_INT.bas" ; Software PWM module

    DEFINE SPWM_FREQ 40 ; SPWM Frequency
    DEFINE SPWM_RES 256 ; SPWM Resolution

    DutyVars VAR BYTE[3] ; DutyCycle Variables
    DutyVar1 VAR DutyVars[0] ; group them in an array for easy access
    DutyVar2 VAR DutyVars[1] ; with FOR loops etc.
    DutyVar3 VAR DutyVars[2]

    ASM
    SPWM_LIST macro ; Define PIN's to use for SPWM
    SPWM_PIN GPIO, 0, _DutyVar1
    SPWM_PIN GPIO, 1, _DutyVar2
    SPWM_PIN GPIO, 2, _DutyVar3
    endm
    SPWM_INIT SPWM_LIST ; Initialize the Pins
    ENDASM

    ASM
    INT_LIST macro ; IntSource, Label, Type, ResetFlag?
    INT_Handler TMR1_INT, SPWMhandler, ASM, yes
    endm
    INT_CREATE ; Creates the interrupt processor
    ENDASM

    @ INT_ENABLE TMR1_INT ; enable Timer 1 interrupts

    ;_________________________________________________ ____________________________

    RandVar VAR WORD : RandVar = 12345
    LoopCount VAR WORD

    Main: ; Simple Demo to fade/flash some LED's
    DutyVar1 = 5 ; Start with 3 LED's at different
    DutyVar2 = 50 ; brightness
    DutyVar3 = 150
    pause 3000

    FOR LoopCount = 1 to 4 ; Reapeat 4 times
    for DutyVar1 = 0 to 150 ; Fade LED1 UP
    pause 10
    RANDOM RandVar
    DutyVar3 = RandVar & $3F ; Give LED3 a random dutycycle
    next DutyVar1

    for DutyVar1 = 150 to 0 STEP -1 ; Fade LED1 Down
    pause 10
    RANDOM RandVar
    DutyVar2 = RandVar & $3F ; Give LED2 a random dutycycle
    next DutyVar1
    NEXT LoopCount
    GOTO Main




    Can somedody help me to finish my ideea ?

    1000xthx

  38. #718
    Join Date
    Nov 2003
    Location
    Greece
    Posts
    2,268

    Default Re: Instant Interrupts - Revisited

    The answer is in the Error messages:

    Quote Originally Posted by midali View Post
    hi to all,
    Error[101] C:\LUCRU\TEST_SPWM_INT.ASM 238 : ERROR: (wsave variable not found,)
    Error[101] C:\LUCRU\TEST_SPWM_INT.ASM 204 : ERROR: (" Add:" wsave VAR BYTE $20 SYSTEM)
    Error[101] C:\LUCRU\TEST_SPWM_INT.ASM 259 : ERROR: (Chip has RAM in BANK1, but wsave1 was not found.)
    Error[101] C:\LUCRU\TEST_SPWM_INT.ASM 211 : ERROR: (" Add:" wsave1 VAR BYTE $A0 SYSTEM)
    It says, " Add:" wsave VAR BYTE $20 SYSTEM
    and also " Add:" wsave1 VAR BYTE $A0 SYSTEM

    So, your code might look like this now:

    Code:
    '****************************************************************
    '*  Name    : Test_SPWM.pbp                                     *
    '*  Author  : Darrel Taylor                                     *
    '*  Date    : 9/30/2006                                         *
    '*  Version : 1.0                                               *
    '*  Notes   :                                                   *
    '*          :                                                   *
    '****************************************************************
    ; Initialize your hardware first
    
    DEFINE OSC 20
    CLEAR
    
    INCLUDE "..\DT_INTS-14.bas"         ; Base Interrupt System
    INCLUDE "SPWM_INT.bas"              ; Software PWM module
    
    wsave     VAR BYTE $20 SYSTEM
    wsave1    VAR BYTE $A0 SYSTEM
    
    DEFINE SPWM_FREQ  40                ; SPWM Frequency
    DEFINE SPWM_RES   256               ; SPWM Resolution
    
    DutyVars   VAR BYTE[3]              ; DutyCycle Variables
      DutyVar1 VAR DutyVars[0]          ; group them in an array for easy access
      DutyVar2 VAR DutyVars[1]          ; with FOR loops etc.
      DutyVar3 VAR DutyVars[2]
    
    ASM
    SPWM_LIST  macro                    ; Define PIN's to use for SPWM
         SPWM_PIN  GPIO, 0, _DutyVar1
         SPWM_PIN  GPIO, 1, _DutyVar2
         SPWM_PIN  GPIO, 2, _DutyVar3
      endm
      SPWM_INIT  SPWM_LIST              ; Initialize the Pins
    ENDASM
    
    ASM
    INT_LIST  macro    ; IntSource,        Label,  Type, ResetFlag?
            INT_Handler   TMR1_INT,  SPWMhandler,  ASM,  yes
        endm
        INT_CREATE                      ; Creates the interrupt processor
    ENDASM
    
    @ INT_ENABLE  TMR1_INT              ; enable Timer 1 interrupts
    
    ;_____________________________________________________________________________
    
    RandVar   VAR WORD : RandVar = 12345
    LoopCount VAR WORD
    
    Main:                               ; Simple Demo to fade/flash some LED's
        DutyVar1 = 5                        ; Start with 3 LED's at different
        DutyVar2 = 50                       ; brightness
        DutyVar3 = 150
        pause 3000
         
        FOR LoopCount = 1 to 4              ; Reapeat 4 times
            for DutyVar1 = 0 to 150         ; Fade LED1 UP
                pause 10
                RANDOM  RandVar             
                DutyVar3 = RandVar & $3F          ; Give LED3 a random dutycycle
            next DutyVar1
             
            for DutyVar1 = 150 to 0 STEP -1 ; Fade LED1 Down
                pause 10
                RANDOM  RandVar
                DutyVar2 = RandVar & $3F         ; Give LED2 a random dutycycle
            next DutyVar1
        NEXT LoopCount     
    GOTO Main
    Ioannis

  39. #719
    Join Date
    Jan 2014
    Posts
    27

    Default Re: Instant Interrupts - Revisited

    1000 X Ioannis ! Now its ok !

  40. #720
    Join Date
    Jan 2014
    Posts
    27

    Default Re: Instant Interrupts - Revisited

    Hi,
    in the last four days I spend my time with play of this code, but now I'm need to your help. I repeat, im begginer and at this time I dont know how work the intrerrupts.
    The Darrel Tylor code blink 3 leds at different intensity. I want to turn on 3 leds in background at different intensity without blinking. i tried this code, but leds blinks....where I'm wrong?


    Main: ; Simple Demo to fade/flash some LED's
    DutyVar1 = 5 ; Start with 3 LED's at different
    DutyVar2 = 50 ; brightness
    DutyVar3 = 150
    GOTO Main

Similar Threads

  1. Clock using Instant Interrupts
    By PICpocket in forum mel PIC BASIC Pro
    Replies: 3
    Last Post: - 16th February 2009, 22:43
  2. DT instant interrupts with mister_e keypad
    By Tomexx in forum mel PIC BASIC Pro
    Replies: 5
    Last Post: - 26th November 2008, 21:02
  3. DT's Instant Interrupts trouble
    By Tomexx in forum mel PIC BASIC Pro
    Replies: 7
    Last Post: - 24th November 2008, 21:48
  4. Keypad and DT's Instant Interrupts
    By Homerclese in forum General
    Replies: 11
    Last Post: - 27th April 2007, 06:32
  5. Replies: 1
    Last Post: - 1st November 2006, 04:11

Members who have read this thread : 139

You do not have permission to view the list of names.

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts