My code for ADC button handling, it works, but can it be slimmed down?

[CuriousOne]

Hello,
This is my code for handling two buttons connected to ADC input.
It works fine, and what was most important, it prevents repeated key action -
user has to release the button and press it again, to call needed action again.
However, there are quite a lot of variables, and their number will double with
more buttons being added.
So maybe there is a way to make it simpler, while still maintaining
"do not repeat action" functionality?

menu: 'main loop for button handling
adcin 1, adcval   'read keys
if adcval=255 then n1=0: n2=0: left=0: right=0  'if no key, then reset both button variables
if adcval<10 then left=left+1 'detect button presses
if adcval>100 and adcval <130 then right=right+1 'detect button presses
if left>100 and n1=0 then 'if button pressed enough and it was not pressed before
left=0
n1=1
gosub action1 'button 1 tasks
endif
if right>100 and n2=0 then 'if button pressed enough and it was not pressed before
right=0
n2=1
gosub action2 'button 2 tasks
endif  
pause 1 'input delay
goto menu

[mpgmike]

adcin 1, adcval   'read keys
SELECT CASE adcval
  CASE < 10 : left=left+1 'detect button presses
  CASE < 100
@ NOP
  CASE < 130 : right=right+1 'detect button presses
END SELECT

You might try the SELECT CASE method of parsing through. The above snippet should give you an idea.[/FONT]

[CuriousOne]

Thanks!
My main concern is number of variables needed...

[richard]

code snippets do not provide any where near the required info to provide a meaningful answer, not even one var definition is even provided

for a meaningful answer
1 how often is routine called
2 is it called on a regular timed basis
3 how responsive does it need to be

the minimum key data necessary would be a count to detect a debounced press a bit to indicate a new press detected and a bit to indicate
the press has been acknowledged and acted on provided the right conditions exist

[CuriousOne]

1. At least 10 times per second.
2. Yes
3. As responsive as any other device, where user presses key and expects immediate feedback.

[richard]

1. At least 10 times per second
if right>100

so button has to held for ten seconds till you get a response ?

As responsive as any other device

not in my book, i doubt the thing is working after 300mS

2. Yes

like how regular how often really

[Acetronics2]

Why not use the genuine BUTTON command ?????????????????

of course, needs some "brainwork" and practise - and of course at least " read that f...... manual " ... "

but the result is worth the effort ...

" Just my two cents " ...

Alain

[CuriousOne]

Read 1st post 1st

This is ADC input.

[Acetronics2]

Read 1st post 1st

This is ADC input.

ADC for ONLY two buttons and " immediate response " ( sic ) ??? ...

if it's your choice ... go on ! ( ) ...

Alain

[richard]

adc key reading is a good tried and tested technique and can be very responsive, the question here is can it be done
using less memory. the answer is yes of course, if done in a methodical way.
c1 has opted not to discuss or elaborate on his implementation in any meaningful way. end of story

[CuriousOne]

This is just an example for 2 buttons
for 20 buttons there should be 40 variables
I wanted to avoid that
this is why I asked