Leds on/off

Closed Thread
Results 1 to 17 of 17

Thread: Leds on/off

  1. - 29th August 2009, 02:07 #1
    Leonardo's Avatar
    Leonardo
    Leonardo is offline Member
    Join Date
    Aug 2005
    Posts
    144

    Default Leds on/off

    Hello forum friends,

    I have 4 buttons connected to PORTB and 4 LEDs to PORTB, I turn on and off with the same button for the LED but independently, with this code does not work properly any suggestions?.

    Code:
    start:
IF PORTB.0=0 then
    HIGH PORTB.4
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF
    
IF PORTB.0=0 then
    LOW PORTB.4
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF
    
    
iF PORTB.1=0 then
    HIGH PORTB.5
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF
    
IF PORTB.1=0 then
    LOW PORTB.5
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF
    
iF PORTB.2=0 then
    HIGH PORTB.6
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF
    
IF PORTB.2=0 then
    LOW PORTB.6
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF
    
iF PORTB.3=0 then
    HIGH PORTB.7
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF
    
IF PORTB.3=0 then
    LOW PORTB.7
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF
    
      
goto start
    Attached Images Attached Images  
  2. - 29th August 2009, 02:54 #2
    mackrackit's Avatar
    mackrackit
    mackrackit is offline SuperMod
    Join Date
    Nov 2003
    Location
    Wellton, U.S.A.
    Posts
    5,924

    Did you find this post helpful? Yes | No

    Default

    How do you have the TRIS set for this?
    Dave
    Always wear safety glasses while programming.
  3. - 29th August 2009, 03:03 #3
    Leonardo's Avatar
    Leonardo
    Leonardo is offline Member
    Join Date
    Aug 2005
    Posts
    144

    Did you find this post helpful? Yes | No

    Default

    Quote Originally Posted by mackrackit View Post
    How do you have the TRIS set for this?
    TRIS Series I have not configured but the code does not work well.
  4. - 29th August 2009, 03:10 #4
    mackrackit's Avatar
    mackrackit
    mackrackit is offline SuperMod
    Join Date
    Nov 2003
    Location
    Wellton, U.S.A.
    Posts
    5,924

    Did you find this post helpful? Yes | No

    Default

    You will need to set the TRIS for the port. That will tell what pins are input or out puts.
    Try adding this near the top of your code.
    Code:
    TRISB = %00001111
    That will make PORTB 0 to 3 an input and 4 to 7 an output.
    Dave
    Always wear safety glasses while programming.
  5. - 29th August 2009, 03:21 #5
    Leonardo's Avatar
    Leonardo
    Leonardo is offline Member
    Join Date
    Aug 2005
    Posts
    144

    Did you find this post helpful? Yes | No

    Default

    Hello mackrackit,

    I have added TRISB =% 00001111 but as usual the code does not work well.

    Thanks
    Leonardo


    Quote Originally Posted by mackrackit View Post
    You will need to set the TRIS for the port. That will tell what pins are input or out puts.
    Try adding this near the top of your code.
    Code:
    TRISB = %00001111
    That will make PORTB 0 to 3 an input and 4 to 7 an output.
  6. - 29th August 2009, 03:34 #6
    mackrackit's Avatar
    mackrackit
    mackrackit is offline SuperMod
    Join Date
    Nov 2003
    Location
    Wellton, U.S.A.
    Posts
    5,924

    Did you find this post helpful? Yes | No

    Default

    Can you post the whole code and exactly what is it doing or not doing?
    Dave
    Always wear safety glasses while programming.
  7. - 29th August 2009, 04:15 #7
    Archangel's Avatar
    Archangel
    Archangel is offline SuperMod
    Join Date
    Aug 2006
    Location
    Look, behind you.
    Posts
    2,818

    Did you find this post helpful? Yes | No

    Default

    Code:
    iF PORTB.1=0 then
    HIGH PORTB.5
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF
    Why not use Toggle ?
    Code:
    IF PORTB.1=0 then
    toggle PORTB.5
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF
    Do not know what you are doing with PORTB.0 or why it is always low in each
    if then loop . . . or is that a copy paste error, and is low only in the first loop ?
    maybe should be PortB.1 in this loop ? Select case could tidy this up even more . . .
    If you do not believe in MAGIC, Consider how currency has value simply by printing it, and is then traded for real assets.
    .
    Gold is the money of kings, silver is the money of gentlemen, barter is the money of peasants - but debt is the money of slaves
    .
    There simply is no "Happy Spam" If you do it you will disappear from this forum.
  8. - 29th August 2009, 08:01 #8
    sayzer's Avatar
    sayzer
    sayzer is offline SuperMod
    Join Date
    Jan 2006
    Location
    Istanbul
    Posts
    1,185

    Did you find this post helpful? Yes | No

    Default

    If you are simulating it as seen in your schematic, then the simulator might be giving false simulation because you do not have resistors on the leds.

    I say this is 98% possibility of the error you are getting.

    ------------------
    "If the Earth were a single state, Istanbul would be its capital." Napoleon Bonaparte
  9. - 29th August 2009, 09:13 #9
    Acetronics2's Avatar
    Acetronics2
    Acetronics2 is offline Fanatical Contributor
    Join Date
    May 2004
    Location
    NW France
    Posts
    3,614

    Did you find this post helpful? Yes | No

    Talking the car without engine ...

    Hi,

    I do not remember the 16F84 had an internal oscillator ...

    none aboard the ( censored ) simulation ...

    But I'm just getting 53 ...

    Alain

    PS: Ahhhhh ... Da Vinci Code !!!!
    ************************************************** ***********************
    Why insist on using 32 Bits when you're not even able to deal with the first 8 ones ??? ehhhhhh ...
    ************************************************** ***********************
    IF there is the word "Problem" in your question ...
    certainly the answer is " RTFM " or " RTFDataSheet " !!!
    *****************************************
  10. - 29th August 2009, 09:48 #10
    phoenix_1's Avatar
    phoenix_1
    phoenix_1 is offline Member
    Join Date
    May 2007
    Location
    Republic Serbia
    Posts
    105

    Did you find this post helpful? Yes | No

    Default

    Quote Originally Posted by Acetronics View Post
    Hi,

    I do not remember the 16F84 had an internal oscillator ...

    none aboard the ( censored ) simulation ...

    But I'm just getting 53 ...

    Alain

    PS: Ahhhhh ... Da Vinci Code !!!!
    16F84 and 16F84A do not have internal OSC...
    [email protected]

    YU7JN
  11. - 29th August 2009, 09:54 #11
    sayzer's Avatar
    sayzer
    sayzer is offline SuperMod
    Join Date
    Jan 2006
    Location
    Istanbul
    Posts
    1,185

    Did you find this post helpful? Yes | No

    Default

    Quote Originally Posted by phoenix_1 View Post
    16F84 and 16F84A do not have internal OSC...
    Quote Originally Posted by Acetronics View Post
    Hi,

    I do not remember the 16F84 had an internal oscillator ...

    none aboard the ( censored ) simulation ...

    But I'm just getting 53 ...

    Alain

    PS: Ahhhhh ... Da Vinci Code !!!!

    On his simulator, it is not required to connect crystal or resonator etc.
    It will run normally as if those were connected.

    ---------------------------
    "If the Earth were a single state, Istanbul would be its capital." Napoleon Bonaparte
  12. - 29th August 2009, 10:02 #12
    Acetronics2's Avatar
    Acetronics2
    Acetronics2 is offline Fanatical Contributor
    Join Date
    May 2004
    Location
    NW France
    Posts
    3,614

    Did you find this post helpful? Yes | No

    Default

    Hi, Sayzer

    I do not want to use sims ... lol

    BTW :


    ...

    IF PORTB.0=0 then
    HIGH PORTB.4
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF

    IF PORTB.0=0 then
    LOW PORTB.4
    WHILE PORTB.0=0 : Wend : pause 50
    ENDIF

    ...
    This kind of structure can't work properly ... as the second part never can be reached !!! ( or toggling button in less than 1µs ... )

    Button state AND its corresponding output state must be tested at the same time ... to take the appropriate action.

    Alain
    Last edited by Acetronics2; - 29th August 2009 at 10:09.
    ************************************************** ***********************
    Why insist on using 32 Bits when you're not even able to deal with the first 8 ones ??? ehhhhhh ...
    ************************************************** ***********************
    IF there is the word "Problem" in your question ...
    certainly the answer is " RTFM " or " RTFDataSheet " !!!
    *****************************************
  13. - 29th August 2009, 12:34 #13
    Acetronics2's Avatar
    Acetronics2
    Acetronics2 is offline Fanatical Contributor
    Join Date
    May 2004
    Location
    NW France
    Posts
    3,614

    Did you find this post helpful? Yes | No

    Talking

    Sorry ...

    or toggling button in less than 1µs ...
    was not 1µs but 50 ms ...

    but result is the same !!!

    Alain
    ************************************************** ***********************
    Why insist on using 32 Bits when you're not even able to deal with the first 8 ones ??? ehhhhhh ...
    ************************************************** ***********************
    IF there is the word "Problem" in your question ...
    certainly the answer is " RTFM " or " RTFDataSheet " !!!
    *****************************************
  14. - 31st August 2009, 10:34 #14
    chatchai's Avatar
    chatchai Guest

    Did you find this post helpful? Yes | No

    Red face I am speek Thai and my english very bad... but my example..

    ' Test I/O Ports Input and Output

    SW1 var PORTB.0
    SW2 var PORTB.1
    SW3 var PORTB.2
    SW4 var PORTB.3

    LED1 VAR PORTD.0
    LED2 VAR PORTD.1
    LED3 VAR PORTD.2
    LED4 VAR PORTD.3

    i var byte

    DEFINE OSC 48


    '------- Initial IO Ports -------


    TRISB = $FF
    TRISD = 0

    CMCON = 0
    ADCON1 = 7

    '------- Main Function -------
    main:
    LED1 = SW1
    LED2 = SW2
    LED3 = SW3
    LED4 = SW4

    goto main
  15. - 31st August 2009, 11:37 #15
    Fredrick's Avatar
    Fredrick
    Fredrick is offline Member
    Join Date
    Jan 2008
    Location
    Sweden
    Posts
    187

    Did you find this post helpful? Yes | No

    Default

    Try this

    Code:
    start:
IF PORTB.0=0 then
    toggle PORTB.4
    WHILE PORTB.0=0 : Wend : pause 50
ENDIF
    
    
IF PORTB.1=0 then
    toggle PORTB.5
    WHILE PORTB.1=0 : Wend : pause 50
ENDIF
        
IF PORTB.2=0 then
    toggle PORTB.6
    WHILE PORTB.2=0 : Wend : pause 50
ENDIF
        
IF PORTB.3=0 then
    toggle PORTB.7
    WHILE PORTa.3=0 : Wend : pause 50
ENDIF
    
      
goto start
  16. - 31st August 2009, 12:13 #16
    aratti's Avatar
    aratti
    aratti is offline Senior Member
    Join Date
    May 2008
    Location
    Italy
    Posts
    825

    Did you find this post helpful? Yes | No

    Default

    Place a 330 ohms in series to each leds (as suggested in previuos post), and use Toggle command (as suggested in previuos post).

    Code:
    start:
Pause 50
IF PORTB.0=0 then
    Toggle PORTB.4       
    ENDIF
    
IF PORTB.1=0 then
    Toggle PORTB.5     
    ENDIF
    
IF PORTB.2=0 then
    Toggle PORTB.6     
     ENDIF
    
IF PORTB.3=0 then
    Toggle PORTB.7    
     ENDIF

HoldLoop:
If PortB & %00001111 != 15 then HoldLoop

goto start


    Al.
    Last edited by aratti; - 31st August 2009 at 12:25.
    All progress began with an idea
  17. - 2nd September 2009, 21:36 #17
    Leonardo's Avatar
    Leonardo
    Leonardo is offline Member
    Join Date
    Aug 2005
    Posts
    144

    Did you find this post helpful? Yes | No

    Default

    Thanks Aratti

    Quote Originally Posted by aratti View Post
    Place a 330 ohms in series to each leds (as suggested in previuos post), and use Toggle command (as suggested in previuos post).

    Code:
    start:
Pause 50
IF PORTB.0=0 then
    Toggle PORTB.4       
    ENDIF
    
IF PORTB.1=0 then
    Toggle PORTB.5     
    ENDIF
    
IF PORTB.2=0 then
    Toggle PORTB.6     
     ENDIF
    
IF PORTB.3=0 then
    Toggle PORTB.7    
     ENDIF

HoldLoop:
If PortB & %00001111 != 15 then HoldLoop

goto start


    Al.
« Previous Thread | Next Thread »

Similar Threads

  1. Run a string of LEDs from the mains
    By The Master in forum Off Topic
    Replies: 30
    Last Post: - 1st October 2009, 18:55
  2. Short distance Light beam control (10cm) - what is best to use in On/Off mode?
    By flotulopex in forum mel PIC BASIC Pro
    Replies: 14
    Last Post: - 26th April 2007, 15:12
  3. Using LEDs as light sensors
    By skimask in forum Code Examples
    Replies: 3
    Last Post: - 30th December 2006, 22:19
  4. controlling leds with the switches
    By ilteris in forum mel PIC BASIC Pro
    Replies: 2
    Last Post: - 12th October 2005, 21:02
  5. Blinking effect during shifting out to LEDs
    By Demon in forum General
    Replies: 5
    Last Post: - 16th February 2005, 11:57

Members who have read this thread : 1

You do not have permission to view the list of names.

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts

Forum Rules