Cleaning up code

Printable View

- 2nd December 2009, 00:50
Tobias

Cleaning up code

Using a 16F877A one part of the code is the following. It uses up alot of code space. Is there an alternative?

Code:

Read_Data: Read 0, Stage1tOn.LowByte REad 1, Stage1TOn.HighByte Read 2, Stage1tOFF.LowByte REad 3, Stage1TOFF.HighByte Read 4, Stage1ROn.LowByte REad 5, Stage1RON.HighByte Read 6, Stage1ROFF.LowByte REad 7, Stage1ROFF.HighByte Read 8, Stage2tOn.LowByte REad 9, Stage2TOn.HighByte Read 10, Stage2tOFF.LowByte REad 11, Stage2TOFF.HighByte Read 12, Stage2ROn.LowByte REad 13, Stage2RON.HighByte Read 14, Stage2ROFF.LowByte REad 15, Stage2ROFF.HighByte Read 16, Stage3tOn.LowByte REad 17, Stage3TOn.HighByte Read 18, Stage3tOFF.LowByte REad 19, Stage3TOFF.HighByte Read 20, Stage3ROn.LowByte REad 21, Stage3RON.HighByte Read 22, Stage3ROFF.LowByte REad 23, Stage3ROFF.HighByte Read 24, Stage4tOn.LowByte REad 25, Stage4TOn.HighByte Read 26, Stage4tOFF.LowByte REad 27, Stage4TOFF.HighByte Read 28, Stage4ROn.LowByte REad 29, Stage4RON.HighByte Read 30, Stage4ROFF.LowByte REad 31, Stage4ROFF.HighByte Read 32, Stage5tOn.LowByte REad 33, Stage5TOn.HighByte Read 34, Stage5tOFF.LowByte REad 35, Stage5TOFF.HighByte Read 36, Stage5ROn.LowByte REad 37, Stage5RON.HighByte Read 38, Stage5ROFF.LowByte REad 39, Stage5ROFF.HighByte Read 40, Stage6tOn.LowByte REad 41, Stage6TOn.HighByte Read 42, Stage6tOFF.LowByte REad 43, Stage6TOFF.HighByte Read 44, Stage6ROn.LowByte REad 45, Stage6RON.HighByte Read 46, Stage6ROFF.LowByte REad 47, Stage6ROFF.HighByte Read 48, Stage7tOn.LowByte REad 49, Stage7TOn.HighByte Read 50, Stage7tOFF.LowByte REad 51, Stage7TOFF.HighByte Read 52, Stage7ROn.LowByte REad 53, Stage7RON.HighByte Read 54, Stage7ROFF.LowByte REad 55, Stage7ROFF.HighByte Read 56, Stage8tOn.LowByte REad 57, Stage8TOn.HighByte Read 58, Stage8tOFF.LowByte REad 59, Stage8TOFF.HighByte Read 60, Stage8ROn.LowByte REad 61, Stage8RON.HighByte Read 62, Stage8ROFF.LowByte REad 63, Stage8ROFF.HighByte Read 64, Stage1Trig Read 65, Stage2Trig Read 66, Stage3Trig Read 67, Stage4Trig Read 68, Stage5Trig Read 69, Stage6Trig Read 70, Stage7Trig Read 71, Stage8Trig Read 72, StageReset1 Read 73, StageReset2 Read 74, StageReset3 Read 75, StageReset4 Read 76, StageReset5 Read 77, StageReset6 Read 78, StageReset7 Read 79, StageReset8 return
- 2nd December 2009, 04:23
Jerson

Since PBP does not allow structures(at least I'm not aware of such), we have to be a little creative. This is purely conceptual, UNTESTED code.

Code:

NoOfStructures: con 8 ' How many channels (1 struct per channel) StructureSize: con 10 'each is a 10 bytes long structure Ton: con 0 ; len 2b ; declare storage for a word Toff: con 2 ; len 2b Ron: con 4 ; len 2b Roff: con 6 ; len 2b Trigger: con 8 ; len 1b Reset: con 9 ; len 1b ' clear out as many eeprom bytes as we need to save data EEbase Data 0(NoOfStructures*StructureSize) ' This is where we bring out our structure to RAM Information: var byte[StructureSize] ' space for 1 structure Count: var byte ' temporary use counter gr0: var byte ' 8channels*10bytes = 80 max gr1: var byte ' Read the settings for channel gr0 from eeprom GetSettings: gr0 = gr0*SizeOfStructure for count = 0 to StructureSize-1 Read gr0+count, Information+count next return ' Put the settings for channel gr0 back to eeprom PutSettings: gr0 = gr0*SizeOfStructure for count = 0 to StructureSize-1 Write gr0+count, Information+count next return ' Accessing the elements of the structure My_Ton = Information[Ton] My_Toff = Information[Toff] ..... and so on
- 2nd December 2009, 04:55
Tobias

Thank you, I will give it a go tonite
- 2nd December 2009, 07:14
sayzer

Try this one, too.
This one uses 6 times less code and does the same thing.
Also, you can use the same variable names as they only refer to the array elements.

Code:

StagesX VAR WORD[32] StagesY VAR BYTE[16] Stage1tOn VAR StagesX[0] 'EEprom location from 0 to 63. Stage1tOFF VAR StagesX[1] Stage1ROn VAR StagesX[2] Stage1ROFF VAR StagesX[3] Stage2tOn VAR StagesX[4] Stage2tOFF VAR StagesX[5] Stage2ROn VAR StagesX[6] Stage2ROFF VAR StagesX[7] Stage3tOn VAR StagesX[8] Stage3tOFF VAR StagesX[9] Stage3ROn VAR StagesX[10] Stage3ROFF VAR StagesX[11] Stage4tOn VAR StagesX[12] Stage4tOFF VAR StagesX[13] Stage4ROn VAR StagesX[14] Stage4ROFF VAR StagesX[15] Stage5tOn VAR StagesX[16] Stage5tOFF VAR StagesX[17] Stage5ROn VAR StagesX[18] Stage5ROFF VAR StagesX[19] Stage6tOn VAR StagesX[20] Stage6tOFF VAR StagesX[21] Stage6ROn VAR StagesX[22] Stage6ROFF VAR StagesX[23] Stage7tOn VAR StagesX[24] Stage7tOFF VAR StagesX[25] Stage7ROn VAR StagesX[26] Stage7ROFF VAR StagesX[27] Stage8tOn VAR StagesX[28] Stage8tOFF VAR StagesX[29] Stage8ROn VAR StagesX[30] Stage8ROFF VAR StagesX[31] Stage1Trig VAR StagesY[0] 'EEprom location from 64 to 79. Stage2Trig VAR StagesY[1] Stage3Trig VAR StagesY[2] Stage4Trig VAR StagesY[3] Stage5Trig VAR StagesY[4] Stage6Trig VAR StagesY[5] Stage7Trig VAR StagesY[6] Stage8Trig VAR StagesY[7] StageReset1 VAR StagesY[8] StageReset2 VAR StagesY[9] StageReset3 VAR StagesY[10] StageReset4 VAR StagesY[11] StageReset5 VAR StagesY[12] StageReset6 VAR StagesY[13] StageReset7 VAR StagesY[14] StageReset8 VAR StagesY[15] Index VAR BYTE Index2 VAR BYTE Temp VAR WORD Read_Data: Index2 = 0 FOR Index = 0 TO 62 STEP 2 READ Index,Temp.LowByte ' Word sized data. Index is the eeprom addr. READ (Index+1),Temp.HighByte StagesX[Index2] = Temp 'Index2 is array adr. IF Index2 < 16 THEN READ (Index2+64),StagesY[Index2] ' Byte sized data. Index2 = Index2 + 1 ' Max. 31. NEXT Index RETURN